Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FOSDEM module changes. #29147

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add FOSDEM module changes. #29147

wants to merge 1 commit into from

Conversation

Half-Shot
Copy link
Member

Rather than forking Element Web again this year, I decided to rewrite the FOSDEM modifications we usually make as a separate module and added a few new Module APIs in the process.

This pairs with matrix-org/matrix-react-sdk-module-api#53

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2025

Sorry to tell you half-shot but https://github.com/matrix-org/matrix-react-sdk-module-api/ won't be updated, it refers to the react-sdk and is owned by the wrong org under the wrong license. https://github.com/element-hq/element-modules/tree/main/packages/element-web-module-api#readme is here to replace it. We don't wish to expand the surface of APIs we commit to supporting long term without explicit API design from the Element Web Team in conjunction with the Product owners.

@Half-Shot
Copy link
Member Author

Sorry to tell you half-shot but https://github.com/matrix-org/matrix-react-sdk-module-api/ won't be updated, it refers to the react-sdk and is owned by the wrong org under the wrong license. https://github.com/element-hq/element-modules/tree/main/packages/element-web-module-api#readme is here to replace it. We don't wish to expand the surface of APIs we commit to supporting long term without explicit API design from the Element Web Team in conjunction with the Product owners.

Ack, I'll have a chat with Product but I suspect this won't be landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants