Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to pending reviews automation #27288

Closed
wants to merge 1 commit into from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 5, 2024

Although it might not actually help with the job that got stuck for 17h because that got stuck before it got started, but this is probably not a bad idea in general.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Although it might not actually help with the job that got stuck for 17h
because that got stuck before it got started, but this is probably
not a bad idea in general.
@dbkr dbkr added the T-Task Tasks for the team like planning label Apr 5, 2024
@dbkr dbkr requested a review from a team as a code owner April 5, 2024 09:04
@dbkr dbkr requested a review from t3chguy April 5, 2024 09:04
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this isn't enough.

image

@dbkr
Copy link
Member Author

dbkr commented Apr 5, 2024

mmm, I saw a few of them over 2 mins... since it runs regularly I figured just axe them if they're taking that long, but we can also up it to 5?

@dbkr dbkr closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants