Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybinding code unification #3 #21132

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Keybinding code unification #3 #21132

merged 2 commits into from
Feb 23, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Feb 19, 2022 •
edited by github-actions bot
Loading

Type: task
Requires matrix-org/matrix-react-sdk#7850

This change is marked as an internal change (Task), so will not be included in the changelog.

@SimonBrandner SimonBrandner mentioned this pull request Feb 19, 2022
Merged
@github-actions github-actions bot added the T-Task Tasks for the team like planning label Feb 19, 2022
@SimonBrandner
i18n
1d4d7af 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review February 20, 2022 09:34
@SimonBrandner SimonBrandner requested a review from a team as a code owner February 20, 2022 09:34
andybalaam
andybalaam approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not particularly confident about my review, so I'll leave some time a) for the release to be done and b) for someone else to review if they get a chance.

@andybalaam andybalaam merged commit 3810b7e into element-hq:develop Feb 23, 2022
@SimonBrandner SimonBrandner deleted the task/keybinds-unification-3 branch February 23, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @andybalaam