Add support for CAS auth #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,22 +23,29 @@ sdk.loadModule(require('../modules/VectorConferenceHandler')); | |||
|
|
|||
| var lastLocationHashSet = null; | |||
|
|
|||
|
|
|||
| function parseQueryParams(location) { | |||
There was a problem hiding this comment.
AFAIK vector will be passed through browserify which supports core node moules so you can just do:
var qs = require("querystring");
var params = qs.parse("foo=bar&baz=3");
console.log(params.foo) // "bar"Using this is preferable because it handles common edge cases which are easy to forget when rolling your own (e.g. foo=bar&baz is valid (baz is a 0-length string) but this implementation will not catch that).
|
@kegsay - Some additional commits added, basically moved all of the CAS logic down to react-sdk, keeping only UI stuff here. Also now using querystring to parse the name / value pairs from the fragment. |
| var lastLocationHashSet = null; | ||
|
|
||
|
|
||
| // We want to support some name / value pairs in the fragment | ||
| // so we're re-using query string ike format |
|
LGTM other than very minor things. Pending @dbkr feedback. |
|
LGTM |
|
Nudge Looks like both reviewers are happy, any chance this can be merged soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial and basic CAS login.
Flow is:
Doesn't do anything with logout yet.
Also, the CAS login page will only be shown if CAS is the first login flow returned from the HS
Tested locally and works.
No doubt plenty of room for improvement on this works but it's a starting point and I'm happy to be given pointers for improvements before it get's merged!
Related to:
matrix-org/synapse#295
matrix-org/matrix-js-sdk#20
matrix-org/matrix-react-sdk#19
Signed-off-by: Steven Hammerton [email protected]