-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi language spell check #15851
Add multi language spell check #15851
Conversation
I am assuming this is not ready for review, since it's marked as a draft, so please let us know when it's ready for a look. |
@jryans No, it's not ready. I'll let you know when it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good, but just curious about the setting.
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great. Just a few small tweaks, and then let's merge it! 😄
Co-authored-by: J. Ryan Stinnett <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
…om/SimonBrandner/element-web into feature-multi-language-spell-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's go for it! 🎉
Changes in [1.7.26](https://github.com/vector-im/element-web/releases/tag/v1.7.26) (2021-04-26) =============================================================================================== [Full Changelog](element-hq/element-web@v1.7.26-rc.1...v1.7.26) * Upgrade to React SDK 3.19.0 and JS SDK 10.0.0 Changes in [1.7.26-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.26-rc.1) (2021-04-21) ========================================================================================================= [Full Changelog](element-hq/element-web@v1.7.25...v1.7.26-rc.1) * Upgrade to React SDK 3.19.0-rc.1 and JS SDK 10.0.0-rc.1 * Translations update from Weblate [\#17031](element-hq/element-web#17031) * Bump ssri from 6.0.1 to 6.0.2 [\#17010](element-hq/element-web#17010) * Fix `NODE_ENV` value for CI environments [\#17003](element-hq/element-web#17003) * Use React production mode in CI builds [\#16969](element-hq/element-web#16969) * Labs documentation for DND mode [\#16962](element-hq/element-web#16962) * Rename blackboxing to new option ignore list [\#16965](element-hq/element-web#16965) * Remove velocity-animate from lockfile [\#16963](element-hq/element-web#16963) * Add mobile download link configuration [\#16890](element-hq/element-web#16890) * Switch develop to not-staging Scalar by default [\#16883](element-hq/element-web#16883) * Support a config option to skip login/welcome and go to SSO [\#16880](element-hq/element-web#16880) Changes in [1.7.25](https://github.com/vector-im/element-web/releases/tag/v1.7.25) (2021-04-12) =============================================================================================== [Full Changelog](element-hq/element-web@v1.7.25-rc.1...v1.7.25) * Upgrade to React SDK 3.18.0 and JS SDK 9.11.0 Changes in [1.7.25-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.25-rc.1) (2021-04-07) ========================================================================================================= [Full Changelog](element-hq/element-web@v1.7.24...v1.7.25-rc.1) * Upgrade to React SDK 3.18.0-rc.1 and JS SDK 9.11.0-rc.1 * Translations update from Weblate [\#16882](element-hq/element-web#16882) * Revert "Docker image: serve pre-compressed assets using gzip_static" [\#16838](element-hq/element-web#16838) * Move native node modules documentation to element-desktop [\#16814](element-hq/element-web#16814) * Add user settings for warn before exit [\#16781](element-hq/element-web#16781) * Change ISSUE_TEMPLATE bold lines to proper headers [\#16768](element-hq/element-web#16768) * Add example for deployment into Kubernetes [\#16447](element-hq/element-web#16447) * Create bare-bones `PULL_REQUEST_TEMPLATE.md` [\#16770](element-hq/element-web#16770) * Add webpack config and labs flag docs for voice messages [\#16705](element-hq/element-web#16705) Changes in [1.7.24](https://github.com/vector-im/element-web/releases/tag/v1.7.24) (2021-03-29) =============================================================================================== [Full Changelog](element-hq/element-web@v1.7.24-rc.1...v1.7.24) * Upgrade to React SDK 3.17.0 and JS SDK 9.10.0 Changes in [1.7.24-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.24-rc.1) (2021-03-25) ========================================================================================================= [Full Changelog](element-hq/element-web@v1.7.23...v1.7.24-rc.1) * Upgrade to React SDK 3.17.0-rc.2 and JS SDK 9.10.0-rc.1 * Translations update from Weblate [\#16766](element-hq/element-web#16766) * Docker image: serve pre-compressed assets using gzip_static [\#16698](element-hq/element-web#16698) * Fix style lint issues [\#16732](element-hq/element-web#16732) * Updated expected webpack output in setup guide [\#16740](element-hq/element-web#16740) * Docs for `loginForWelcome` [\#16468](element-hq/element-web#16468) * Disable rageshake persistence if no logs would be submitted [\#16697](element-hq/element-web#16697) Changes in [1.7.23](https://github.com/vector-im/element-web/releases/tag/v1.7.23) (2021-03-15) =============================================================================================== [Full Changelog](element-hq/element-web@v1.7.23-rc.1...v1.7.23) * Upgrade to React SDK 3.16.0 and JS SDK 9.9.0 Changes in [1.7.23-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.23-rc.1) (2021-03-10) ========================================================================================================= [Full Changelog](element-hq/element-web@v1.7.22...v1.7.23-rc.1) * Upgrade to React SDK 3.16.0-rc.2 and JS SDK 9.9.0-rc.1 * Translations update from Weblate [\#16655](element-hq/element-web#16655) * Improve docs for customisations [\#16652](element-hq/element-web#16652) * Update triage guide to match the new label scheme [\#16612](element-hq/element-web#16612) * Remove a couple useless 'use strict' calls [\#16650](element-hq/element-web#16650) * Remove old conferencing doc [\#16648](element-hq/element-web#16648) * Bump elliptic from 6.5.3 to 6.5.4 [\#16644](element-hq/element-web#16644) * Add option for audio live streaming [\#16604](element-hq/element-web#16604) * Update velocity-animate dependency [\#16605](element-hq/element-web#16605) * Add Edge to the supported tier [\#16611](element-hq/element-web#16611) * Add multi language spell check [\#15851](element-hq/element-web#15851) * Document feature_spaces [\#16538](element-hq/element-web#16538)
This depends on these PRs: PR 1, PR 2, you can find more info there.
Signed-off-by: Šimon Brandner [email protected]