-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links in README.md to point to Element #14973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping with this! 😄 A few comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few more references to the Docker image that need to revert for now.
README.md
Outdated
would be: | ||
```bash | ||
docker run -p 80:80 -v /etc/riot-web/config.json:/app/config.json vectorim/riot-web | ||
docker run -p 80:80 -v /etc/element-web/config.json:/app/config.json vectorim/element-web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker run -p 80:80 -v /etc/element-web/config.json:/app/config.json vectorim/element-web | |
docker run -p 80:80 -v /etc/element-web/config.json:/app/config.json vectorim/riot-web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh man....i'm really sorry for being so blind 🙈😓
will get to it ASAP
README.md
Outdated
git checkout master | ||
docker build -t vectorim/riot-web . | ||
docker build -t vectorim/element-web . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker build -t vectorim/element-web . | |
docker build . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm...this is a docker build command, so couldn't we leave it at element-web
? Or do you think user could be confused about the alternating use of element-web
and riot-web
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point! Actually, I kind of think it would make sense to just omit the tag entirely...? If you are building the image yourself, you probably want to tag it differently anyway. So, I'd say remove the -t
arg here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Updated suggestion to match.)
README.md
Outdated
```bash | ||
docker build -t vectorim/riot-web:develop \ | ||
docker build -t vectorim/element-web:develop \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker build -t vectorim/element-web:develop \ | |
docker build \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the revisions, looks great to me. 😄
Thanks for the patience 😅 |
There still one or two links pointing to Riot specific stuff, as there exists no equivalent for Element, at least as far as i know.
These are: