Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labs flag for alternate message layouts #13350

Merged

Conversation

JorikSchellekens
Copy link
Contributor

@JorikSchellekens JorikSchellekens commented Apr 23, 2020

Impelemts setting for matrix-org/matrix-react-sdk#4531

@JorikSchellekens JorikSchellekens requested a review from a team April 23, 2020 18:12
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to review this without a partner PR

docs/labs.md Outdated
@@ -12,6 +12,10 @@ dropped. Ask in the room if you are unclear about any details here.**
Enables font scaling options for accessibility. To alter the scale check the
appearance tab in settings.

## Alternate message layouts (`feature_alternate_message_layouts`)

Enables options in rooms settings to switch between message layouts such as the default and "irc-like" layouts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

room settings sounds like the wrong place to put this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it's now a labs setting which covers all rooms

@JorikSchellekens JorikSchellekens requested a review from turt2live May 7, 2020 15:18
@JorikSchellekens
Copy link
Contributor Author

The partner pr is up fyi

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need a riot-desktop PR now (sorry)

@turt2live
Copy link
Member

ftr: generally a multi-part PR shouldn't land in pieces this far apart without approving reviews on all sides. Also not sure what happened to have caused this one to be blocked on my review but the actual functionality to end up in the main queue, but that might be for a retro.

@turt2live turt2live merged commit aae5e4c into element-hq:develop May 19, 2020
turt2live added a commit to element-hq/element-desktop that referenced this pull request May 19, 2020
@turt2live
Copy link
Member

need a riot-desktop PR now

element-hq/element-desktop#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants