Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax macOS notarisation check to print a warning #12503

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Relax macOS notarisation check to print a warning #12503

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
420537a
Relax macOS notarisation check to print a warning
jryans Feb 25, 2020
bdb395a
Change to banner style
jryans Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/electron_afterSign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ exports.default = async function(context) {
// from the keychain, so we need to get it from the environment.
const userId = process.env.NOTARIZE_APPLE_ID;
if (userId === undefined) {
throw new Error("User ID not found. Set NOTARIZE_APPLE_ID.");
console.warn(
"Skipping notarisation: User ID not found, set NOTARIZE_APPLE_ID.",
);
return;
}

console.log("Notarising macOS app. This may be some time.");
Expand Down