Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete should strip off (IRC) from displaynames #574

Closed
matrixbot opened this issue Dec 28, 2015 · 13 comments · Fixed by matrix-org/matrix-react-sdk#417
Closed

autocomplete should strip off (IRC) from displaynames #574

matrixbot opened this issue Dec 28, 2015 · 13 comments · Fixed by matrix-org/matrix-react-sdk#417

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.

@AmandineLP
Copy link
Contributor

How do you disambiguate if Matthew and Matthew (IRC) are 2 different people?

@AmandineLP AmandineLP added this to the v1 - Private Preview milestone Jan 12, 2016
@fuzzy76
Copy link

fuzzy76 commented May 26, 2016

You don't. The autocomplete nick is for the receiving human to notice their name. Generally they have no use being told which protocol they are on.

I guess you could leave it in if the room has more than one Matthew in it. But for most use cases, this just looks really awkward.

@aviraldg
Copy link
Contributor

@ara4n I'm guessing this is irrelevant now, since we're getting rid of the (IRC) suffix altogether?

@gwicke
Copy link

gwicke commented Jul 29, 2016

@aviraldg, is this still happening? I'm still getting the (IRC) suffix in autocomplete.

@ara4n
Copy link
Member

ara4n commented Aug 1, 2016

yes, it's not been done yet as we were hoping to fix it with groups instead of a horrid heuristic hack, but groups are taking longer to land. so we should just do the heuristic. @aviraldg, don't suppose you want to do the honours as you're in autocomplete mode?

@ara4n
Copy link
Member

ara4n commented Aug 8, 2016

thanks @aviraldg!

@ara4n ara4n closed this as completed Aug 8, 2016
@gwicke
Copy link

gwicke commented Aug 9, 2016

Could you ping this task when this change is deployed?

@aviraldg
Copy link
Contributor

aviraldg commented Aug 9, 2016

It has already been deployed on /develop.

On Tue 9 Aug, 2016, 10:28 PM Gabriel Wicke, [email protected]
wrote:

Could you ping this task when this change is deployed?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#574 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOlRF7SQFy5_bzpReHgiixSo23hm8-jks5qeLGlgaJpZM4G8Eqx
.

@gwicke
Copy link

gwicke commented Aug 9, 2016

@aviraldg, I'm using /develop, and still see (IRC) in autocompletion of IRC nicks even after a shift-reload. Could you verify that the change is really deployed & works for you on /develop?

@aviraldg
Copy link
Contributor

aviraldg commented Aug 9, 2016

This was only fixed in the new autocomplete so you'll have to turn RTE on
from Labs to see it.

On Tue 9 Aug, 2016, 11:10 PM Gabriel Wicke, [email protected]
wrote:

@aviraldg https://github.com/aviraldg, I'm using /develop, and still
see (IRC) in autocompletion of IRC nicks even after a shift-reload.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#574 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOlRDl6wYdyiBBgMKP3wRjFsFygUpddks5qeLpPgaJpZM4G8Eqx
.

@gwicke
Copy link

gwicke commented Aug 9, 2016

so you'll have to turn RTE on from Labs to see it.

Do you have a pointer to instructions on how to do this?

Edit: Nevermind, I think I found it as "Rich Text Editor" in the user preferences. With that enabled, tab completion seems to be broken completely.

Edit 2: As @aviraldg points out in chat, the rich text editor mode expects a @ for name completions. It then expands to a full matrix user name, (ex: @freenode_SomeUser:matrix.org), which is also what is visible when pinging IRC users.

Until this becomes more usable for communication with IRC channels (at least, avoid long form user names), would it be possible to strip the (IRC) suffix in plain editor tab completion?

@ara4n
Copy link
Member

ara4n commented Aug 9, 2016

@aviraldg: i'd really like to avoid pointing people at the RTE until it's ready for use. For a trivial fix like this please let's just backport it to the current autocomplete code.

@aviraldg
Copy link
Contributor

aviraldg commented Aug 9, 2016

@ara4n: from discussions on #vector-dev I was under the impression that you
wanted dev to focus on new autocomplete? nvm, will fix up in old
tabcomplete too.

On Wed, Aug 10, 2016 at 1:54 AM Matthew Hodgson [email protected]
wrote:

@aviraldg https://github.com/aviraldg: i'd really like to avoid
pointing people at the RTE until it's ready for use. For a trivial fix like
this please let's just backport it to the current autocomplete code.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#574 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOlRAwVPjKYe7fGTttRfgkLx5VsFYKmks5qeOHpgaJpZM4G8Eqx
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants