-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete should strip off (IRC) from displaynames #574
Comments
How do you disambiguate if Matthew and Matthew (IRC) are 2 different people? |
You don't. The autocomplete nick is for the receiving human to notice their name. Generally they have no use being told which protocol they are on. I guess you could leave it in if the room has more than one Matthew in it. But for most use cases, this just looks really awkward. |
@ara4n I'm guessing this is irrelevant now, since we're getting rid of the (IRC) suffix altogether? |
@aviraldg, is this still happening? I'm still getting the (IRC) suffix in autocomplete. |
yes, it's not been done yet as we were hoping to fix it with groups instead of a horrid heuristic hack, but groups are taking longer to land. so we should just do the heuristic. @aviraldg, don't suppose you want to do the honours as you're in autocomplete mode? |
thanks @aviraldg! |
Could you ping this task when this change is deployed? |
It has already been deployed on /develop. On Tue 9 Aug, 2016, 10:28 PM Gabriel Wicke, [email protected]
|
@aviraldg, I'm using /develop, and still see (IRC) in autocompletion of IRC nicks even after a shift-reload. Could you verify that the change is really deployed & works for you on /develop? |
This was only fixed in the new autocomplete so you'll have to turn RTE on On Tue 9 Aug, 2016, 11:10 PM Gabriel Wicke, [email protected]
|
Do you have a pointer to instructions on how to do this? Edit: Nevermind, I think I found it as "Rich Text Editor" in the user preferences. With that enabled, tab completion seems to be broken completely. Edit 2: As @aviraldg points out in chat, the rich text editor mode expects a Until this becomes more usable for communication with IRC channels (at least, avoid long form user names), would it be possible to strip the |
@aviraldg: i'd really like to avoid pointing people at the RTE until it's ready for use. For a trivial fix like this please let's just backport it to the current autocomplete code. |
@ara4n: from discussions on #vector-dev I was under the impression that you On Wed, Aug 10, 2016 at 1:54 AM Matthew Hodgson [email protected]
|
Created by @ matthew:matrix.org.
The text was updated successfully, but these errors were encountered: