Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen reader reads out my message twice when I send it #5697

Closed
pafcu opened this issue Nov 26, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3007 or matrix-org/matrix-react-sdk#3019
Closed

Screen reader reads out my message twice when I send it #5697

pafcu opened this issue Nov 26, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3007 or matrix-org/matrix-react-sdk#3019
Labels
A11y P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Community-PR Issue is solved by a community member's PR
Milestone
Accessibility Imp...

Comments

@pafcu
Copy link
Contributor

pafcu commented Nov 26, 2017

Description

With the orca screen reader, when I send a message, I get it read out twice.

Steps to reproduce

  • Start the orca screen reader
  • Go to a room
  • Send a message
  • Hear said message twice

Version information

Riot web c28d9e5-react-c002d3ff9967-js-36ff0ad0193e on FF 57 and orca 3.26.0
@pafcu pafcu changed the title Screen readers reads out my message twice when I send it Screen reader reads out my message twice when I send it Nov 26, 2017
@turt2live
Copy link
Member

Brief research tells me this might be solvable with aria-live.

@lampholder lampholder added I18n T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 labels Dec 1, 2017
@pvagner pvagner mentioned this issue Dec 5, 2017
Closed
pvagner added a commit to pvagner/matrix-react-sdk that referenced this issue May 28, 2018
@pvagner
Conditionally enable aria-live region for the timeline scroll pannel
d533176 
(fixes element-hq/element-web#5696 and element-hq/element-web#5697)
We only wish to set aria-live to polite when the list is scrolled to the
bottom
to avoid flooding screen readers with loads of DOM changes when
scrolling
causing presentation of random message events.
To avoid presenting outgoing events twice we are only setting aria-live
when there is
a new content to add so e.g. style changes and similar won't be
propagated to assistive tools.
@pvagner pvagner mentioned this issue May 28, 2018
Closed
@turt2live turt2live added this to the Accessibility Improvements milestone May 16, 2019
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label May 16, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute avatars and read receipts on event tiles
4779144 
This reduces overall noise from the screen reader. It was reading the alt attribute from the sender avatar, which was just a mxid. The read receipts were just nonsensical noise.

Fixes element-hq/element-web#2716
Fixes element-hq/element-web#5697
See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute timestamps for irrelevant updates
68c4ee9 
Other fix for element-hq/element-web#5697

See element-hq/element-web#9747
@turt2live turt2live mentioned this issue May 22, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute avatars and read receipts on event tiles
6edf760 
This reduces overall noise from the screen reader. It was reading the alt attribute from the sender avatar, which was just a mxid. The read receipts were just nonsensical noise.

Fixes element-hq/element-web#2716
Fixes element-hq/element-web#5697
See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute timestamps for irrelevant updates
8f6884e 
Other fix for element-hq/element-web#5697

See element-hq/element-web#9747
@turt2live turt2live mentioned this issue May 22, 2019
Merged
@jryans jryans added A11y and removed I18n labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11y P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
Accessibility Improvements
4 participants
@pafcu @jryans @turt2live @lampholder