Links with markdown formatting in (eg underscores) are interpreted as markdown

[dbkr]

eg. type http://domain.xyz/foo/bar-_stuff-like-this_-in-it.jpg in markdown mode, it ends up as a link with italics instead of the underscores

[lukebarnard1]

Plan of action is to RegExp URLs prior to markdown parsing to make them [url](url)-style md links. This should really use linkify-js, the thing we use to turn URLs into <a>s in the timeline, but unfortunately it doesn't have an API for replacing a URL with an arbitrary string.

[ara4n]

#1270 introduced #4809 and has been reverted; unfortunately this means that this is open again. #4809 has much discussion over possible better fixes, but the TL;DR is:

• Either we change back to GFM
• Or we patch commonmark to behave like GFM (and create a horrible custom MD dialect)
• Or we write an adhoc parser which goes through and finds things which look like non-code blocks and try to linkify them and then MD-escape them
• Or we take commonmark's AST and try to guess where commonmark has got it wrong and then modify the AST to remove the spurious italics etc.

[ara4n]

twinned with #3428

[bhearsum]

At the risk of piling on, this is especially annoying if you commonly link to python code -- where __init__.py is a common file name.

[kittykat]

Can confirm that this is still valid:

[babolivier]

I'm using latest develop (f496d6d5bf31-react-4a6d46b76adc-js-87b920698f4c, which according to https://github.com/matrix-org/matrix-react-sdk/commits/4a6d46b76adc includes the fix from matrix-org/matrix-react-sdk#7200) and this issue still persists:

(this is when pasting https://github.com/matrix-org/synapse/blob/develop/synapse/module_api/__init__.py into the composer)

So I think this issue needs reopening.

[Palid]

@babolivier thanks for catching, fixed in matrix-org/matrix-react-sdk#7257 😄

[babolivier]

Can confirm it works great now, thanks a lot @Palid! 😁

[hho]

Should this work in

Element version: 1.9.6
Olm version: 3.2.3

now?

Because, for me it still doesn't:

My test URL is https://www.bora.com/fileadmin/_processed_/5/e/csm_Headerbild_BORA_Classic_2_L_e8dfdf2889.jpg.webp

It get's rendered as https://www.bora.com/fileadmin/processed/5/e/csm_Headerbild_BORA_Classic_2_L_e8dfdf2889.jpg.webp instead.

[t3chguy]

This fix is on develop, not yet in a release. Be patient.