-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compact layout tweaks #4363
Comments
Another suggestion: remove the line break between the username and the comment. This brings it much closer to IRC, or to Slack's compact theme, for information density. |
I would really like to see an option to turn off avatars. |
I suspect that hiding avatars and/or putting the username on the same line as the comment would have to be separate options. Or perhaps change the compact layout from an on/off to allowing users to choose a level of compactness. @ara4n, any comments on this? |
I created a separate issue for this: element-hq/element-meta#1589. I think this should be a separate option, if possible. And yeah as tidux said, I think the break should also disappear, or maybe another option to allow vertically aligning nicknames / contents. Boldifying the nickname would also be a nice addition. For most people that come from older clients it's really hard to distinguish at first glance who wrote what. |
@MightyCreak: You only need one "\n" to create a linebreak. Riot just represents a "\n\n" as a blank line, so I don't know if there's much we can do about that. Agreed about the list spacing, though, and I've added that to the list. |
I thought that was what Riot was doing, since it uses CommonMark, and the spec says:
Paragraph is a feature I use in Slack quite frequently. It's definitely a useful feature when explaining something a bit complex in just one message. And here, the fact that it's just replacing |
Testing it further, it seems like it does two different things depending on whether the markdown processing is triggered or not. If it is not, then it just inserts a double line break, but if it is, then uses paragraph elements. With the former, there isn't much that the compact layout can do, but with the latter, it can be changed. |
I'm trying to reproduce what you're explaining, but I only have double line breaks all the time 😕 |
https://matrix.to/#/!vfFxDRtZSSdspfTSEr:matrix.org/$14983637271272828rNHxb:matrix.org uses paragraphs. It still looks like double line breaks, because the CSS hasn't been changed, but at least it is possible to be changed. It's unfortunate, though, that the rich text editor seems to use |
- add some comments - decrease size of info events and MELS (element-hq#4363.2) - reduce spacing between paragraphs, lists, etc (element-hq#4363.3 & 4) Signed-off-by: Hubert Chathi <[email protected]>
@jfrederickson that happens without compact mode also, but worse, as the avatar is bigger you see even less of it :) |
Oh hah, so it does. It's been a while since I've had compact mode disabled. XD |
@erdnaxeli thanks for the comparison screenshot. Riot in general needs to work better in narrow windows (#1633). The main differences between Slack and Riot that I can see are:
Interestingly, Slack seems to have a larger-than-necessary right margin, which approximately corresponds to the space reserved in Riot for the "..." menu. It might be possible to get rid of that space in Riot, and allow the "..." menu to cover up part of the message, since it only appears on hover. Some of these issues should probably be fixed as part of #1633, so that it would benefit both compact and non-compact users. |
One thing Slack does better is not having avatars at all for the left hand sidebar. That results in a large increase in information density while still being usable. |
Yup, that's kind of similar to hiding user avatars, which has been requested too. I think both hiding user avatars and hiding room avatars should be a separate configuration option, since some people would want avatars, and some people won't. Another possibility may be to shrink the room avatars (maybe to favicon size?), which would also mirror the request to shrink the user avatars. |
created #5895 to track the request for keeping user names on the same line as messages |
Hi, I created some compact user-styles for testing/inspiration here https://userstyles.org/styles/153285/riot-chat. Once this is merged I can hopefully delete those. How do we continue? I'm eager to help with this. I would recommend not doing a granular "compactness" setting. Having normal + compact should work for most users. Additionally, if spacings are defined in relation to the font-size, users can already adjust that. |
There's a new Gtk/Rust client, Fractal, that pretty much nails the density that a compact theme should be going for if it had names and messages on the same lines. The biggest issue in Riot is probably that the line breaks are simply too big. |
I did the same for both sidebars and the topbar (https://github.com/dannycolin/riot-compact) |
Many of these cases will have been handled over the years, and unfortunately large checklists like this aren't as helpful in modern times. If folks have specific areas they have concerns with, please open new issues. |
Some suggestions that have come up regarding the compact timeline layout:
The text was updated successfully, but these errors were encountered: