Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSISDN registration should warn/error for unsupported countries #3542

Closed
ara4n opened this issue Mar 30, 2017 · 11 comments
Closed

MSISDN registration should warn/error for unsupported countries #3542

ara4n opened this issue Mar 30, 2017 · 11 comments
Labels
A-Registration P1 S-Critical Prevents work, causes data loss and/or has no workaround S-Tolerable Low/no impact on users T-Defect X-Blocked

Comments

@ara4n
Copy link
Member

ara4n commented Mar 30, 2017

I just had a minor disaster in an important demo where the folks trying Riot all tried to sign-up with phone numbers in Hong Kong. Unsurprisingly, the 2FA SMS didn't work. We shouldn't just silently fail :(

@lampholder
Copy link
Member

:(

Amandine has already raised this. I think making it work is actually an easy fix, esp. outside of the US/Canada (probably easier than modifying the clients with caveat text) - we just need to set the originator.

@lampholder
Copy link
Member

@dbkr hardcoded the originator, which should make this work properly for global SMS with the exception of the US and Canada. US and Canada are currently expected in ~a week.

@lampholder
Copy link
Member

If we are releasing /develop before US/Canada goes live we should put a warning on the sign up and settings pages. I don't know what we should do about the mobile apps - a multi-day lead time on releasing to the various app stores makes managing this a challenge.

IIRC the apps downgrade gracefully if the server doesn't support msisdn sign up - @ara4n might we consider disabling it in the matrix.org server until we've verified SMS sending is working globally (hopefully a week away)?

@ara4n
Copy link
Member Author

ara4n commented Apr 1, 2017

i wouldn't object too much to hiding it until the OM side is sorted properly.

@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users S-Critical Prevents work, causes data loss and/or has no workaround P1 ui/ux labels Apr 3, 2017
@lampholder lampholder changed the title MSISDN login should warn/error for unsupported countries MSISDN registration should warn/error for unsupported countries Apr 3, 2017
@lampholder
Copy link
Member

I've changed my mind about hiding it.

My reasoning - even once US/Canada is provisioned, there are numerous international SMS delivery caveats that we might fall foul of in the early months (and, indeed, ongoing). E.g. Romania, I learned today, doesn't support UK VMN as originator, so our global fix of hardcoding the originator doesn't work there :(

I think we want to be live with this feature before we can have tested delivery globally, so I think modifying the interface to include the caveat and a link to status is the way to go.

@lampholder lampholder added this to the RW002 milestone Apr 3, 2017
@lampholder
Copy link
Member

I've changed my mind again :) Because we can't get a warning notice in front of iPhone/Android users until a release is pushed out, I think we should disable this in Synapse to stop new people from seeing the (possibly doomed to failure) option to register with their msisdn.

@lampholder lampholder changed the title MSISDN registration should warn/error for unsupported countries Extend MSISDN verification coverage: MSISDN registration should warn/error for unsupported countries Apr 12, 2017
@lampholder lampholder changed the title Extend MSISDN verification coverage: MSISDN registration should warn/error for unsupported countries MSISDN registration should warn/error for unsupported countries Apr 12, 2017
@lampholder lampholder modified the milestones: RW003 - candidates, RW002 Apr 21, 2017
dbkr added a commit to matrix-org/sydent that referenced this issue Apr 21, 2017
Reject requests to send SMS to countries based on rules in the
config file

element-hq/element-web#3542
@dbkr
Copy link
Member

dbkr commented Apr 26, 2017

Blocked on matrix-org/synapse#2147

@dbkr dbkr added the X-Blocked label Apr 27, 2017
@dbkr
Copy link
Member

dbkr commented May 3, 2017

Synapse PR now merged, we should probably wait for deploy / release

@ara4n
Copy link
Member Author

ara4n commented May 27, 2017

bleurgh:

Shaltay joined
Hi
How can I add my phome number from Russia? I did it before without any problems, now it says "not supported

slipeer added a commit to slipeer/sydent that referenced this issue May 31, 2017
* Add support for rejecting sms reqs to countries

Reject requests to send SMS to countries based on rules in the
config file

element-hq/element-web#3542

* Oops - fix docs to not lie
slipeer added a commit to slipeer/sydent that referenced this issue Jun 6, 2017
* Add support for rejecting sms reqs to countries

Reject requests to send SMS to countries based on rules in the
config file

element-hq/element-web#3542

* Oops - fix docs to not lie
slipeer added a commit to slipeer/sydent that referenced this issue Jul 5, 2017
* Add support for rejecting sms reqs to countries

Reject requests to send SMS to countries based on rules in the
config file

element-hq/element-web#3542

* Oops - fix docs to not lie
@lampholder lampholder modified the milestones: RW004, RW008 - Candidates, RW009 - Candidates Apr 24, 2018
@lampholder
Copy link
Member

We commented our Russia, so it now will try and send SMS there.

@ara4n
Copy link
Member Author

ara4n commented Sep 11, 2018

this all happened; and russia got special cased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Registration P1 S-Critical Prevents work, causes data loss and/or has no workaround S-Tolerable Low/no impact on users T-Defect X-Blocked
Projects
None yet
Development

No branches or pull requests

3 participants