Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for redacted events #3390

Closed
dbkr opened this issue Mar 9, 2017 · 2 comments
Closed

CSS for redacted events #3390

dbkr opened this issue Mar 9, 2017 · 2 comments
Assignees
Labels
P1 S-Tolerable Low/no impact on users T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Mar 9, 2017

matrix-org/matrix-react-sdk#739 needs better CSS

#3379 is the working CSS

@dbkr dbkr added the S-Tolerable Low/no impact on users label Mar 9, 2017
@ara4n
Copy link
Member

ara4n commented Mar 13, 2017

before I try to fix up the CSS for this, please can the visible redaction be tweaked to display the sender's name, message timestamp, etc? I assumed that folks knew what a redaction looked like, but the idea is something like this:

image

Obviously we don't know the right size of black-out to use, so i'd suggest just making it 30 characters wide or something.

To be explicit, I think a sensible appearance would be:

screen shot 2017-03-13 at 00 16 11

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Mar 13, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 13, 2017

@ara4n we can't show sender or TS until JS-SDK doesn't redact origin_server_ts or sender. See matrix-org/matrix-js-sdk#387

Also, thanks for the explicit design.

.mx_EventTile.mx_EventTile_redacted {
    max-width: 400px;
    margin-left: 63px;
}

would make it look as you suggest.

lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 16, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This is part of fixing element-hq/element-web#3390
lukebarnard1 pushed a commit that referenced this issue Mar 16, 2017
See #3390

Also: The "Redact" option in the MessageContextMenu no longer appears for redacted events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants