Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Direct chat' toggle seems broken #3355

Closed
richvdh opened this issue Mar 3, 2017 · 1 comment
Closed

'Direct chat' toggle seems broken #3355

richvdh opened this issue Mar 3, 2017 · 1 comment
Assignees
@lukebarnard1
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@richvdh
Copy link
Member

richvdh commented Mar 3, 2017

Clicking on 'direct chat' in the dropdown doesn't seem to do anything - I can't flag non-DMs as DMs or vice versa. Also some reports that the flag has been spontaneously cleared on all chats for some people
@ara4n
Copy link
Member

ara4n commented Mar 3, 2017

the latter is #3331.

@turt2live turt2live mentioned this issue Mar 3, 2017
Closed
@ara4n ara4n added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 X-Regression ui/ux labels Mar 8, 2017
lukebarnard1 pushed a commit that referenced this issue Mar 16, 2017
Fix the people section
f8298b2 
This does two things:
 - Fixes an incorrect import that was causing Direct Chat toggle to not be editable #3355
 - Use props.list in RoomSubList when calculating whether to show IncomingCallDialog. Fixes #2956
@lukebarnard1 lukebarnard1 mentioned this issue Mar 16, 2017
Merged
@lukebarnard1 lukebarnard1 self-assigned this Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @richvdh @lukebarnard1