Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusBar now has 2px of StatusAreaLine above it, misbalancing the in-call status bar #3269

Closed
ara4n opened this issue Feb 19, 2017 · 4 comments
Assignees

Comments

@ara4n
Copy link
Member

ara4n commented Feb 19, 2017

@lukebarnard1 i think this was added as part of the new StatusBar stuff - is there a way we can get rid of the 2px that has snuck in on the top? The height of StatusBar is meant to be 50px, not 52px.

@lukebarnard1 lukebarnard1 self-assigned this Feb 20, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 20, 2017

If the StatusBarArea should be 50px, the StatusBox will have to be 48px, (with line-height 48px).

@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

As per the title of the bug, the reason i was asking to get rid of the 2px line is because it breaks the vertical symmetry by having 2px of additional content at the top which isn't at the bottom, which in turn contributes to #3182:

screen shot 2017-02-21 at 15 35 46

So ironically shrinking the area to 48px actually makes the misbalancing more pronounced and ugly! :)

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Feb 21, 2017

How does this look, @ara4n?
2017-02-21-160141_210x63_scrot
I took 3px off the top off line height for "Active call".

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 2, 2017

Removing top line works and everything looks aligned.

lukebarnard1 pushed a commit that referenced this issue Mar 2, 2017
This is to keep things vertically balanced.

Fixes #3269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants