Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rich text emotes have incorrect linebreaks after the * Matthew #27896

Closed
ara4n opened this issue Aug 3, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12862
Closed

rich text emotes have incorrect linebreaks after the * Matthew #27896

ara4n opened this issue Aug 3, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12862
Labels
A-Emotes O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Aug 3, 2024 •
edited
Loading

Steps to reproduce

  1. Type /me *does something*
  2. Note that it renders as:

Screenshot 2024-08-03 at 21 30 02

I've fixed this before, but it's regressed - the markdown renderer is putting a <p/> around the rich text causing a linebreak. It needs to be manually stripped off of emotes (or messages in general) when rendering to avoid the spurious linebreak.

Outcome

What did you expect?

No unexpected line breaks in rich text emotes.

What happened instead?

An unexpected linebreak after the name of the user.

Operating system

No response

Application version

Element Nightly version: 2024080301 Crypto version: Rust SDK 0.7.1 (c8c9d15), Vodozemac 0.6.0

How did you install the app?

No response

Homeserver

No response

Will you send logs?

negative ghostrider
@ara4n ara4n added the T-Defect label Aug 3, 2024
@dosubot dosubot bot added A-Emotes O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 3, 2024
@t3chguy t3chguy mentioned this issue Aug 5, 2024
Closed
@dbkr
Copy link
Member

dbkr commented Aug 5, 2024

This might be a regression from the RTL stuff.

@dbkr dbkr added X-Regression O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 5, 2024
@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2024 •
edited
Loading

I don't believe it is, I recall this from quite a long while ago

nvm, it seems like it was fixed at some point and now regressed again

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 5, 2024
@dbkr
Fix formatting of rich text emotes
a46ae2a 
and add them to the new test suite

Fixes element-hq/element-web#27896
@dbkr dbkr mentioned this issue Aug 5, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 5, 2024
@dbkr
Fix formatting of rich text emotes (#12862)
cbd2379 
and add them to the new test suite

Fixes element-hq/element-web#27896
@ara4n ara4n mentioned this issue Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Emotes O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting of rich text emotes matrix-org/matrix-react-sdk
3 participants
@dbkr @ara4n @t3chguy