Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkified links to #alias:domain don't work #27

Closed
ara4n opened this issue Aug 29, 2015 · 0 comments
Closed

Linkified links to #alias:domain don't work #27

ara4n opened this issue Aug 29, 2015 · 0 comments
Assignees
@kegsay
Labels
P1 T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Aug 29, 2015

We should jump to the right room, obviously, joining if necessary.
@ara4n ara4n added the T-Defect label Aug 29, 2015
@kegsay kegsay self-assigned this Oct 21, 2015
@kegsay kegsay mentioned this issue Oct 27, 2015
Merged
@kegsay kegsay closed this as completed Oct 27, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@vchernin vchernin mentioned this issue Apr 18, 2023
Merged
3 tasks
@linuxtim linuxtim mentioned this issue May 11, 2024
Closed
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@richvdh
Log clearer errors when picklekey goes missing (#27)
433c14e 
* tokens.ts: improve documentation

Improve variable naming and documentation on the methods in `tokens.ts`.

* rename restoreFromLocalStorage

Since the session data isn't actually stored in localstorage, this feels like a
misleading name.

* Lifecycle: bail out if picklekey is missing

Currently, if we have an accesstoken which is encrypted with a picklekey, but
the picklekey has gone missing, we carry on with no access token at all. This
is sure to blow up in some way or other later on, but in a rather cryptic way.

Instead, let's bail out early.

(This will produce a "can't restore session" error, but we normally see one of
those anyway because we can't initialise the crypto store.)
JohnSimonsen added a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
@JohnSimonsen
Merge pull request element-hq#27 from verji/rm/1803-add-verji-custom-…
a8af8f5 
…search3

Replaced Elements search with VerjiLocalSearch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kegsay kegsay

Labels
P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @kegsay