Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page is scrolled upwards due to #cpdAvatarClipSvg from Compound Web #26209

Closed
robintown opened this issue Sep 19, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11634
Closed

Page is scrolled upwards due to #cpdAvatarClipSvg from Compound Web #26209

robintown opened this issue Sep 19, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11634
Assignees
@germain-gg
Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker Z-Upstream

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Visit a page that features an avatar stack, such as the landing page of a space, or by enabling the new room header labs flag

Outcome

What did you expect?

The app should continue to occupy the entire available window space

What happened instead?

It gets scrolled upwards by an SVG element that Compound Web adds to the DOM in order to render an AvatarStack

Screenshot from 2023-09-19 12-34-04

Operating system

NixOS unstable

Browser information

Firefox 117.0

URL for webapp

develop.element.io

Application version

Element version: 29bd206-react-5cb8cbd89316-js-1c16b5cae6e8 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Upstream A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 19, 2023
@robintown robintown mentioned this issue Sep 19, 2023
Merged
@t3chguy t3chguy added Z-Labs and removed Z-Labs labels Sep 19, 2023
@t3chguy t3chguy mentioned this issue Sep 19, 2023
Closed
@germain-gg
Copy link
Contributor

Blocked on element-hq/compound-web#81 being merged and a new npm release being made

@robintown
Copy link
Member Author

Fix released: https://github.com/vector-im/compound-web/releases/tag/v0.4.3

@germain-gg germain-gg mentioned this issue Sep 21, 2023
Merged
3 tasks
@germain-gg germain-gg self-assigned this Sep 21, 2023
@andybalaam andybalaam mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker Z-Upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix regression around FacePile with overflow (#11527)" matrix-org/matrix-react-sdk
3 participants
@germain-gg @t3chguy @robintown