Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window buttons / top bar shifted up in new room header labs feature #26184

Closed
Johennes opened this issue Sep 1, 2023 · 10 comments
Closed

Window buttons / top bar shifted up in new room header labs feature #26184

Johennes opened this issue Sep 1, 2023 · 10 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce X-Regression Z-Compound

Comments

@Johennes
Copy link
Contributor

Johennes commented Sep 1, 2023

Steps to reproduce

  1. Enable the new room header feature in labs
  2. Notice how the top part of the UI is shifted up

Screenshot 2023-09-01 at 07 57 27

Outcome

What did you expect?

The top part of the UI not to move up.

What happened instead?

The opposite

Operating system

macOS

Application version

Element Desktop nightly

How did you install the app?

https://packages.element.io/nightly/

Homeserver

element.io / element.ems.host

Will you send logs?

No
@t3chguy t3chguy mentioned this issue Sep 1, 2023
Merged
3 tasks
@germain-gg
Copy link
Contributor

Have not been able to reproduce the issue on Nightly nor develop.
My gut feeling tells me this is not linked to electron. But haven't been able to confirm this

@t3chguy
Copy link
Member

t3chguy commented Sep 1, 2023

@Johennes are you still seeing this?

@t3chguy
Copy link
Member

t3chguy commented Sep 1, 2023

I also cannot reproduce it ftr

@Johennes
Copy link
Contributor Author

Johennes commented Sep 1, 2023

Yes, I still see it on 2023090101 from today. I'm also noticing that there is an odd accompanying white space at the bottom of the window.

Screenshot 2023-09-01 at 20 25 00

It happens 100% deterministically for me as soon as I turn on the labs flag.

@Johennes
Copy link
Contributor Author

Johennes commented Sep 1, 2023

It looks like the whole body is shifted upwards. 🤔

Screenshot 2023-09-01 at 20 35 04

@Johennes
Copy link
Contributor Author

Johennes commented Sep 1, 2023

Aaaand of course now that I flipped the flag on and off a few times for testing, I cannot reproduce it anymore. 🤷

@Johennes
Copy link
Contributor Author

Johennes commented Sep 4, 2023

I can reproduce again this morning.

@Johennes
Copy link
Contributor Author

Down-grading to nice-to-have as I'm unable to reproduce this again today.

@Johennes
Copy link
Contributor Author

I'm seeing the same thing happen on Web now on develop.element.io.

Image

@t3chguy t3chguy transferred this issue from element-hq/element-desktop Sep 18, 2023
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow X-Regression A-Room-View Z-Compound and removed A-Room-View labels Sep 18, 2023
@t3chguy
Copy link
Member

t3chguy commented Sep 19, 2023

Closing in favour of #26209 as it has more info

@t3chguy t3chguy closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce X-Regression Z-Compound
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andybalaam @germain-gg @Johennes @t3chguy