Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last room in favourites section cut off #26049

Closed
bbhtt opened this issue Aug 24, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11472
Closed

Last room in favourites section cut off #26049

bbhtt opened this issue Aug 24, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11472
Assignees
@germain-gg
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker Z-Compound

Comments

@bbhtt
Copy link

bbhtt commented Aug 24, 2023

Steps to reproduce

  1. Use develop.element.io
  2. See the last room in favourite section is cut off

Outcome

What did you expect?

It shouldn't be cut off

What happened instead?

It is cut off

The rooms and people section seems to be fine.

On Develop:

image

On stable (Element version: 1.11.39 Olm version: 3.2.14):

image

Operating system

Fedora 39

Browser information

118.0a1 (2023-08-22)

URL for webapp

https://develop.element.io/

Application version

Element version: fcd8052-react-2d2841930ac8-js-5788d9744b76 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

No
@bbhtt bbhtt added the T-Defect label Aug 24, 2023
@andybalaam andybalaam added X-Regression S-Tolerable Low/no impact on users labels Aug 25, 2023
@andybalaam
Copy link
Member

I can reproduce this on develop. @germain-gg I hate to ask, but could this be related to your changes? I don't remember any work happening in the room list recently.

@germain-gg germain-gg self-assigned this Aug 25, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix last room in list clipped
2b9b813 
Fixes element-hq/element-web#26049
@germain-gg germain-gg mentioned this issue Aug 25, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix consistent avatar output for Percy (#11472)
a2dc95e 
* Fix consistent avatar output for Percy

* Fix last room in list clipped

Fixes element-hq/element-web#26049

* Fix decorated avatar indicator centering

Fixes element-hq/element-web#26052

* Fix uploader centering
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix consistent avatar output for Percy (#11472)
7425625 
* Fix consistent avatar output for Percy

* Fix last room in list clipped

Fixes element-hq/element-web#26049

* Fix decorated avatar indicator centering

Fixes element-hq/element-web#26052

* Fix uploader centering
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 25, 2023
Fix consistent avatar output for Percy (#11472)
64f762d 
* Fix consistent avatar output for Percy

* Fix last room in list clipped

Fixes element-hq/element-web#26049

* Fix decorated avatar indicator centering

Fixes element-hq/element-web#26052

* Fix uploader centering
@kittykat kittykat added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker Z-Compound
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix consistent avatar output for Percy matrix-org/matrix-react-sdk
5 participants
@kittykat @andybalaam @germain-gg @t3chguy @bbhtt