Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on "View Poll History" #25573

Closed
padthaitofuhot opened this issue Jun 13, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3475
Closed

Crash on "View Poll History" #25573

padthaitofuhot opened this issue Jun 13, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3475
Assignees
@kerryarchibald
Labels
A-Polls O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@padthaitofuhot
Copy link

padthaitofuhot commented Jun 13, 2023 •
edited
Loading

Steps to reproduce

  1. What can you see?
    Central room view. Left-hand room list sidebar open. Right-hand sidebar looking at thread with deleted messages.

  2. What did you click?
    Room settings, "View Poll History"

  3. No other steps. However: I recently deleted a poll from the room since users could not vote. Non-admin users of the room I was viewing reported permission denied errors when trying to send messages and vote in polls.

Outcome

What did you expect?

View poll history

What happened instead?

Something went wrong! window popped up.

Operating system

Pop_OS! (Linux)

Application version

Element version 1.11.33

How did you install the app?

Flatpak

Homeserver

localhost/matrixdotorg/synapse:v1.80.0-customized via matrix-docker-ansible-deploy

Will you send logs?

Yes
@t3chguy
Copy link
Member

t3chguy commented Jun 14, 2023 

2023-06-13T02:34:50.286Z E Cannot read properties of undefined (reading 'question')
TypeError: Cannot read properties of undefined (reading 'question')
    at new n (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3182892)
    at t.parseMPoll (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3178414)
    at e.value (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4826512)
    at Function.value (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4826134)
    at get unstableExtensibleEvent [as unstableExtensibleEvent] (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:277237)
    at _ (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3411864)
    at aa (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4911669)
    at Ys (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4963794)
    at Ol (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4951072)
    at Dl (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4951000)
2023-06-13T02:34:50.291Z E Cannot read properties of undefined (reading 'question')
TypeError: Cannot read properties of undefined (reading 'question')
    at new n (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3182892)
    at t.parseMPoll (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3178414)
    at e.value (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4826512)
    at Function.value (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4826134)
    at get unstableExtensibleEvent [as unstableExtensibleEvent] (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:277237)
    at _ (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3411864)
    at aa (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4911669)
    at Ys (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4963794)
    at Ol (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4951072)
    at Dl (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:4951000)
2023-06-13T02:34:50.291Z E The above error occurred while React was rendering the following components: 
    at _ (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3411839)
    at ol
    at div
    at O (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3415433)
    at div
    at K (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3419674)
    at div
    at Se (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:2590163)
    at div
    at m (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:1095915)
    at div
    at div
    at g (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:975146)
    at div
    at div
    at vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3203129
    at _ (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:332442)
    at Ce (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:2590720)
    at g (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3067385)
    at h (vector://vector/webapp/bundles/10d03808de0f3789e63e/bundle.js:2:3506328)
    at div
    at div

@kerryarchibald kerryarchibald self-assigned this Jun 14, 2023
@kerryarchibald kerryarchibald mentioned this issue Jun 15, 2023
Merged
3 tasks
@kittykat kittykat added S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Polls labels Jun 15, 2023
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v26.2.0' into sc
5d086fe 
* The Browserify artifact is being deprecated, scheduled for removal in the October 10th release cycle. ([\matrix-org#3189](matrix-org#3189)).
* ElementR: Add `CryptoApi#bootstrapSecretStorage` ([\matrix-org#3483](matrix-org#3483)). Contributed by @florianduros.
* Deprecate `MatrixClient.findVerificationRequestDMInProgress`, `MatrixClient.getVerificationRequestsToDeviceInProgress`, and `MatrixClient.requestVerification`, in favour of methods in `CryptoApi`. ([\matrix-org#3474](matrix-org#3474)).
* Introduce a new `Crypto.VerificationRequest` interface, and deprecate direct access to the old `VerificationRequest` class. Also deprecate some related classes that were exported from `src/crypto/verification/request/VerificationRequest` ([\matrix-org#3449](matrix-org#3449)).
* OIDC: navigate to authorization endpoint ([\matrix-org#3499](matrix-org#3499)). Contributed by @kerryarchibald.
* Support for interactive device verification in Element-R. ([\matrix-org#3505](matrix-org#3505)).
* Support for interactive device verification in Element-R. ([\matrix-org#3508](matrix-org#3508)).
* Support for interactive device verification in Element-R. ([\matrix-org#3490](matrix-org#3490)). Fixes element-hq/element-web#25316.
* Element-R: Store cross signing keys in secret storage ([\matrix-org#3498](matrix-org#3498)). Contributed by @florianduros.
* OIDC: add dynamic client registration util function ([\matrix-org#3481](matrix-org#3481)). Contributed by @kerryarchibald.
* Add getLastUnthreadedReceiptFor utility to Thread delegating to the underlying Room ([\matrix-org#3493](matrix-org#3493)).
* ElementR: Add `rust-crypto#createRecoveryKeyFromPassphrase` implementation ([\matrix-org#3472](matrix-org#3472)). Contributed by @florianduros.
* Aggregate relations regardless of whether event fits into the timeline ([\matrix-org#3496](matrix-org#3496)). Fixes element-hq/element-web#25596.
* Fix bug where switching media caused media in subsequent calls to fail ([\matrix-org#3489](matrix-org#3489)).
* Fix: remove polls from room state on redaction ([\matrix-org#3475](matrix-org#3475)). Fixes element-hq/element-web#25573. Contributed by @kerryarchibald.
* Fix export type `GeneratedSecretStorageKey` ([\matrix-org#3479](matrix-org#3479)). Contributed by @florianduros.
* Close IDB database before deleting it to prevent spurious unexpected close errors ([\matrix-org#3478](matrix-org#3478)). Fixes element-hq/element-web#25597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerryarchibald kerryarchibald

Labels
A-Polls O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: remove polls from room state on redaction matrix-org/matrix-js-sdk
4 participants
@kittykat @t3chguy @kerryarchibald @padthaitofuhot