Element-R: Replace CryptoBackend.checkDeviceTrust
#25092
Assignees
Labels
A-Element-R
Issues affecting the port of Element's crypto layer to Rust
T-Task
Tasks for the team like planning
Comments
richvdh
added
T-Task
This was referenced Apr 12, 2023
richvdh
added a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Apr 13, 2023
richvdh
added a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Apr 13, 2023
richvdh
added a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Apr 13, 2023
richvdh
changed the title
CryptoBackend.checkDeviceTrustCryptoBackend.checkDeviceTrust
|
turns out we have to replace it, rather than implement it, because we need it to be async. |
github-merge-queue bot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Apr 18, 2023
github-merge-queue bot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Apr 18, 2023
* Element-R: implement `{get,set}TrustCrossSignedDevices`
A precursor to element-hq/element-web#25092
* Pull out new `DeviceVerificationStatus`
Define a new base class to replace `DeviceTrustLevel`. The intention is to have
a cleaner interface which is easier to expose from the new crypto impl
* Define, and implement, a new `CryptoApi.getDeviceVerificationStatus`
This is similar to `checkDeviceTrust`, which we're deprecating, but:
* is `async`, meaning we can implement it in Rust
* Returns a `DeviceVerificationStatus` instead of a `DeviceTrustLevel`
* Returns `null` rather than "not verified" if the device is unknown
* add some tests
* Export DeviceVerificationStatus as a proper class
... so that we can instantiate it in tests
|
This was done by matrix-org/matrix-js-sdk#3287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(currently stubbed).
I think it's a matter of calling
OlmMachine.getDeviceand then mapping the result back into aDeviceTrustLevel. Expose it viaCryptoApi. Use it in places in the react-sdk where we currently callCrossSigningInfo.checkDeviceTrustdirectly.The text was updated successfully, but these errors were encountered: