-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When viewing a room unauthenticated as a guest, it doesn't have any feature toggles enabled (like threads) #24513
When viewing a room unauthenticated as a guest, it doesn't have any feature toggles enabled (like threads) #24513
Comments
This is intentional according to the comment above the implementation at least https://github.com/matrix-org/matrix-react-sdk/blob/030b7e90bf8ba09648f539dd378c0909f8773f86/src/settings/handlers/DeviceSettingsHandler.ts#L120-L123 |
"Feature toggles" should only apply to Labs flags. Are there non-Labs features that you feel should be defaulted to on and are not today? |
I think we're talking here about features that are turned on in the client config. So, for example, in app.gitter.com's config file I can see I would definitely expect a guest user to see that feature turned on if they connected to that client. Is this what you mean @MadLittleMods ? |
👍 Yes. You can default some labs feature toggles to enabled for an Element instance so everyone experiences them by default. Everyone should include guests. |
I am discussing this with @daniellekirkwood |
What's stopping us from moving those things out of Labs? |
@daniellekirkwood To me, this is mostly separate concern as there are always going to be features that haven't made it stable yet. This also prevents us from ever testing these features as a guest before they roll out to stable. For example, we had this situation with threads when it was enabled by default (technically considered out of labs but still behind the same feature toggle) for all users while we tested the waters and left room for us to turn back if anything catastrophic came up. The thing holding us back was confidence, bandwidth, and time. If we're talking Gitter specifics: For dynamic room predecessors, this is still a new feature where the implementation is still settling in, probably needs a few more tweaks to be fully ready, and MSC3946 still needs to be discussed, merged, and put into a spec version. Gitter is ok with this risk (risk profile/tolerance) since the feature is necessary to even make content accessible. For LaTeX math, this probably mostly a case of no direct responsible individual moving it forward (it's been a feature toggle for years). MSC2191 is still open but supporting the syntax is pretty harmless because it's just readable text for any other client which is fine to fallback with. |
I'm not 100% sold on this however, it feels like a simple thing to do and I believe it will benefit the users that you're concerned about here... We didn't reach conclusion internally which means no-one has strong thoughts on the PM team. Path forwards: Let's do it. Element Web should respect the Server's (HTML) flags settings if it's choosing to override things. We should loop back round and discuss the Guest use case in more detail in the future but as that's not on the roadmap for 2023, let's go ahead and unblock y'all here :) |
Thanks for looking into the details, weighing everything, and biasing to action @daniellekirkwood! Thanks for the fixing this up @andybalaam! -> matrix-org/matrix-react-sdk#10651 |
* If you package Element Desktop with a static sqlcipher, you may need to tweak some build scripts: SQLCIPHER_STATIC became SQLCIPHER_BUNDLED, and OpenSSL is now included too. * Start packaging for Debian & Ubuntu aarch64 ([\element-hq#895](element-hq#895)). * Use a fully static seshat build ([\element-hq#631](element-hq#631)). Contributed by @MatMaul. * Improve Content-Security-Policy ([\#25210](element-hq/element-web#25210)). * Add UIFeature.locationSharing to hide location sharing ([\#10727](matrix-org/matrix-react-sdk#10727)). * Memoize field validation results ([\#10714](matrix-org/matrix-react-sdk#10714)). * Commands for plain text editor ([\#10567](matrix-org/matrix-react-sdk#10567)). Contributed by @alunturner. * Allow 16 lines of text in the rich text editors ([\#10670](matrix-org/matrix-react-sdk#10670)). Contributed by @alunturner. * Bail out of `RoomSettingsDialog` when room is not found ([\#10662](matrix-org/matrix-react-sdk#10662)). Contributed by @kerryarchibald. * Element-R: Populate device list for right-panel ([\#10671](matrix-org/matrix-react-sdk#10671)). Contributed by @florianduros. * Make existing and new issue URLs configurable ([\#10710](matrix-org/matrix-react-sdk#10710)). Fixes element-hq/element-web#24424. * Fix usages of ARIA tabpanel ([\#10628](matrix-org/matrix-react-sdk#10628)). Fixes element-hq/element-web#25016. * Element-R: Starting a DMs with a user ([\#10673](matrix-org/matrix-react-sdk#10673)). Contributed by @florianduros. * ARIA Accessibility improvements ([\#10675](matrix-org/matrix-react-sdk#10675)). * ARIA Accessibility improvements ([\#10674](matrix-org/matrix-react-sdk#10674)). * Add arrow key controls to emoji and reaction pickers ([\#10637](matrix-org/matrix-react-sdk#10637)). Fixes element-hq/element-web#17189. * Translate credits in help about section ([\#10676](matrix-org/matrix-react-sdk#10676)). * Fix macos update check exploding ([\element-hq#944](element-hq#944)). Fixes element-hq#668. * Fix: reveal images when image previews are disabled ([\#10781](matrix-org/matrix-react-sdk#10781)). Fixes element-hq/element-web#25271. Contributed by @kerryarchibald. * Workaround Squirrel.Mac wedging app restart after failed update check ([\element-hq#629](element-hq#629)). * Fix autocomplete not resetting properly on message send ([\#10741](matrix-org/matrix-react-sdk#10741)). Fixes element-hq/element-web#25170. * Fix start_sso not working with guests disabled ([\#10720](matrix-org/matrix-react-sdk#10720)). Fixes element-hq/element-web#16624. * Fix soft crash with Element call widgets ([\#10684](matrix-org/matrix-react-sdk#10684)). * Send correct receipt when marking a room as read ([\#10730](matrix-org/matrix-react-sdk#10730)). Fixes element-hq/element-web#25207. * Offload some more waveform processing onto a worker ([\#9223](matrix-org/matrix-react-sdk#9223)). Fixes element-hq/element-web#19756. * Consolidate login errors ([\#10722](matrix-org/matrix-react-sdk#10722)). Fixes element-hq/element-web#17520. * Fix all rooms search generating permalinks to wrong room id ([\#10625](matrix-org/matrix-react-sdk#10625)). Fixes element-hq/element-web#25115. * Posthog properly handle Analytics ID changing from under us ([\#10702](matrix-org/matrix-react-sdk#10702)). Fixes element-hq/element-web#25187. * Fix Clock being read as an absolute time rather than duration ([\#10706](matrix-org/matrix-react-sdk#10706)). Fixes element-hq/element-web#22582. * Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\#10615](matrix-org/matrix-react-sdk#10615)). Fixes element-hq/element-web#9597. Contributed by @MadLittleMods. * Honour feature toggles in guest mode ([\#10651](matrix-org/matrix-react-sdk#10651)). Fixes element-hq/element-web#24513. Contributed by @andybalaam. * Fix default content in devtools event sender ([\#10699](matrix-org/matrix-react-sdk#10699)). Contributed by @tulir. * Fix a crash when a call ends while you're in it ([\#10681](matrix-org/matrix-react-sdk#10681)). Fixes element-hq/element-web#25153. * Fix lack of screen reader indication when triggering auto complete ([\#10664](matrix-org/matrix-react-sdk#10664)). Fixes element-hq/element-web#11011. * Fix typing tile duplicating users ([\#10678](matrix-org/matrix-react-sdk#10678)). Fixes element-hq/element-web#25165. * Fix wrong room topic tooltip position ([\#10667](matrix-org/matrix-react-sdk#10667)). Fixes element-hq/element-web#25158. * Fix create subspace dialog not working ([\#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq/element-web#24882.
* Improve Content-Security-Policy ([\element-hq#25210](element-hq#25210)). * Add UIFeature.locationSharing to hide location sharing ([\element-hq#10727](matrix-org/matrix-react-sdk#10727)). * Memoize field validation results ([\#10714](matrix-org/matrix-react-sdk#10714)). * Commands for plain text editor ([\element-hq#10567](matrix-org/matrix-react-sdk#10567)). Contributed by @alunturner. * Allow 16 lines of text in the rich text editors ([\element-hq#10670](matrix-org/matrix-react-sdk#10670)). Contributed by @alunturner. * Bail out of `RoomSettingsDialog` when room is not found ([\#10662](matrix-org/matrix-react-sdk#10662)). Contributed by @kerryarchibald. * Element-R: Populate device list for right-panel ([\element-hq#10671](matrix-org/matrix-react-sdk#10671)). Contributed by @florianduros. * Make existing and new issue URLs configurable ([\element-hq#10710](matrix-org/matrix-react-sdk#10710)). Fixes element-hq#24424. * Fix usages of ARIA tabpanel ([\element-hq#10628](matrix-org/matrix-react-sdk#10628)). Fixes element-hq#25016. * Element-R: Starting a DMs with a user ([\element-hq#10673](matrix-org/matrix-react-sdk#10673)). Contributed by @florianduros. * ARIA Accessibility improvements ([\element-hq#10675](matrix-org/matrix-react-sdk#10675)). * ARIA Accessibility improvements ([\element-hq#10674](matrix-org/matrix-react-sdk#10674)). * Add arrow key controls to emoji and reaction pickers ([\element-hq#10637](matrix-org/matrix-react-sdk#10637)). Fixes element-hq#17189. * Translate credits in help about section ([\element-hq#10676](matrix-org/matrix-react-sdk#10676)). * Fix: reveal images when image previews are disabled ([\element-hq#10781](matrix-org/matrix-react-sdk#10781)). Fixes element-hq#25271. Contributed by @kerryarchibald. * Fix autocomplete not resetting properly on message send ([\element-hq#10741](matrix-org/matrix-react-sdk#10741)). Fixes element-hq#25170. * Fix start_sso not working with guests disabled ([\element-hq#10720](matrix-org/matrix-react-sdk#10720)). Fixes element-hq#16624. * Fix soft crash with Element call widgets ([\element-hq#10684](matrix-org/matrix-react-sdk#10684)). * Send correct receipt when marking a room as read ([\element-hq#10730](matrix-org/matrix-react-sdk#10730)). Fixes element-hq#25207. * Offload some more waveform processing onto a worker ([\element-hq#9223](matrix-org/matrix-react-sdk#9223)). Fixes element-hq#19756. * Consolidate login errors ([\element-hq#10722](matrix-org/matrix-react-sdk#10722)). Fixes element-hq#17520. * Fix all rooms search generating permalinks to wrong room id ([\element-hq#10625](matrix-org/matrix-react-sdk#10625)). Fixes element-hq#25115. * Posthog properly handle Analytics ID changing from under us ([\element-hq#10702](matrix-org/matrix-react-sdk#10702)). Fixes element-hq#25187. * Fix Clock being read as an absolute time rather than duration ([\element-hq#10706](matrix-org/matrix-react-sdk#10706)). Fixes element-hq#22582. * Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\element-hq#10615](matrix-org/matrix-react-sdk#10615)). Fixes element-hq#9597. Contributed by @MadLittleMods. * Honour feature toggles in guest mode ([\element-hq#10651](matrix-org/matrix-react-sdk#10651)). Fixes element-hq#24513. Contributed by @andybalaam. * Fix default content in devtools event sender ([\element-hq#10699](matrix-org/matrix-react-sdk#10699)). Contributed by @tulir. * Fix a crash when a call ends while you're in it ([\element-hq#10681](matrix-org/matrix-react-sdk#10681)). Fixes element-hq#25153. * Fix lack of screen reader indication when triggering auto complete ([\element-hq#10664](matrix-org/matrix-react-sdk#10664)). Fixes element-hq#11011. * Fix typing tile duplicating users ([\element-hq#10678](matrix-org/matrix-react-sdk#10678)). Fixes element-hq#25165. * Fix wrong room topic tooltip position ([\element-hq#10667](matrix-org/matrix-react-sdk#10667)). Fixes element-hq#25158. * Fix create subspace dialog not working ([\element-hq#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq#24882.
* Add UIFeature.locationSharing to hide location sharing ([\matrix-org#10727](matrix-org#10727)). * Memoize field validation results ([\matrix-org#10714](matrix-org#10714)). * Commands for plain text editor ([\matrix-org#10567](matrix-org#10567)). Contributed by @alunturner. * Allow 16 lines of text in the rich text editors ([\matrix-org#10670](matrix-org#10670)). Contributed by @alunturner. * Bail out of `RoomSettingsDialog` when room is not found ([\matrix-org#10662](matrix-org#10662)). Contributed by @kerryarchibald. * Element-R: Populate device list for right-panel ([\matrix-org#10671](matrix-org#10671)). Contributed by @florianduros. * Make existing and new issue URLs configurable ([\matrix-org#10710](matrix-org#10710)). Fixes element-hq/element-web#24424. * Fix usages of ARIA tabpanel ([\matrix-org#10628](matrix-org#10628)). Fixes element-hq/element-web#25016. * Element-R: Starting a DMs with a user ([\matrix-org#10673](matrix-org#10673)). Contributed by @florianduros. * ARIA Accessibility improvements ([\matrix-org#10675](matrix-org#10675)). * ARIA Accessibility improvements ([\matrix-org#10674](matrix-org#10674)). * Add arrow key controls to emoji and reaction pickers ([\matrix-org#10637](matrix-org#10637)). Fixes element-hq/element-web#17189. * Translate credits in help about section ([\matrix-org#10676](matrix-org#10676)). * Fix: reveal images when image previews are disabled ([\matrix-org#10781](matrix-org#10781)). Fixes element-hq/element-web#25271. Contributed by @kerryarchibald. * Fix autocomplete not resetting properly on message send ([\matrix-org#10741](matrix-org#10741)). Fixes element-hq/element-web#25170. * Fix start_sso not working with guests disabled ([\matrix-org#10720](matrix-org#10720)). Fixes element-hq/element-web#16624. * Fix soft crash with Element call widgets ([\matrix-org#10684](matrix-org#10684)). * Send correct receipt when marking a room as read ([\matrix-org#10730](matrix-org#10730)). Fixes element-hq/element-web#25207. * Offload some more waveform processing onto a worker ([\matrix-org#9223](matrix-org#9223)). Fixes element-hq/element-web#19756. * Consolidate login errors ([\matrix-org#10722](matrix-org#10722)). Fixes element-hq/element-web#17520. * Fix all rooms search generating permalinks to wrong room id ([\matrix-org#10625](matrix-org#10625)). Fixes element-hq/element-web#25115. * Posthog properly handle Analytics ID changing from under us ([\matrix-org#10702](matrix-org#10702)). Fixes element-hq/element-web#25187. * Fix Clock being read as an absolute time rather than duration ([\matrix-org#10706](matrix-org#10706)). Fixes element-hq/element-web#22582. * Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\matrix-org#10615](matrix-org#10615)). Fixes element-hq/element-web#9597. Contributed by @MadLittleMods. * Honour feature toggles in guest mode ([\matrix-org#10651](matrix-org#10651)). Fixes element-hq/element-web#24513. Contributed by @andybalaam. * Fix default content in devtools event sender ([\matrix-org#10699](matrix-org#10699)). Contributed by @tulir. * Fix a crash when a call ends while you're in it ([\matrix-org#10681](matrix-org#10681)). Fixes element-hq/element-web#25153. * Fix lack of screen reader indication when triggering auto complete ([\matrix-org#10664](matrix-org#10664)). Fixes element-hq/element-web#11011. * Fix typing tile duplicating users ([\matrix-org#10678](matrix-org#10678)). Fixes element-hq/element-web#25165. * Fix wrong room topic tooltip position ([\matrix-org#10667](matrix-org#10667)). Fixes element-hq/element-web#25158. * Fix create subspace dialog not working ([\matrix-org#10652](matrix-org#10652)). Fixes element-hq/element-web#24882.
Steps to reproduce
app.gitter.im
, this also means dynamic room predecessors which aren't visible.Product-wise, this was discussed internally (no conclusion yet).
Outcome
What did you expect?
Default feature toggles apply to guest accounts so you can preview a room unauthenticated as expected.
What happened instead?
Missing a bunch of features that should be turned on
Operating system
Windows 10
Browser information
Chrome Version 110.0.5481.78
URL for webapp
https://develop.element.io/
Application version
Element version: 2b779e5-react-fa036a508037-js-abc9c9dcb02f Olm version: 3.2.12
Homeserver
matrix.org
Will you send logs?
No
The text was updated successfully, but these errors were encountered: