Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite to private space should show number of members #19123

Closed
kittykat opened this issue Sep 22, 2021 · 9 comments · Fixed by matrix-org/matrix-react-sdk#6982
Closed

Invite to private space should show number of members #19123

kittykat opened this issue Sep 22, 2021 · 9 comments · Fixed by matrix-org/matrix-react-sdk#6982
Assignees
@t3chguy
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Spec-Changes

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 22, 2021 •
edited
Loading

Steps to reproduce

  1. Be invited to a space and open invite dialog

What happened?

What did you expect?

Info about number of members:
ima_c1c0122
Screenshot_20210922-120819

What happened?

No info about number of members
Screenshot from 2021-09-22 12-09-23

Nique signed off that design should match mobile

Operating system

No response

Browser information

Chromium Version 92.0.4515.131 (Official Build)

URL for webapp

develop.element.io

Homeserver

n/a

Have you submitted a rageshake?

No
@kittykat kittykat added T-Defect A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Spaces-Testing labels Sep 22, 2021
@t3chguy
Copy link
Member

t3chguy commented Sep 27, 2021

Synapse only includes the membership events for yourself and the inviter, so the count will not work as expected AIUI

@t3chguy
Copy link
Member

t3chguy commented Sep 28, 2021

image

image

As above, the stripped state provided by Synapse only includes the membership event for the inviter and invitee so we cannot show a member count.

@novocaine
Copy link
Contributor

Nique signed off that design should match mobile

Which screen on mobile are you saying this should match @kittykat ?

@kittykat
Copy link
Contributor Author

kittykat commented Oct 1, 2021

@novocaine Both Android and iOS show number of space members (not space+invited members)

But if the count doesn't work as Michael says, then it shouldn't be shown on Android and iOS.

@novocaine
Copy link
Contributor

I think @t3chguy is suggesting the count would always be 2 .. I'm guessing that isn't the case on Android/iOS as it'd be obviously broken, I'm just wondering if the places you've seen it are directly comparable, so if you could provide screenshots it might help

@kittykat
Copy link
Contributor Author

kittykat commented Oct 1, 2021

Android shows the total number of members for the space. There are three members in the attached example, one of them an admin and two members who accepted invites:

Screenshot_20211001-163548

@BillCarsonFr
Copy link
Member

Android is calling the new room summary API to try to get a more up to date summary. That's why the members count is 3 here (from the invite state event it's always 2, but the room summary API has the right count)

@t3chguy
Copy link
Member

t3chguy commented Oct 5, 2021

@BillCarsonFr the MSC3266 one?

@BillCarsonFr
Copy link
Member

MSC3266

Yes, for reference element-hq/element-android#4057

@t3chguy t3chguy self-assigned this Oct 19, 2021
@t3chguy t3chguy mentioned this issue Oct 19, 2021
Merged
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Nov 8, 2021
@BBaoVanC
Merge tag 'v1.9.4' into build
343a81c 
* Improve the look of tooltips ([\element-hq#7049](matrix-org/matrix-react-sdk#7049)). Contributed by @SimonBrandner.
* Improve the look of the spinner ([\element-hq#6083](matrix-org/matrix-react-sdk#6083)). Contributed by @SimonBrandner.
* Polls: Creation form & start event ([\element-hq#7001](matrix-org/matrix-react-sdk#7001)).
* Show a gray shield when encrypted by deleted session ([\element-hq#6119](matrix-org/matrix-react-sdk#6119)). Contributed by @SimonBrandner.
* <notes> ([\element-hq#7057](matrix-org/matrix-react-sdk#7057)). Contributed by @ndarilek.
* Make message separator more accessible. ([\element-hq#7056](matrix-org/matrix-react-sdk#7056)). Contributed by @ndarilek.
* <notes> ([\element-hq#7035](matrix-org/matrix-react-sdk#7035)). Contributed by @ndarilek.
* Implement RequiresClient capability for widgets ([\element-hq#7005](matrix-org/matrix-react-sdk#7005)). Fixes element-hq#15744 and element-hq#15744.
* Respect the system high contrast setting when using system theme ([\element-hq#7043](matrix-org/matrix-react-sdk#7043)).
* Remove redundant duplicate mimetype field which doesn't conform to spec ([\element-hq#7045](matrix-org/matrix-react-sdk#7045)). Fixes element-hq#17145 and element-hq#17145.
* Make join button on space hierarchy action in the background ([\element-hq#7041](matrix-org/matrix-react-sdk#7041)). Fixes element-hq#17388 and element-hq#17388.
* Add a high contrast theme (a variant of the light theme) ([\element-hq#7036](matrix-org/matrix-react-sdk#7036)).
* Improve timeline message for restricted join rule changes ([\element-hq#6984](matrix-org/matrix-react-sdk#6984)). Fixes element-hq#18980 and element-hq#18980.
* Improve the appearance of the font size slider ([\element-hq#7038](matrix-org/matrix-react-sdk#7038)).
* Improve RovingTabIndex & Room List filtering performance ([\element-hq#6987](matrix-org/matrix-react-sdk#6987)). Fixes element-hq#17864 and element-hq#17864.
* Remove outdated Spaces restricted rooms warning ([\element-hq#6927](matrix-org/matrix-react-sdk#6927)).
* Make /msg <message> param optional for more flexibility ([\element-hq#7028](matrix-org/matrix-react-sdk#7028)). Fixes element-hq#19481 and element-hq#19481.
* Add decoration to space hierarchy for tiles which have already been j… ([\element-hq#6969](matrix-org/matrix-react-sdk#6969)). Fixes element-hq#18755 and element-hq#18755.
* Add insert link button to the format bar ([\element-hq#5879](matrix-org/matrix-react-sdk#5879)). Contributed by @SimonBrandner.
* Improve visibility of font size chooser ([\element-hq#6988](matrix-org/matrix-react-sdk#6988)).
* Soften border-radius on selected/hovered messages ([\element-hq#6525](matrix-org/matrix-react-sdk#6525)). Fixes element-hq#18108. Contributed by @SimonBrandner.
* Add a developer mode flag and use it for accessing space timelines ([\element-hq#6994](matrix-org/matrix-react-sdk#6994)). Fixes element-hq#19416 and element-hq#19416.
* Position toggle switch more clearly ([\element-hq#6914](matrix-org/matrix-react-sdk#6914)). Contributed by @CicadaCinema.
* Validate email address in forgot password dialog ([\element-hq#6983](matrix-org/matrix-react-sdk#6983)). Fixes element-hq#9978 and element-hq#9978. Contributed by @psrpinto.
* Handle and i18n M_THREEPID_IN_USE during registration ([\element-hq#6986](matrix-org/matrix-react-sdk#6986)). Fixes element-hq#13767 and element-hq#13767.
* For space invite previews, use room summary API to get the right member count ([\element-hq#6982](matrix-org/matrix-react-sdk#6982)). Fixes element-hq#19123 and element-hq#19123.
* Simplify Space Panel notification badge layout ([\element-hq#6977](matrix-org/matrix-react-sdk#6977)). Fixes element-hq#18527 and element-hq#18527.
* Use prettier hsName during 3pid registration where possible ([\element-hq#6980](matrix-org/matrix-react-sdk#6980)). Fixes element-hq#19162 and element-hq#19162.
* Add a condition to only activate the resizer which belongs to the clicked handle ([\element-hq#7055](matrix-org/matrix-react-sdk#7055)). Fixes element-hq#19521 and element-hq#19521.
* Restore composer focus after event edit ([\element-hq#7065](matrix-org/matrix-react-sdk#7065)). Fixes element-hq#19469 and element-hq#19469.
* Don't apply message bubble visual style to media messages ([\element-hq#7040](matrix-org/matrix-react-sdk#7040)).
* Handle no selected screen when screen-sharing ([\#7018](matrix-org/matrix-react-sdk#7018)). Fixes element-hq#19460 and element-hq#19460. Contributed by @SimonBrandner.
* Add history entry before completing emoji ([\element-hq#7007](matrix-org/matrix-react-sdk#7007)). Fixes element-hq#19177 and element-hq#19177. Contributed by @RafaelGoncalves8.
* Add padding between controls on edit form in message bubbles ([\element-hq#7039](matrix-org/matrix-react-sdk#7039)).
* Respect the roomState right container request for the Jitsi widget ([\element-hq#7033](matrix-org/matrix-react-sdk#7033)). Fixes element-hq#16552 and element-hq#16552.
* Fix cannot read length of undefined for room upgrades ([\element-hq#7037](matrix-org/matrix-react-sdk#7037)). Fixes element-hq#19509 and element-hq#19509.
* Cleanup re-dispatching around timelines and composers ([\element-hq#7023](matrix-org/matrix-react-sdk#7023)). Fixes element-hq#19491 and element-hq#19491. Contributed by @SimonBrandner.
* Fix removing a room from a Space and interaction with `m.space.parent` ([\element-hq#6944](matrix-org/matrix-react-sdk#6944)). Fixes element-hq#19363 and element-hq#19363.
* Fix recent css regression ([\element-hq#7022](matrix-org/matrix-react-sdk#7022)). Fixes element-hq#19470 and element-hq#19470. Contributed by @CicadaCinema.
* Fix ModalManager reRender racing with itself ([\element-hq#7027](matrix-org/matrix-react-sdk#7027)). Fixes element-hq#19489 and element-hq#19489.
* Fix fullscreening a call while connecting ([\element-hq#7019](matrix-org/matrix-react-sdk#7019)). Fixes element-hq#19309 and element-hq#19309. Contributed by @SimonBrandner.
* Allow scrolling right in reply-quoted code block ([\element-hq#7024](matrix-org/matrix-react-sdk#7024)). Fixes element-hq#19487 and element-hq#19487. Contributed by @SimonBrandner.
* Fix dark theme codeblock colors ([\element-hq#6384](matrix-org/matrix-react-sdk#6384)). Fixes element-hq#17998. Contributed by @SimonBrandner.
* Show passphrase input label ([\element-hq#6992](matrix-org/matrix-react-sdk#6992)). Fixes element-hq#19428 and element-hq#19428. Contributed by @RafaelGoncalves8.
* Always render disabled settings as disabled ([\element-hq#7014](matrix-org/matrix-react-sdk#7014)).
* Make "Security Phrase" placeholder look consistent cross-browser ([\element-hq#6870](matrix-org/matrix-react-sdk#6870)). Fixes element-hq#19006 and element-hq#19006. Contributed by @neer17.
* Fix direction override characters breaking member event text direction ([\element-hq#6999](matrix-org/matrix-react-sdk#6999)).
* Remove redundant text in verification dialogs ([\element-hq#6993](matrix-org/matrix-react-sdk#6993)). Fixes element-hq#19290 and element-hq#19290. Contributed by @RafaelGoncalves8.
* Fix space panel name overflowing ([\element-hq#6995](matrix-org/matrix-react-sdk#6995)). Fixes element-hq#19455 and element-hq#19455.
* Fix conflicting CSS on syntax highlighted blocks ([\element-hq#6991](matrix-org/matrix-react-sdk#6991)). Fixes element-hq#19445 and element-hq#19445.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Nov 8, 2021
@su-ex
Merge tag 'v3.34.0' into sc
c6f67a0 
* Improve the look of tooltips ([\matrix-org#7049](matrix-org#7049)). Contributed by @SimonBrandner.
* Improve the look of the spinner ([\matrix-org#6083](matrix-org#6083)). Contributed by @SimonBrandner.
* Polls: Creation form & start event ([\matrix-org#7001](matrix-org#7001)).
* Show a gray shield when encrypted by deleted session ([\matrix-org#6119](matrix-org#6119)). Contributed by @SimonBrandner.
* Silence some widgets for better screen reader presentation. ([\matrix-org#7057](matrix-org#7057)). Contributed by @ndarilek.
* Make message separator more accessible. ([\matrix-org#7056](matrix-org#7056)). Contributed by @ndarilek.
* Give each room directory entry the `listitem` role to correspond with the containing `list`. ([\matrix-org#7035](matrix-org#7035)). Contributed by @ndarilek.
* Implement RequiresClient capability for widgets ([\matrix-org#7005](matrix-org#7005)). Fixes element-hq/element-web#15744 and element-hq/element-web#15744.
* Respect the system high contrast setting when using system theme ([\matrix-org#7043](matrix-org#7043)).
* Remove redundant duplicate mimetype field which doesn't conform to spec ([\matrix-org#7045](matrix-org#7045)). Fixes element-hq/element-web#17145 and element-hq/element-web#17145.
* Make join button on space hierarchy action in the background ([\matrix-org#7041](matrix-org#7041)). Fixes element-hq/element-web#17388 and element-hq/element-web#17388.
* Add a high contrast theme (a variant of the light theme) ([\matrix-org#7036](matrix-org#7036)).
* Improve timeline message for restricted join rule changes ([\matrix-org#6984](matrix-org#6984)). Fixes element-hq/element-web#18980 and element-hq/element-web#18980.
* Improve the appearance of the font size slider ([\matrix-org#7038](matrix-org#7038)).
* Improve RovingTabIndex & Room List filtering performance ([\matrix-org#6987](matrix-org#6987)). Fixes element-hq/element-web#17864 and element-hq/element-web#17864.
* Remove outdated Spaces restricted rooms warning ([\matrix-org#6927](matrix-org#6927)).
* Make /msg <message> param optional for more flexibility ([\matrix-org#7028](matrix-org#7028)). Fixes element-hq/element-web#19481 and element-hq/element-web#19481.
* Add decoration to space hierarchy for tiles which have already been j… ([\matrix-org#6969](matrix-org#6969)). Fixes element-hq/element-web#18755 and element-hq/element-web#18755.
* Add insert link button to the format bar ([\matrix-org#5879](matrix-org#5879)). Contributed by @SimonBrandner.
* Improve visibility of font size chooser ([\matrix-org#6988](matrix-org#6988)).
* Soften border-radius on selected/hovered messages ([\matrix-org#6525](matrix-org#6525)). Fixes element-hq/element-web#18108. Contributed by @SimonBrandner.
* Add a developer mode flag and use it for accessing space timelines ([\matrix-org#6994](matrix-org#6994)). Fixes element-hq/element-web#19416 and element-hq/element-web#19416.
* Position toggle switch more clearly ([\matrix-org#6914](matrix-org#6914)). Contributed by @CicadaCinema.
* Validate email address in forgot password dialog ([\matrix-org#6983](matrix-org#6983)). Fixes element-hq/element-web#9978 and element-hq/element-web#9978. Contributed by @psrpinto.
* Handle and i18n M_THREEPID_IN_USE during registration ([\matrix-org#6986](matrix-org#6986)). Fixes element-hq/element-web#13767 and element-hq/element-web#13767.
* For space invite previews, use room summary API to get the right member count ([\matrix-org#6982](matrix-org#6982)). Fixes element-hq/element-web#19123 and element-hq/element-web#19123.
* Simplify Space Panel notification badge layout ([\matrix-org#6977](matrix-org#6977)). Fixes element-hq/element-web#18527 and element-hq/element-web#18527.
* Use prettier hsName during 3pid registration where possible ([\matrix-org#6980](matrix-org#6980)). Fixes element-hq/element-web#19162 and element-hq/element-web#19162.
* Add a condition to only activate the resizer which belongs to the clicked handle ([\matrix-org#7055](matrix-org#7055)). Fixes element-hq/element-web#19521 and element-hq/element-web#19521.
* Restore composer focus after event edit ([\matrix-org#7065](matrix-org#7065)). Fixes element-hq/element-web#19469 and element-hq/element-web#19469.
* Don't apply message bubble visual style to media messages ([\matrix-org#7040](matrix-org#7040)).
* Handle no selected screen when screen-sharing ([\matrix-org#7018](matrix-org#7018)). Fixes element-hq/element-web#19460 and element-hq/element-web#19460. Contributed by @SimonBrandner.
* Add history entry before completing emoji ([\matrix-org#7007](matrix-org#7007)). Fixes element-hq/element-web#19177 and element-hq/element-web#19177. Contributed by @RafaelGoncalves8.
* Add padding between controls on edit form in message bubbles ([\matrix-org#7039](matrix-org#7039)).
* Respect the roomState right container request for the Jitsi widget ([\matrix-org#7033](matrix-org#7033)). Fixes element-hq/element-web#16552 and element-hq/element-web#16552.
* Fix cannot read length of undefined for room upgrades ([\matrix-org#7037](matrix-org#7037)). Fixes element-hq/element-web#19509 and element-hq/element-web#19509.
* Cleanup re-dispatching around timelines and composers ([\matrix-org#7023](matrix-org#7023)). Fixes element-hq/element-web#19491 and element-hq/element-web#19491. Contributed by @SimonBrandner.
* Fix removing a room from a Space and interaction with `m.space.parent` ([\matrix-org#6944](matrix-org#6944)). Fixes element-hq/element-web#19363 and element-hq/element-web#19363.
* Fix recent css regression ([\matrix-org#7022](matrix-org#7022)). Fixes element-hq/element-web#19470 and element-hq/element-web#19470. Contributed by @CicadaCinema.
* Fix ModalManager reRender racing with itself ([\matrix-org#7027](matrix-org#7027)). Fixes element-hq/element-web#19489 and element-hq/element-web#19489.
* Fix fullscreening a call while connecting ([\matrix-org#7019](matrix-org#7019)). Fixes element-hq/element-web#19309 and element-hq/element-web#19309. Contributed by @SimonBrandner.
* Allow scrolling right in reply-quoted code block ([\matrix-org#7024](matrix-org#7024)). Fixes element-hq/element-web#19487 and element-hq/element-web#19487. Contributed by @SimonBrandner.
* Fix dark theme codeblock colors ([\matrix-org#6384](matrix-org#6384)). Fixes element-hq/element-web#17998. Contributed by @SimonBrandner.
* Show passphrase input label ([\matrix-org#6992](matrix-org#6992)). Fixes element-hq/element-web#19428 and element-hq/element-web#19428. Contributed by @RafaelGoncalves8.
* Always render disabled settings as disabled ([\matrix-org#7014](matrix-org#7014)).
* Make "Security Phrase" placeholder look consistent cross-browser ([\matrix-org#6870](matrix-org#6870)). Fixes element-hq/element-web#19006 and element-hq/element-web#19006. Contributed by @neer17.
* Fix direction override characters breaking member event text direction ([\matrix-org#6999](matrix-org#6999)).
* Remove redundant text in verification dialogs ([\matrix-org#6993](matrix-org#6993)). Fixes element-hq/element-web#19290 and element-hq/element-web#19290. Contributed by @RafaelGoncalves8.
* Fix space panel name overflowing ([\matrix-org#6995](matrix-org#6995)). Fixes element-hq/element-web#19455 and element-hq/element-web#19455.
* Fix conflicting CSS on syntax highlighted blocks ([\matrix-org#6991](matrix-org#6991)). Fixes element-hq/element-web#19445 and element-hq/element-web#19445.
su-ex added a commit to SchildiChat/element-web that referenced this issue Nov 8, 2021
@su-ex
Merge tag 'v1.9.4' into sc
1ce931a 
* Improve the look of tooltips ([\element-hq#7049](matrix-org/matrix-react-sdk#7049)). Contributed by @SimonBrandner.
* Improve the look of the spinner ([\element-hq#6083](matrix-org/matrix-react-sdk#6083)). Contributed by @SimonBrandner.
* Polls: Creation form & start event ([\element-hq#7001](matrix-org/matrix-react-sdk#7001)).
* Show a gray shield when encrypted by deleted session ([\element-hq#6119](matrix-org/matrix-react-sdk#6119)). Contributed by @SimonBrandner.
* <notes> ([\element-hq#7057](matrix-org/matrix-react-sdk#7057)). Contributed by @ndarilek.
* Make message separator more accessible. ([\element-hq#7056](matrix-org/matrix-react-sdk#7056)). Contributed by @ndarilek.
* <notes> ([\element-hq#7035](matrix-org/matrix-react-sdk#7035)). Contributed by @ndarilek.
* Implement RequiresClient capability for widgets ([\element-hq#7005](matrix-org/matrix-react-sdk#7005)). Fixes element-hq#15744 and element-hq#15744.
* Respect the system high contrast setting when using system theme ([\element-hq#7043](matrix-org/matrix-react-sdk#7043)).
* Remove redundant duplicate mimetype field which doesn't conform to spec ([\element-hq#7045](matrix-org/matrix-react-sdk#7045)). Fixes element-hq#17145 and element-hq#17145.
* Make join button on space hierarchy action in the background ([\element-hq#7041](matrix-org/matrix-react-sdk#7041)). Fixes element-hq#17388 and element-hq#17388.
* Add a high contrast theme (a variant of the light theme) ([\element-hq#7036](matrix-org/matrix-react-sdk#7036)).
* Improve timeline message for restricted join rule changes ([\element-hq#6984](matrix-org/matrix-react-sdk#6984)). Fixes element-hq#18980 and element-hq#18980.
* Improve the appearance of the font size slider ([\element-hq#7038](matrix-org/matrix-react-sdk#7038)).
* Improve RovingTabIndex & Room List filtering performance ([\element-hq#6987](matrix-org/matrix-react-sdk#6987)). Fixes element-hq#17864 and element-hq#17864.
* Remove outdated Spaces restricted rooms warning ([\element-hq#6927](matrix-org/matrix-react-sdk#6927)).
* Make /msg <message> param optional for more flexibility ([\element-hq#7028](matrix-org/matrix-react-sdk#7028)). Fixes element-hq#19481 and element-hq#19481.
* Add decoration to space hierarchy for tiles which have already been j… ([\element-hq#6969](matrix-org/matrix-react-sdk#6969)). Fixes element-hq#18755 and element-hq#18755.
* Add insert link button to the format bar ([\element-hq#5879](matrix-org/matrix-react-sdk#5879)). Contributed by @SimonBrandner.
* Improve visibility of font size chooser ([\element-hq#6988](matrix-org/matrix-react-sdk#6988)).
* Soften border-radius on selected/hovered messages ([\element-hq#6525](matrix-org/matrix-react-sdk#6525)). Fixes element-hq#18108. Contributed by @SimonBrandner.
* Add a developer mode flag and use it for accessing space timelines ([\element-hq#6994](matrix-org/matrix-react-sdk#6994)). Fixes element-hq#19416 and element-hq#19416.
* Position toggle switch more clearly ([\element-hq#6914](matrix-org/matrix-react-sdk#6914)). Contributed by @CicadaCinema.
* Validate email address in forgot password dialog ([\element-hq#6983](matrix-org/matrix-react-sdk#6983)). Fixes element-hq#9978 and element-hq#9978. Contributed by @psrpinto.
* Handle and i18n M_THREEPID_IN_USE during registration ([\element-hq#6986](matrix-org/matrix-react-sdk#6986)). Fixes element-hq#13767 and element-hq#13767.
* For space invite previews, use room summary API to get the right member count ([\element-hq#6982](matrix-org/matrix-react-sdk#6982)). Fixes element-hq#19123 and element-hq#19123.
* Simplify Space Panel notification badge layout ([\element-hq#6977](matrix-org/matrix-react-sdk#6977)). Fixes element-hq#18527 and element-hq#18527.
* Use prettier hsName during 3pid registration where possible ([\element-hq#6980](matrix-org/matrix-react-sdk#6980)). Fixes element-hq#19162 and element-hq#19162.
* Add a condition to only activate the resizer which belongs to the clicked handle ([\element-hq#7055](matrix-org/matrix-react-sdk#7055)). Fixes element-hq#19521 and element-hq#19521.
* Restore composer focus after event edit ([\element-hq#7065](matrix-org/matrix-react-sdk#7065)). Fixes element-hq#19469 and element-hq#19469.
* Don't apply message bubble visual style to media messages ([\element-hq#7040](matrix-org/matrix-react-sdk#7040)).
* Handle no selected screen when screen-sharing ([\#7018](matrix-org/matrix-react-sdk#7018)). Fixes element-hq#19460 and element-hq#19460. Contributed by @SimonBrandner.
* Add history entry before completing emoji ([\element-hq#7007](matrix-org/matrix-react-sdk#7007)). Fixes element-hq#19177 and element-hq#19177. Contributed by @RafaelGoncalves8.
* Add padding between controls on edit form in message bubbles ([\element-hq#7039](matrix-org/matrix-react-sdk#7039)).
* Respect the roomState right container request for the Jitsi widget ([\element-hq#7033](matrix-org/matrix-react-sdk#7033)). Fixes element-hq#16552 and element-hq#16552.
* Fix cannot read length of undefined for room upgrades ([\element-hq#7037](matrix-org/matrix-react-sdk#7037)). Fixes element-hq#19509 and element-hq#19509.
* Cleanup re-dispatching around timelines and composers ([\element-hq#7023](matrix-org/matrix-react-sdk#7023)). Fixes element-hq#19491 and element-hq#19491. Contributed by @SimonBrandner.
* Fix removing a room from a Space and interaction with `m.space.parent` ([\element-hq#6944](matrix-org/matrix-react-sdk#6944)). Fixes element-hq#19363 and element-hq#19363.
* Fix recent css regression ([\element-hq#7022](matrix-org/matrix-react-sdk#7022)). Fixes element-hq#19470 and element-hq#19470. Contributed by @CicadaCinema.
* Fix ModalManager reRender racing with itself ([\element-hq#7027](matrix-org/matrix-react-sdk#7027)). Fixes element-hq#19489 and element-hq#19489.
* Fix fullscreening a call while connecting ([\element-hq#7019](matrix-org/matrix-react-sdk#7019)). Fixes element-hq#19309 and element-hq#19309. Contributed by @SimonBrandner.
* Allow scrolling right in reply-quoted code block ([\element-hq#7024](matrix-org/matrix-react-sdk#7024)). Fixes element-hq#19487 and element-hq#19487. Contributed by @SimonBrandner.
* Fix dark theme codeblock colors ([\element-hq#6384](matrix-org/matrix-react-sdk#6384)). Fixes element-hq#17998. Contributed by @SimonBrandner.
* Show passphrase input label ([\element-hq#6992](matrix-org/matrix-react-sdk#6992)). Fixes element-hq#19428 and element-hq#19428. Contributed by @RafaelGoncalves8.
* Always render disabled settings as disabled ([\element-hq#7014](matrix-org/matrix-react-sdk#7014)).
* Make "Security Phrase" placeholder look consistent cross-browser ([\element-hq#6870](matrix-org/matrix-react-sdk#6870)). Fixes element-hq#19006 and element-hq#19006. Contributed by @neer17.
* Fix direction override characters breaking member event text direction ([\element-hq#6999](matrix-org/matrix-react-sdk#6999)).
* Remove redundant text in verification dialogs ([\element-hq#6993](matrix-org/matrix-react-sdk#6993)). Fixes element-hq#19290 and element-hq#19290. Contributed by @RafaelGoncalves8.
* Fix space panel name overflowing ([\element-hq#6995](matrix-org/matrix-react-sdk#6995)). Fixes element-hq#19455 and element-hq#19455.
* Fix conflicting CSS on syntax highlighted blocks ([\element-hq#6991](matrix-org/matrix-react-sdk#6991)). Fixes element-hq#19445 and element-hq#19445.
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Nov 8, 2021
@su-ex
Merge tag 'v1.9.4' into sc
be1f9d6 
* Improve the look of tooltips ([\#7049](matrix-org/matrix-react-sdk#7049)). Contributed by @SimonBrandner.
* Improve the look of the spinner ([\#6083](matrix-org/matrix-react-sdk#6083)). Contributed by @SimonBrandner.
* Polls: Creation form & start event ([\#7001](matrix-org/matrix-react-sdk#7001)).
* Show a gray shield when encrypted by deleted session ([\#6119](matrix-org/matrix-react-sdk#6119)). Contributed by @SimonBrandner.
* Silence some widgets for better screen reader presentation. ([\#7057](matrix-org/matrix-react-sdk#7057)). Contributed by @ndarilek.
* Make message separator more accessible. ([\#7056](matrix-org/matrix-react-sdk#7056)). Contributed by @ndarilek.
* Give each room directory entry the `listitem` role to correspond with the containing `list`. ([\#7035](matrix-org/matrix-react-sdk#7035)). Contributed by @ndarilek.
* Implement RequiresClient capability for widgets ([\#7005](matrix-org/matrix-react-sdk#7005)). Fixes element-hq/element-web#15744 and element-hq/element-web#15744.
* Respect the system high contrast setting when using system theme ([\#7043](matrix-org/matrix-react-sdk#7043)).
* Remove redundant duplicate mimetype field which doesn't conform to spec ([\#7045](matrix-org/matrix-react-sdk#7045)). Fixes element-hq/element-web#17145 and element-hq/element-web#17145.
* Make join button on space hierarchy action in the background ([\#7041](matrix-org/matrix-react-sdk#7041)). Fixes element-hq/element-web#17388 and element-hq/element-web#17388.
* Add a high contrast theme (a variant of the light theme) ([\#7036](matrix-org/matrix-react-sdk#7036)).
* Improve timeline message for restricted join rule changes ([\#6984](matrix-org/matrix-react-sdk#6984)). Fixes element-hq/element-web#18980 and element-hq/element-web#18980.
* Improve the appearance of the font size slider ([\#7038](matrix-org/matrix-react-sdk#7038)).
* Improve RovingTabIndex & Room List filtering performance ([\#6987](matrix-org/matrix-react-sdk#6987)). Fixes element-hq/element-web#17864 and element-hq/element-web#17864.
* Remove outdated Spaces restricted rooms warning ([\#6927](matrix-org/matrix-react-sdk#6927)).
* Make /msg <message> param optional for more flexibility ([\#7028](matrix-org/matrix-react-sdk#7028)). Fixes element-hq/element-web#19481 and element-hq/element-web#19481.
* Add decoration to space hierarchy for tiles which have already been j… ([\#6969](matrix-org/matrix-react-sdk#6969)). Fixes element-hq/element-web#18755 and element-hq/element-web#18755.
* Add insert link button to the format bar ([\#5879](matrix-org/matrix-react-sdk#5879)). Contributed by @SimonBrandner.
* Improve visibility of font size chooser ([\#6988](matrix-org/matrix-react-sdk#6988)).
* Soften border-radius on selected/hovered messages ([\#6525](matrix-org/matrix-react-sdk#6525)). Fixes element-hq/element-web#18108. Contributed by @SimonBrandner.
* Add a developer mode flag and use it for accessing space timelines ([\#6994](matrix-org/matrix-react-sdk#6994)). Fixes element-hq/element-web#19416 and element-hq/element-web#19416.
* Position toggle switch more clearly ([\#6914](matrix-org/matrix-react-sdk#6914)). Contributed by @CicadaCinema.
* Validate email address in forgot password dialog ([\#6983](matrix-org/matrix-react-sdk#6983)). Fixes element-hq/element-web#9978 and element-hq/element-web#9978. Contributed by @psrpinto.
* Handle and i18n M_THREEPID_IN_USE during registration ([\#6986](matrix-org/matrix-react-sdk#6986)). Fixes element-hq/element-web#13767 and element-hq/element-web#13767.
* For space invite previews, use room summary API to get the right member count ([\#6982](matrix-org/matrix-react-sdk#6982)). Fixes element-hq/element-web#19123 and element-hq/element-web#19123.
* Simplify Space Panel notification badge layout ([\#6977](matrix-org/matrix-react-sdk#6977)). Fixes element-hq/element-web#18527 and element-hq/element-web#18527.
* Use prettier hsName during 3pid registration where possible ([\#6980](matrix-org/matrix-react-sdk#6980)). Fixes element-hq/element-web#19162 and element-hq/element-web#19162.
* Add a condition to only activate the resizer which belongs to the clicked handle ([\#7055](matrix-org/matrix-react-sdk#7055)). Fixes element-hq/element-web#19521 and element-hq/element-web#19521.
* Restore composer focus after event edit ([\#7065](matrix-org/matrix-react-sdk#7065)). Fixes element-hq/element-web#19469 and element-hq/element-web#19469.
* Don't apply message bubble visual style to media messages ([\#7040](matrix-org/matrix-react-sdk#7040)).
* Handle no selected screen when screen-sharing ([\#7018](matrix-org/matrix-react-sdk#7018)). Fixes element-hq/element-web#19460 and element-hq/element-web#19460. Contributed by @SimonBrandner.
* Add history entry before completing emoji ([\#7007](matrix-org/matrix-react-sdk#7007)). Fixes element-hq/element-web#19177 and element-hq/element-web#19177. Contributed by @RafaelGoncalves8.
* Add padding between controls on edit form in message bubbles ([\#7039](matrix-org/matrix-react-sdk#7039)).
* Respect the roomState right container request for the Jitsi widget ([\#7033](matrix-org/matrix-react-sdk#7033)). Fixes element-hq/element-web#16552 and element-hq/element-web#16552.
* Fix cannot read length of undefined for room upgrades ([\#7037](matrix-org/matrix-react-sdk#7037)). Fixes element-hq/element-web#19509 and element-hq/element-web#19509.
* Cleanup re-dispatching around timelines and composers ([\#7023](matrix-org/matrix-react-sdk#7023)). Fixes element-hq/element-web#19491 and element-hq/element-web#19491. Contributed by @SimonBrandner.
* Fix removing a room from a Space and interaction with `m.space.parent` ([\#6944](matrix-org/matrix-react-sdk#6944)). Fixes element-hq/element-web#19363 and element-hq/element-web#19363.
* Fix recent css regression ([\#7022](matrix-org/matrix-react-sdk#7022)). Fixes element-hq/element-web#19470 and element-hq/element-web#19470. Contributed by @CicadaCinema.
* Fix ModalManager reRender racing with itself ([\#7027](matrix-org/matrix-react-sdk#7027)). Fixes element-hq/element-web#19489 and element-hq/element-web#19489.
* Fix fullscreening a call while connecting ([\#7019](matrix-org/matrix-react-sdk#7019)). Fixes element-hq/element-web#19309 and element-hq/element-web#19309. Contributed by @SimonBrandner.
* Allow scrolling right in reply-quoted code block ([\#7024](matrix-org/matrix-react-sdk#7024)). Fixes element-hq/element-web#19487 and element-hq/element-web#19487. Contributed by @SimonBrandner.
* Fix dark theme codeblock colors ([\#6384](matrix-org/matrix-react-sdk#6384)). Fixes element-hq/element-web#17998. Contributed by @SimonBrandner.
* Show passphrase input label ([\#6992](matrix-org/matrix-react-sdk#6992)). Fixes element-hq/element-web#19428 and element-hq/element-web#19428. Contributed by @RafaelGoncalves8.
* Always render disabled settings as disabled ([\#7014](matrix-org/matrix-react-sdk#7014)).
* Make "Security Phrase" placeholder look consistent cross-browser ([\#6870](matrix-org/matrix-react-sdk#6870)). Fixes element-hq/element-web#19006 and element-hq/element-web#19006. Contributed by @neer17.
* Fix direction override characters breaking member event text direction ([\#6999](matrix-org/matrix-react-sdk#6999)).
* Remove redundant text in verification dialogs ([\#6993](matrix-org/matrix-react-sdk#6993)). Fixes element-hq/element-web#19290 and element-hq/element-web#19290. Contributed by @RafaelGoncalves8.
* Fix space panel name overflowing ([\#6995](matrix-org/matrix-react-sdk#6995)). Fixes element-hq/element-web#19455 and element-hq/element-web#19455.
* Fix conflicting CSS on syntax highlighted blocks ([\#6991](matrix-org/matrix-react-sdk#6991)). Fixes element-hq/element-web#19445 and element-hq/element-web#19445.
williamkray added a commit to williamkray/element-web that referenced this issue Nov 9, 2021
@williamkray
Merge tag 'v1.9.4' into develop
431f200 
* Improve the look of tooltips ([\element-hq#7049](matrix-org/matrix-react-sdk#7049)). Contributed by @SimonBrandner.
* Improve the look of the spinner ([\element-hq#6083](matrix-org/matrix-react-sdk#6083)). Contributed by @SimonBrandner.
* Polls: Creation form & start event ([\element-hq#7001](matrix-org/matrix-react-sdk#7001)).
* Show a gray shield when encrypted by deleted session ([\element-hq#6119](matrix-org/matrix-react-sdk#6119)). Contributed by @SimonBrandner.
* <notes> ([\element-hq#7057](matrix-org/matrix-react-sdk#7057)). Contributed by @ndarilek.
* Make message separator more accessible. ([\element-hq#7056](matrix-org/matrix-react-sdk#7056)). Contributed by @ndarilek.
* <notes> ([\element-hq#7035](matrix-org/matrix-react-sdk#7035)). Contributed by @ndarilek.
* Implement RequiresClient capability for widgets ([\element-hq#7005](matrix-org/matrix-react-sdk#7005)). Fixes element-hq#15744 and element-hq#15744.
* Respect the system high contrast setting when using system theme ([\element-hq#7043](matrix-org/matrix-react-sdk#7043)).
* Remove redundant duplicate mimetype field which doesn't conform to spec ([\element-hq#7045](matrix-org/matrix-react-sdk#7045)). Fixes element-hq#17145 and element-hq#17145.
* Make join button on space hierarchy action in the background ([\element-hq#7041](matrix-org/matrix-react-sdk#7041)). Fixes element-hq#17388 and element-hq#17388.
* Add a high contrast theme (a variant of the light theme) ([\element-hq#7036](matrix-org/matrix-react-sdk#7036)).
* Improve timeline message for restricted join rule changes ([\element-hq#6984](matrix-org/matrix-react-sdk#6984)). Fixes element-hq#18980 and element-hq#18980.
* Improve the appearance of the font size slider ([\element-hq#7038](matrix-org/matrix-react-sdk#7038)).
* Improve RovingTabIndex & Room List filtering performance ([\element-hq#6987](matrix-org/matrix-react-sdk#6987)). Fixes element-hq#17864 and element-hq#17864.
* Remove outdated Spaces restricted rooms warning ([\element-hq#6927](matrix-org/matrix-react-sdk#6927)).
* Make /msg <message> param optional for more flexibility ([\element-hq#7028](matrix-org/matrix-react-sdk#7028)). Fixes element-hq#19481 and element-hq#19481.
* Add decoration to space hierarchy for tiles which have already been j… ([\element-hq#6969](matrix-org/matrix-react-sdk#6969)). Fixes element-hq#18755 and element-hq#18755.
* Add insert link button to the format bar ([\element-hq#5879](matrix-org/matrix-react-sdk#5879)). Contributed by @SimonBrandner.
* Improve visibility of font size chooser ([\element-hq#6988](matrix-org/matrix-react-sdk#6988)).
* Soften border-radius on selected/hovered messages ([\element-hq#6525](matrix-org/matrix-react-sdk#6525)). Fixes element-hq#18108. Contributed by @SimonBrandner.
* Add a developer mode flag and use it for accessing space timelines ([\element-hq#6994](matrix-org/matrix-react-sdk#6994)). Fixes element-hq#19416 and element-hq#19416.
* Position toggle switch more clearly ([\element-hq#6914](matrix-org/matrix-react-sdk#6914)). Contributed by @CicadaCinema.
* Validate email address in forgot password dialog ([\element-hq#6983](matrix-org/matrix-react-sdk#6983)). Fixes element-hq#9978 and element-hq#9978. Contributed by @psrpinto.
* Handle and i18n M_THREEPID_IN_USE during registration ([\element-hq#6986](matrix-org/matrix-react-sdk#6986)). Fixes element-hq#13767 and element-hq#13767.
* For space invite previews, use room summary API to get the right member count ([\element-hq#6982](matrix-org/matrix-react-sdk#6982)). Fixes element-hq#19123 and element-hq#19123.
* Simplify Space Panel notification badge layout ([\element-hq#6977](matrix-org/matrix-react-sdk#6977)). Fixes element-hq#18527 and element-hq#18527.
* Use prettier hsName during 3pid registration where possible ([\element-hq#6980](matrix-org/matrix-react-sdk#6980)). Fixes element-hq#19162 and element-hq#19162.
* Add a condition to only activate the resizer which belongs to the clicked handle ([\element-hq#7055](matrix-org/matrix-react-sdk#7055)). Fixes element-hq#19521 and element-hq#19521.
* Restore composer focus after event edit ([\element-hq#7065](matrix-org/matrix-react-sdk#7065)). Fixes element-hq#19469 and element-hq#19469.
* Don't apply message bubble visual style to media messages ([\element-hq#7040](matrix-org/matrix-react-sdk#7040)).
* Handle no selected screen when screen-sharing ([\#7018](matrix-org/matrix-react-sdk#7018)). Fixes element-hq#19460 and element-hq#19460. Contributed by @SimonBrandner.
* Add history entry before completing emoji ([\element-hq#7007](matrix-org/matrix-react-sdk#7007)). Fixes element-hq#19177 and element-hq#19177. Contributed by @RafaelGoncalves8.
* Add padding between controls on edit form in message bubbles ([\element-hq#7039](matrix-org/matrix-react-sdk#7039)).
* Respect the roomState right container request for the Jitsi widget ([\element-hq#7033](matrix-org/matrix-react-sdk#7033)). Fixes element-hq#16552 and element-hq#16552.
* Fix cannot read length of undefined for room upgrades ([\element-hq#7037](matrix-org/matrix-react-sdk#7037)). Fixes element-hq#19509 and element-hq#19509.
* Cleanup re-dispatching around timelines and composers ([\element-hq#7023](matrix-org/matrix-react-sdk#7023)). Fixes element-hq#19491 and element-hq#19491. Contributed by @SimonBrandner.
* Fix removing a room from a Space and interaction with `m.space.parent` ([\element-hq#6944](matrix-org/matrix-react-sdk#6944)). Fixes element-hq#19363 and element-hq#19363.
* Fix recent css regression ([\element-hq#7022](matrix-org/matrix-react-sdk#7022)). Fixes element-hq#19470 and element-hq#19470. Contributed by @CicadaCinema.
* Fix ModalManager reRender racing with itself ([\element-hq#7027](matrix-org/matrix-react-sdk#7027)). Fixes element-hq#19489 and element-hq#19489.
* Fix fullscreening a call while connecting ([\element-hq#7019](matrix-org/matrix-react-sdk#7019)). Fixes element-hq#19309 and element-hq#19309. Contributed by @SimonBrandner.
* Allow scrolling right in reply-quoted code block ([\element-hq#7024](matrix-org/matrix-react-sdk#7024)). Fixes element-hq#19487 and element-hq#19487. Contributed by @SimonBrandner.
* Fix dark theme codeblock colors ([\element-hq#6384](matrix-org/matrix-react-sdk#6384)). Fixes element-hq#17998. Contributed by @SimonBrandner.
* Show passphrase input label ([\element-hq#6992](matrix-org/matrix-react-sdk#6992)). Fixes element-hq#19428 and element-hq#19428. Contributed by @RafaelGoncalves8.
* Always render disabled settings as disabled ([\element-hq#7014](matrix-org/matrix-react-sdk#7014)).
* Make "Security Phrase" placeholder look consistent cross-browser ([\element-hq#6870](matrix-org/matrix-react-sdk#6870)). Fixes element-hq#19006 and element-hq#19006. Contributed by @neer17.
* Fix direction override characters breaking member event text direction ([\element-hq#6999](matrix-org/matrix-react-sdk#6999)).
* Remove redundant text in verification dialogs ([\element-hq#6993](matrix-org/matrix-react-sdk#6993)). Fixes element-hq#19290 and element-hq#19290. Contributed by @RafaelGoncalves8.
* Fix space panel name overflowing ([\element-hq#6995](matrix-org/matrix-react-sdk#6995)). Fixes element-hq#19455 and element-hq#19455.
* Fix conflicting CSS on syntax highlighted blocks ([\element-hq#6991](matrix-org/matrix-react-sdk#6991)). Fixes element-hq#19445 and element-hq#19445.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Spec-Changes
Projects
None yet
Milestone
No milestone
4 participants
@kittykat @novocaine @t3chguy @BillCarsonFr