Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end tests failing on pip install step #16272

Closed
jryans opened this issue Jan 25, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5570
Closed

End-to-end tests failing on pip install step #16272

jryans opened this issue Jan 25, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5570
Assignees
@jryans
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 25, 2021 

Traceback (most recent call last):
  File "get-pip.py", line 24226, in <module>
    main()
  File "get-pip.py", line 199, in main
    bootstrap(tmpdir=tmpdir)
  File "get-pip.py", line 82, in bootstrap
    from pip._internal.cli.main import main as pip_entry_point
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 954, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 896, in _find_spec
  File "<frozen importlib._bootstrap_external>", line 1147, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1123, in _get_spec
  File "<frozen importlib._bootstrap_external>", line 1104, in _legacy_get_spec
  File "<frozen importlib._bootstrap>", line 444, in spec_from_loader
  File "<frozen importlib._bootstrap_external>", line 541, in spec_from_file_location
  File "/tmp/tmpl3gzq7zy/pip.zip/pip/_internal/cli/main.py", line 60
    sys.stderr.write(f"ERROR: {exc}")
                                   ^
SyntaxError: invalid syntax
handle_error

Seems related to pypa/get-pip#83. Most likely we can pin to an install for a specific Python version once we know what we're running...
@jryans jryans added T-Defect defect T-Task Tasks for the team like planning P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 25, 2021
@jryans jryans self-assigned this Jan 25, 2021
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 25, 2021
@jryans
Move to newer base image for end-to-end tests
377e6b5 
This updates to Node 14 (current LTS) as well moving from Debian Stretch to
Buster for the base OS. The Debian upgrade brings along a newer Python 3.8,
which is actively supported.

Fixes element-hq/element-web#16272
@jryans jryans mentioned this issue Jan 25, 2021
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 25, 2021
@jryans
Move to newer base image for end-to-end tests
5b2f915 
This updates to Node 14 (current LTS) as well as moving from Debian Stretch to
Buster for the base OS. The Debian upgrade brings along a newer Python 3.8,
which is actively supported.

Fixes element-hq/element-web#16272
@jryans
Copy link
Collaborator Author

jryans commented Jan 25, 2021

This should be resolved now for new PRs, and I retriggered all the existing ones that were failing, so they should turn green soon. In the end, the right fix was moving CI to a newer base image with modern Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to newer base image for end-to-end tests matrix-org/matrix-react-sdk
1 participant
@jryans