Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for forwarding messages has completely disappeared #14690

Closed
ara4n opened this issue Jul 22, 2020 · 10 comments · Fixed by matrix-org/matrix-react-sdk#5999
Closed

UI for forwarding messages has completely disappeared #14690

ara4n opened this issue Jul 22, 2020 · 10 comments · Fixed by matrix-org/matrix-react-sdk#5999

Comments

@ara4n
Copy link
Member

ara4n commented Jul 22, 2020

although it still works, it doesn't prompt you to select the destination whatsoever. needs design urgently

@turt2live
Copy link
Member

backstory: years of regressions and lack of attention have slowly dwindled this down to just an h2 hovering near the top of the page. It used to have all kinds of neat fading effects, actual backgrounds, clear instructions, etc.

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2020

Related #5641

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2020

Related #11195

@jryans
Copy link
Collaborator

jryans commented Jul 23, 2020

I think this is a duplicate of #10165. (Also, it seems unrelated to new-room-list?)

@t3chguy
Copy link
Member

t3chguy commented Jul 23, 2020

I mean you forward by clicking the room list but yes otherwise

I would say that #5641 covers the whole situation well enough, its just poor UX, now more than ever

@niquewoodhouse
Copy link

Quick wireframe of this using the notification settings modal. A bit rushed but just to aid discussion as I don't know what the UI used to look like.

  • Can preview message for context and re-assurance
  • Can't add a message
  • Can multi-pick rooms/chats

01  fwd--msg--simple

Is this roughly what it was like? Does it seem feasible and good?

@t3chguy
Copy link
Member

t3chguy commented Jul 24, 2020

Previously (completely developer design) it gave you a modal-like prompt to select a room in the Room List, and upon you clicking that room in the room list it'd forward the message there.

@niquewoodhouse
Copy link

Here's a UI that I think makes sense. It's not pixel perfect, just an indication of what would make sense from a design perspective.

1. Fwd message
fwd--msg@2x

  • Preview of message (uses same component as reply in timeline)

2. Sending
fwd--msg-feedback@2x

3. Forwarded message
01  fwd--msg--simple@2x

In testing this, it doesn't look like forwarded messages include the name/image of the original author or where's it's from, which I think isn't ideal. So I'd advocate for it to look like the above.

@t3chguy
Copy link
Member

t3chguy commented Jul 27, 2020

In testing this, it doesn't look like forwarded messages include the name/image of the original author or where's it's from, which I think isn't ideal. So I'd advocate for it to look like the above.

That would be blocked on a Matrix spec proposal https://github.com/vector-im/riot-web/issues/4747

@MurzNN
Copy link
Contributor

MurzNN commented Jul 30, 2020

Also message forwarding (one or several) can be implemented using message attachments, proposed here: https://github.com/matrix-org/matrix-doc/issues/2289

robintown added a commit to robintown/matrix-react-sdk that referenced this issue May 9, 2021
Replaces the old forwarding UI with a dialog based on designs from
element-hq/element-web#14690.

Signed-off-by: Robin Townsend <[email protected]>
robintown added a commit to robintown/matrix-react-sdk that referenced this issue May 9, 2021
Replaces the old forwarding UI with a dialog based on designs from
element-hq/element-web#14690.

Signed-off-by: Robin Townsend <[email protected]>
robintown added a commit to robintown/matrix-react-sdk that referenced this issue May 9, 2021
Replaces the old forwarding UI with a dialog based on designs from
element-hq/element-web#14690.

Signed-off-by: Robin Townsend <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants