Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SSO flow doesn't work with non-default profile #12932

Closed
SISheogorath opened this issue Mar 30, 2020 · 3 comments · Fixed by #13028
Closed

New SSO flow doesn't work with non-default profile #12932

SISheogorath opened this issue Mar 30, 2020 · 3 comments · Fixed by #13028
Assignees
Labels

Comments

@SISheogorath
Copy link

SISheogorath commented Mar 30, 2020

Description

When using a custom profile (/path/to/riot --profile test) the SSO redirect with the riot:// isn't aware of the profile and therefore Riot ends up messing with the default profile instead of the one you use for starting the SSO process.

Steps to reproduce

  • Run Riot with a non-default profile (/path/to/riot --profile test)
  • Try to log in via SSO
  • Follow the riot://-URL in order to complete the SSO login

Describe how what happens differs from what you expected.

Riot opens with the default profile and even causes a "successful" login in the wrong profile which leads to re-syncs, changed E2E keys and everything you expect from a new login for the default profile instead of the non-default one.

Version information

  • Platform: desktop
  • OS: Fedora Linux with Riot in Flatpak from Flathub
  • Version: v1.5.14
@t3chguy
Copy link
Member

t3chguy commented Mar 30, 2020

Protocol handlers (except in Windows) cannot provide command line arguments, so there isn't really anything which can be done here

@SISheogorath
Copy link
Author

I think the redirect URL itself could contain this information as a parameter. When riot opens/handles the URL it could use the same logic as for the CLI argument. This could solve this issue. This is already done with the homeserver and should also be doable with the profile.

@t3chguy
Copy link
Member

t3chguy commented Mar 30, 2020

Potentially. Will see how electron likes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants