Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new session toast pops up again after doing self-verification with same device #12690

Closed
bwindels opened this issue Mar 11, 2020 · 5 comments
Closed

Comments

@bwindels
Copy link
Contributor

No description provided.

@bwindels
Copy link
Contributor Author

@bwindels bwindels self-assigned this Mar 13, 2020
@bwindels
Copy link
Contributor Author

bwindels commented Mar 13, 2020

Rageshake doesn't seem to contain all the information about the self-verification request, just this one cancel event sent by riot-web that moved the request from phase started to cancelled.

2020-03-11T14:30:33.630Z I Verification request 7iNBC2trWduZGulkUOlKKzYrZrsw3TVt: m.key.verification.cancel event with id:undefined, content:{"code":"m.user","reason":"User declined","transaction_id":"7iNBC2trWduZGulkUOlKKzYrZrsw3TVt"} deviceId:UAAPDVEEIE, sender:@matthew:matrix.org, isSentByUs:true, isLiveEvent:true, isRemoteEcho:true, phase:4=>5, observeOnly:false=>false

UAAPDVEEIE is the device named Mobile, so presumably the iOS device. If this is indeed the self-verification request referred to in the title, it would mean cancel() was called on the request (with the default reason/code), which can happen from multiple locations (e.g. closing the verification dialog) but that also means the request didn't complete successfully. That would explain the new session toast appearing afterwards...

But without more information and also a rageshake from iOS this is only guesswork. Need more info so please rageshake from both sides if you see this again @ara4n

@bwindels bwindels removed their assignment Mar 13, 2020
@jryans jryans added story:1 and removed story:2 labels Apr 2, 2020
@bwindels bwindels assigned bwindels and unassigned bwindels Apr 2, 2020
@bwindels
Copy link
Contributor Author

bwindels commented Apr 2, 2020

So I don't think this is related to #12926, as this is a toast for verifying another device and the other ticket is about self-verification. Not entirely sure whether there is even a problem (at least with toasts) here until we have more info, see comment above.

@dbkr dbkr self-assigned this Apr 7, 2020
@dbkr
Copy link
Member

dbkr commented Apr 7, 2020

oh, this has already been looked at - will leave for now

@dbkr dbkr removed their assignment Apr 7, 2020
@jryans
Copy link
Collaborator

jryans commented Apr 9, 2020

Sounds like we don't have enough info here to investigate, so I'll close for now. Please reopen / refile if it happens again.

@jryans jryans closed this as completed Apr 9, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants