Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching branches on CI no longer works #12553

Closed
jryans opened this issue Feb 27, 2020 · 1 comment · Fixed by matrix-org/pipelines#44
Closed

Matching branches on CI no longer works #12553

jryans opened this issue Feb 27, 2020 · 1 comment · Fixed by matrix-org/pipelines#44
Assignees
@jryans
Labels
T-Task Tasks for the team like planning X-Regression

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 27, 2020

We used to have CI setup to try matching branches across the various repos so that you get green checks even when changing several repos at once, but this seems to have regressed at some point.
@jryans jryans added T-Task Tasks for the team like planning X-Regression labels Feb 27, 2020
@jryans jryans self-assigned this Feb 27, 2020
@jryans
Copy link
Collaborator Author

jryans commented Feb 27, 2020

https://buildkite.com/matrix-dot-org/riot-web/builds/2117#db3a8cf9-5d94-4377-8dd6-03ebaa4d1e57 is one example. It seems to have not even tried to fetch the matching JS SDK branch.

@jryans jryans mentioned this issue Feb 27, 2020
Merged
jryans added a commit to matrix-org/pipelines that referenced this issue Feb 27, 2020
@jryans
Propagate environment for all Riot tests with dependencies
9571fea 
To ensure we can make changes across several Riot repos at once, we need to
propagate environment to all test runs that install dependencies from other
repos so we can pull matching branches.

Fixes element-hq/element-web#12553
@jryans jryans mentioned this issue Feb 27, 2020
Merged
richvdh pushed a commit to matrix-org/pipelines that referenced this issue Feb 27, 2020
@jryans
Propagate environment for all Riot tests with dependencies (#44)
cd55b48 
To ensure we can make changes across several Riot repos at once, we need to
propagate environment to all test runs that install dependencies from other
repos so we can pull matching branches.

Fixes element-hq/element-web#12553
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@florianduros
Tooltip: close field tooltip when ESC is pressed (#12553)
17ab522 
* Close field tooltip when ESC is pressed

* Use `Key.ESCAPE`
JohnSimonsen pushed a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
@thoraj @RiotRobot
@EdGeraghty @BillCarsonFr @florianduros @dbkr @richvdh @t3chguy
Bring develop to version 3.100.0 (element-hq#73)
040bacb 
* Upgrade dependency to [email protected]

* v3.100.0-rc.0

* Upgrade dependency to [email protected]

* Remove code smell assertion identified by Sonar (element-hq#12547)

* This assertion is unnecessary since the receiver accepts the original type of the expression

* Implement `client.getDomain()` null check

* Update comment since `AutoDiscovery.findClientConfig` may still throw

* Report verification and recovery state to posthog (element-hq#12516)

* Report verification and recovery state to posthog

* Fix CryptoApi import

* Fix js-sdk import

* Review: Use DeviceVerificationStatus instead of CrossSigningStatus

* Review: Clean condition to check secrets in 4S

* review: Fix redundent !!

* Deprecate `Tooltip.tsx`

* Use tooltip compound in `MessageComposer.tsx`

* Use tooltip compound in `ReadReceiptGroup` component

* Use tooltip compound in `ReadReceiptPerson` component

* Delete `useTooltip.tsx`

* Use compound tooltip in `ReactionRowButton`

* Upgrade dependency to [email protected]

* Migrate `TooltipTarget` usage to compound `Tooltip` (element-hq#12542)

* Use new tooltip in `RoomTopic.tsx`

* Use new tooltip in `MLocationBody.tsx`

* Fix room topic

* Update location snapshot

* Use new tooltip in `AppPermission.tsx`

* Remove `TooltipTarget`

* Add tests for `RoomTopic`

* Add tests for `ReadReceiptGroup.tsx`

* Add more tests for `ReadReceiptGroup.tsx`

* Add more test for `ReactionsRowButton.tsx`

* Add seedrandom dep to `resolutions` (element-hq#12552)

* Move seedrandom dep to `resolutions`

... to shut renovate up

* Reinstate `seedrandom` as dev dependency

If we just declare it in `resolutions`, it doesn't get installed at all,
because it is only a devDependency of `bloom-filters`.

* [create-pull-request] automated change (element-hq#12554)

Co-authored-by: github-merge-queue <[email protected]>

* Avoid using deprecated exports, fields, and duplicate code (element-hq#12555)

* Fix tabbedview breakpoint width (element-hq#12556)

Which should be 1024 according to the designs, not 768

* Tooltip: close field tooltip when ESC is pressed (element-hq#12553)

* Close field tooltip when ESC is pressed

* Use `Key.ESCAPE`

* Close the release announcement when a dialog is opened (element-hq#12559)

* Fire `ModalManagerEvent.Closed` when a dialog is closed

* Listen to modal events in the RA

* Fix first RA test

* Upgrade dependency to [email protected]

* v3.100.0-rc.1

* Upgrade dependency to [email protected]

* v3.100.0

---------

Co-authored-by: RiotRobot <[email protected]>
Co-authored-by: Ed Geraghty <[email protected]>
Co-authored-by: Valere <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
T-Task Tasks for the team like planning X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate environment for all Riot tests with dependencies matrix-org/pipelines
1 participant
@jryans