Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local alias management should be hidden behind an advanced disclosure of some kind to mitigate spam #12462

Closed
ara4n opened this issue Feb 21, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4221
Closed

local alias management should be hidden behind an advanced disclosure of some kind to mitigate spam #12462

ara4n opened this issue Feb 21, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4221
Labels
A-Aliases A-Room-Settings T-Enhancement X-Needs-Design X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Feb 21, 2020

MSC2432 now lets us manage local aliases again, but this should be hidden behind an Advanced disclosure of some kind in RoomSettings, so that users casually clicking around the settings for a room don't get shown whatever random set of local aliases have been configured for a given room by default.

It's quite a poweruser thing to want to see what aliases exist on your local server for a given room, and given anyone can create an alias, there's chance of obnoxious ones being present there. Therefore I think it should be behind a <details/> or equivalent. needs input from @nadonomy

In future the UI should probably let you select which server whose aliases you're trying to view - but this API from MSC2432 hasn't yet been implemented in Synapse.
@ara4n ara4n added the T-Defect label Feb 21, 2020
@bwindels
Copy link
Contributor

I've already implemented this on /develop, we can implement design changes later.

@bwindels bwindels mentioned this issue Mar 16, 2020
Closed
@bwindels
Copy link
Contributor

Related: #12684

@bwindels bwindels mentioned this issue Mar 17, 2020
Merged
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@florianduros
Tooltip: Improve accessibility for context menus (#12462)
bec8fdb 
* Update `ContextMenuTooltipButton.tsx`

* Fix placement

* Update tests

* Update space panel snapshot

* Remove default placement

* Update snapshots

* Fix tooltip child rerender

* Remove useless props title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aliases A-Room-Settings T-Enhancement X-Needs-Design X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: make alternative addresses UX less confusing matrix-org/matrix-react-sdk
5 participants
@bwindels @jryans @turt2live @ara4n @aaronraimist