Recursive citations handled incorrectly

[Biep]

See https://matrix.to/#/!YTvKGNlinIzlkMTVRl:matrix.org/$hO5FfBiBXvtYWAFrADnEDaADy3J6wsX57qKFeDiyizU?via=matrix.org&via=privacytools.io&via=feneas.org and following.

[aaronraimist]

More keywords: Quoting a quoted message removes one level of quotedness.

[heylix]

This got worse in 1.6.0. The quotes sometimes get inserted as regular text at the beginning of the line and you don't even get a newline between that and the next thing you write:

As I see it on the mobile client (RiotX 0.21.0):

Sometimes it uses the text "in reply to" and sometimes "Als Antwort auf" – so maybe the translations break quotes?

This is the decrypted message:

{
  "content": {
    "body": "> <@user1:example.com> > <@user2:example.com> why does it work properly when we try to reproduce it but it shits itself usually\n> \n> I dont really know, maybe we need more quotes referencing each other\n\nI think it's when you use the mobile client",
    "format": "org.matrix.custom.html",
    "formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!Ro0mIdEnntific4tin:example.com/$dLL4x3Y2HDEoTYktLh27NRCer-5HCVZSf61Zi-pLMpo\">Als Antwort auf</a><a href=\"https://matrix.to/#/@user1:example.com\">@user1:example.com</a><br /><mx-reply><blockquote><a href=\"https://matrix.to/#/!Ro0mIdEnntific4tin:example.com/$MD_2l3777HxejAU71tj11Y4_HnWv_bydy36gGeWccJg?via=example.com\">In reply to</a> <a href=\"https://matrix.to/#/@user2:example.com\">@user2:example.com</a><br>why does it work properly when we try to reproduce it but it shits itself usually</blockquote></mx-reply>I dont really know, maybe we need more quotes referencing each other</blockquote></mx-reply>I think it's when you use the mobile client",
    "msgtype": "m.text"
  },
  "room_id": "!Ro0mIdEnntific4tin:example.com",
  "type": "m.room.message"
}

Looks like \n isn't always rendered properly? You can't really replicate it consistently, sometimes quoting works, sometimes it doesn't…

[t3chguy]

Looks like \n isn't always rendered properly? You can't really replicate it consistently, sometimes quoting works, sometimes it doesn't…

Are those broken events even sent by riot-web? There have been riot mobile bugs that look like that but I've never seen such an issue sent by riot-web. They are a flawed send over the wire, not rendering.

The decrypted message you shared is different to the faulty one, its of no help.

[heylix]

Are those broken events even sent by riot-web?

Yes.

They are a flawed send over the wire, not rendering.

No.

The decrypted message you shared is different to the faulty one

No.

[t3chguy]

The event is flawed over the wire as it is a reply without an m.relates_to m.in_reply_to

The event you shared is fine:

[t3chguy]

Your riot android screenshot doesn't even include that message, it is scrolled off the bottom.

[heylix]

You see how it renders for me in the first screenshot? The Android screenshot is just to show that while quoting a message originating from Android Riot-Web/Desktop doesn't properly render the message, it can still easily be quoted and rendered on Android, even though the translations are weird. The fact that it seems to render properly when you copy paste it is weird aswell as it's clearly botched at my end.

When copying the message I posted it is rendered properly again. So while the message is apparently fine, it still looks weird when I have sent it.

I don't know what more information I can give you. If you don't believe me that I can reproduce this when quoting a message on Android, then quoting it on Desktop, so be it.

[t3chguy]

@heylix upon review, this isn't the right issue for you, this issue is about Quotes, your example shows Replies.

[Michae94]

same problem than @heylix

[t3chguy]

It looks to be a RiotX bug with Replies to Replies which creates invalid events. Replying to those invalid events then from any clients creates more invalid events.

[t3chguy]

The symptom is being tracked as part of #14081

[Biep]

A maybe related issue:
A line with just === on it breaks citing. The lines after it become an independent citation.

[t3chguy]

This is fixed on develop