Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starting a VC with 2 people + a invitee can result in very strange race conditions #1202

Closed
ara4n opened this issue Mar 18, 2016 · 9 comments · Fixed by matrix-org/matrix-react-sdk#7557
Closed

starting a VC with 2 people + a invitee can result in very strange race conditions #1202

ara4n opened this issue Mar 18, 2016 · 9 comments · Fixed by matrix-org/matrix-react-sdk#7557
Labels
A-Element-Call Group calls via Element Call A-Jitsi A-VoIP O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@ara4n
Copy link
Member

ara4n commented Mar 18, 2016 •
edited by MadLittleMods
Loading

Starting a voice/video conference (VC) with 2 people + a invitee can result in very strange race conditions.

Reproduction instructions

  1. have a room with 2 people (A,B) + invitee (C)
  2. user A hits video call button - starts 1:1 with B
  3. C joins the room
  4. user C starts a voice/video conference
  5. all hell breaks loose, with Voip Conference users appearing in the memberlist and all sorts.
@SimonBrandner
Copy link
Contributor

The simple solution here would probably be to just start a conference if we have invitees

@SimonBrandner SimonBrandner added A-Jitsi good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P3 labels Nov 28, 2021
@kittykat
Copy link
Contributor

The correct approach would be to check if the room is not a DM and if it is not, then start a conference call instead of a 1:1 call

@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Papercuts Visible. Impactful. Predictable to action. Help Wanted Extra attention is needed labels Jan 17, 2022
@SimonBrandner SimonBrandner self-assigned this Jan 17, 2022
@SimonBrandner
Copy link
Contributor

The correct approach would be to check if the room is not a DM and if it is not, then start a conference call instead of a 1:1 call

I would argue that we should just check the member + invite count. Making this dependent on whether the room is a DM or not seems a little unideal. Both because people have DMs with more than 2 members and because this can break at times

@SimonBrandner SimonBrandner mentioned this issue Jan 17, 2022
Merged
@kittykat
Copy link
Contributor

kittykat commented Jan 17, 2022 •
edited
Loading

The correct approach would be to check if the room is not a DM and if it is not, then start a conference call instead of a 1:1 call

I would argue that we should just check the member + invite count. Making this dependent on whether the room is a DM or not seems a little unideal. Both because people have DMs with more than 2 members and because this can break at times

That would work unless a call is already in progress. Good point about DMs having more than two members. Can we do a check on "if room is not a DM or a DM and has 3+ members"? I defer to @dbkr to check the logic.

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jan 17, 2022 •
edited
Loading

That would work unless a call is already in progress

If a call is already in progress, I don't think this can work?

I think the best could actually be "If a room is not a DM or has 3 >= members/invitees"

@dbkr
Copy link
Member

dbkr commented Jan 17, 2022

Yeah, we could do that check. I guess it depends on what expectations are of DM rooms, Generally the intention would be to talk to a specific person, so a 1:1 call would make sense: especially if the other user was a bot, but there are probably other cases.

Also worth noting that this bug sounds like it was originally about the old, old MCU based conferencing (since it talks about voip conference users) although obviously the behaviour is still a little odd.

@dbkr dbkr mentioned this issue Jan 26, 2022
Merged
@dbkr dbkr reopened this Jan 26, 2022
@SimonBrandner SimonBrandner removed their assignment Jan 26, 2022
@SimonBrandner SimonBrandner removed Help Wanted Extra attention is needed good first issue Good for newcomers labels Jan 26, 2022
@SimonBrandner
Copy link
Contributor

Removed good first issue and Help Wanted as solving this causes other bugs

su-ex added a commit to SchildiChat/element-desktop that referenced this issue Jan 31, 2022
@su-ex
Merge tag 'v1.10.0' into sc
c735cc1 
* Enable posthog on app.element.io ([\#20539](element-hq/element-web#20539)).
* Tweak room list header menu for when space is active ([\#7577](matrix-org/matrix-react-sdk#7577)). Fixes element-hq/element-web#20601.
* Tweak light hover & active color for bubble layout ([\#7626](matrix-org/matrix-react-sdk#7626)). Fixes element-hq/element-web#19475.
* De-labs Metaspaces ([\#7613](matrix-org/matrix-react-sdk#7613)).
* De-labs Message Bubbles layout ([\#7612](matrix-org/matrix-react-sdk#7612)).
* Add customisation point for mxid display ([\#7595](matrix-org/matrix-react-sdk#7595)).
* Add labs flag for default open right panel ([\#7618](matrix-org/matrix-react-sdk#7618)). Fixes element-hq/element-web#20666.
* Tweak copy for the Sidebar tab in User Settings ([\#7578](matrix-org/matrix-react-sdk#7578)). Fixes element-hq/element-web#20619.
* Make widgets not reload (persistent) between center and top container  ([\#7575](matrix-org/matrix-react-sdk#7575)). Fixes element-hq/element-web#20596. Contributed by @toger5.
* Don't render a bubble around emotes in bubble layout ([\#7573](matrix-org/matrix-react-sdk#7573)). Fixes element-hq/element-web#20617.
* Add ability to switch between voice & video in calls ([\#7155](matrix-org/matrix-react-sdk#7155)). Fixes element-hq/element-web#18619. Contributed by @SimonBrandner.
* Re-renable Share option for location messages ([\#7596](matrix-org/matrix-react-sdk#7596)).
* Make room ID copyable ([\#7600](matrix-org/matrix-react-sdk#7600)). Fixes element-hq/element-web#20675. Contributed by @SimonBrandner.
* Improve the look of the keyboard settings tab ([\#7562](matrix-org/matrix-react-sdk#7562)). Contributed by @SimonBrandner.
* Add tooltips to emoji in messages ([\#7592](matrix-org/matrix-react-sdk#7592)). Fixes element-hq/element-web#9911 and element-hq/element-web#20661. Contributed by @robintown.
* Improve redundant tooltip on send button in forward dialog ([\#7594](matrix-org/matrix-react-sdk#7594)). Contributed by @twigleingrid.
* Allow downloads from widgets. ([\#7502](matrix-org/matrix-react-sdk#7502)). Contributed by @Fox32.
* Parse matrix-schemed URIs ([\#7453](matrix-org/matrix-react-sdk#7453)).
* Show a tile at beginning of visible history ([\#5887](matrix-org/matrix-react-sdk#5887)). Fixes element-hq/element-web#16818 element-hq/element-web#16679 and element-hq/element-web#19888. Contributed by @robintown.
* Enable the polls feature ([\#7581](matrix-org/matrix-react-sdk#7581)).
* Display general marker on non-self location shares ([\#7574](matrix-org/matrix-react-sdk#7574)).
* Improve/add notifications for location and poll events ([\#7552](matrix-org/matrix-react-sdk#7552)). Fixes element-hq/element-web#20561. Contributed by @SimonBrandner.
* Upgrade linkify to v3.0 ([\#7282](matrix-org/matrix-react-sdk#7282)). Fixes element-hq/element-web#17133 element-hq/element-web#16825 and element-hq/element-web#5808. Contributed by @Palid.
* Update sidebar icon from Compound ([\#7572](matrix-org/matrix-react-sdk#7572)). Fixes element-hq/element-web#20615.
* Replace home icon with new one ([\#7571](matrix-org/matrix-react-sdk#7571)). Fixes element-hq/element-web#20606.
* Make the `Keyboard Shortcuts` dialog into a settings tab ([\#7198](matrix-org/matrix-react-sdk#7198)). Fixes element-hq/element-web#19866. Contributed by @SimonBrandner.
* Add setting for enabling location sharing ([\#7547](matrix-org/matrix-react-sdk#7547)).
* Add a developer mode 'view source' button to crashed event tiles ([\#7537](matrix-org/matrix-react-sdk#7537)).
* Replace `kick` terminology with `Remove from chat` ([\#7469](matrix-org/matrix-react-sdk#7469)). Fixes element-hq/element-web#9547.
* Render events as extensible events (behind labs) ([\#7462](matrix-org/matrix-react-sdk#7462)).
* Render Jitsi (and other sticky widgets) in PiP container, so it can be dragged and the "jump to room functionality" is provided ([\#7450](matrix-org/matrix-react-sdk#7450)). Fixes element-hq/element-web#15682. Contributed by @toger5.
* Allow bubble layout in Thread View ([\#7478](matrix-org/matrix-react-sdk#7478)). Fixes element-hq/element-web#20419.
* Make LocationPicker appearance cleaner ([\#7516](matrix-org/matrix-react-sdk#7516)).
* Limit max-width for bubble layout to 1200px ([\#7458](matrix-org/matrix-react-sdk#7458)). Fixes element-hq/element-web#18072.
* Improve look of call events in bubble layout ([\#7445](matrix-org/matrix-react-sdk#7445)). Fixes element-hq/element-web#20324. Contributed by @SimonBrandner.
* Make files & voice memos in bubble layout match colouring ([\#7457](matrix-org/matrix-react-sdk#7457)). Fixes element-hq/element-web#20326.
* Allow cancelling events whilst they are encrypting ([\#7483](matrix-org/matrix-react-sdk#7483)). Fixes element-hq/element-web#17726.
* [Release] Fix left panel widgets causing app-wide crash ([\#7660](matrix-org/matrix-react-sdk#7660)).
* Load light theme prior to HTML export to ensure it is present ([\#7643](matrix-org/matrix-react-sdk#7643)). Fixes element-hq/element-web#20276.
* Fix soft-crash when hanging up Jitsi via PIP ([\#7645](matrix-org/matrix-react-sdk#7645)). Fixes element-hq/element-web#20766.
* Fix RightPanelStore assuming isViewingRoom is false on load ([\#7642](matrix-org/matrix-react-sdk#7642)).
* Correctly handle Room.timeline events which have a nullable `Room` ([\#7635](matrix-org/matrix-react-sdk#7635)). Fixes matrix-org/element-web-rageshakes#9490.
* Translate keyboard shortcut alternate key names ([\#7633](matrix-org/matrix-react-sdk#7633)). Fixes element-hq/element-web#20739.
* Fix unfocused paste handling and focus return for file uploads ([\#7625](matrix-org/matrix-react-sdk#7625)).
* Changed MacOS hotkey for GoToHome view. ([\#7631](matrix-org/matrix-react-sdk#7631)). Contributed by @aj-ya.
* Fix issue with the new composer EmojiPart which caused infinite loops ([\#7629](matrix-org/matrix-react-sdk#7629)). Fixes element-hq/element-web#20746.
* Upgrade linkifyjs to fix schemes as domain prefixes ([\#7628](matrix-org/matrix-react-sdk#7628)). Fixes element-hq/element-web#20720.
* Show bubble tile timestamps for bubble layout inside the bubble ([\#7622](matrix-org/matrix-react-sdk#7622)). Fixes element-hq/element-web#20562.
*  Improve taken username warning in registration for when request fails ([\#7621](matrix-org/matrix-react-sdk#7621)).
* Avoid double dialog after clicking to remove a public room ([\#7604](matrix-org/matrix-react-sdk#7604)). Fixes element-hq/element-web#20681. Contributed by @c-cal.
* Fix space member list right panel state ([\#7617](matrix-org/matrix-react-sdk#7617)). Fixes element-hq/element-web#20716.
* Fall back to legacy analytics for guest users ([\#7616](matrix-org/matrix-react-sdk#7616)).
* Always emit a space filter update when the space is actually changed ([\#7611](matrix-org/matrix-react-sdk#7611)). Fixes element-hq/element-web#20664.
* Enlarge emoji in composer ([\#7602](matrix-org/matrix-react-sdk#7602)). Fixes element-hq/element-web#20665 element-hq/element-web#15635 and element-hq/element-web#20688. Contributed by @robintown.
* Disable location sharing button on Desktop ([\#7590](matrix-org/matrix-react-sdk#7590)).
* Make pills more natural to navigate around ([\#7607](matrix-org/matrix-react-sdk#7607)). Fixes element-hq/element-web#20678. Contributed by @robintown.
* Fix excessive padding on inline images ([\#7605](matrix-org/matrix-react-sdk#7605)). Contributed by @robintown.
* Prevent pills from being split by formatting actions ([\#7606](matrix-org/matrix-react-sdk#7606)). Contributed by @robintown.
* Fix translation of "powerText" ([\#7603](matrix-org/matrix-react-sdk#7603)). Contributed by @c-cal.
* Unhide display names when switching back to modern layout ([\#7601](matrix-org/matrix-react-sdk#7601)). Fixes element-hq/element-web#20676. Contributed by @robintown.
* Fix space member list not opening ([\#7609](matrix-org/matrix-react-sdk#7609)). Fixes element-hq/element-web#20679. Contributed by @SimonBrandner.
* Fix translation for the "Add room" tooltip ([\#7532](matrix-org/matrix-react-sdk#7532)). Contributed by @c-cal.
* Make the close button of the location share dialog visible in high-contrast theme ([\#7597](matrix-org/matrix-react-sdk#7597)).
* Cancel pending events in virtual room when call placed ([\#7583](matrix-org/matrix-react-sdk#7583)). Fixes element-hq/element-web#17594.
* Fix alignment of unread badge in thread list ([\#7582](matrix-org/matrix-react-sdk#7582)). Fixes element-hq/element-web#20643.
* Fix left positioned tooltips being wrong and offset by fixed value ([\#7551](matrix-org/matrix-react-sdk#7551)).
* Fix MAB overlapping or overflowing in bubbles layout and threads regressions ([\#7569](matrix-org/matrix-react-sdk#7569)). Fixes element-hq/element-web#20403 and element-hq/element-web#20404.
* Fix wrong icon being used for appearance tab in space preferences dialog ([\#7570](matrix-org/matrix-react-sdk#7570)). Fixes element-hq/element-web#20608.
* Fix `/jumptodate` using wrong MSC feature flag ([\#7563](matrix-org/matrix-react-sdk#7563)).
* Ensure maps show up in replies and threads, by creating unique IDs ([\#7568](matrix-org/matrix-react-sdk#7568)).
* Differentiate between hover and roving focus in spotlight dialog ([\#7564](matrix-org/matrix-react-sdk#7564)). Fixes element-hq/element-web#20597.
* Fix timeline jumping issues related to bubble layout ([\#7529](matrix-org/matrix-react-sdk#7529)). Fixes element-hq/element-web#20302.
* Start a conference in a room with 2 people + invitee rather than a 1:1 call ([\#7557](matrix-org/matrix-react-sdk#7557)). Fixes element-hq/element-web#1202. Contributed by @SimonBrandner.
* Wait for initial profile load before displaying widget ([\#7556](matrix-org/matrix-react-sdk#7556)).
* Make widgets and calls span across the whole room width when using bubble layout ([\#7553](matrix-org/matrix-react-sdk#7553)). Fixes element-hq/element-web#20560. Contributed by @SimonBrandner.
* Always show right panel after setting a card ([\#7544](matrix-org/matrix-react-sdk#7544)). Contributed by @toger5.
* Support deserialising HR tags for editing ([\#7543](matrix-org/matrix-react-sdk#7543)). Fixes element-hq/element-web#20553.
* Refresh ThreadView after React state has been updated ([\#7539](matrix-org/matrix-react-sdk#7539)). Fixes element-hq/element-web#20549.
* Set initial zoom level to 1 to make zooming to location faster ([\#7541](matrix-org/matrix-react-sdk#7541)).
* truncate room name on pip header ([\#7538](matrix-org/matrix-react-sdk#7538)).
* Prevent enter to send edit weirdness when no change has been made ([\#7522](matrix-org/matrix-react-sdk#7522)). Fixes element-hq/element-web#20507.
* Allow using room pills in slash commands ([\#7513](matrix-org/matrix-react-sdk#7513)). Fixes element-hq/element-web#20343.
su-ex added a commit to SchildiChat/element-web that referenced this issue Jan 31, 2022
@su-ex
Merge tag 'v1.10.0' into sc
7e5824c 
* Tweak room list header menu for when space is active ([\element-hq#7577](matrix-org/matrix-react-sdk#7577)). Fixes element-hq#20601.
* Tweak light hover & active color for bubble layout ([\element-hq#7626](matrix-org/matrix-react-sdk#7626)). Fixes element-hq#19475.
* De-labs Metaspaces ([\element-hq#7613](matrix-org/matrix-react-sdk#7613)).
* De-labs Message Bubbles layout ([\element-hq#7612](matrix-org/matrix-react-sdk#7612)).
* Add customisation point for mxid display ([\element-hq#7595](matrix-org/matrix-react-sdk#7595)).
* Add labs flag for default open right panel ([\element-hq#7618](matrix-org/matrix-react-sdk#7618)). Fixes element-hq#20666.
* Tweak copy for the Sidebar tab in User Settings ([\element-hq#7578](matrix-org/matrix-react-sdk#7578)). Fixes element-hq#20619.
* Make widgets not reload (persistent) between center and top container  ([\element-hq#7575](matrix-org/matrix-react-sdk#7575)). Fixes element-hq#20596. Contributed by @toger5.
* Don't render a bubble around emotes in bubble layout ([\element-hq#7573](matrix-org/matrix-react-sdk#7573)). Fixes element-hq#20617.
* Add ability to switch between voice & video in calls ([\element-hq#7155](matrix-org/matrix-react-sdk#7155)). Fixes element-hq#18619. Contributed by @SimonBrandner.
* Re-renable Share option for location messages ([\element-hq#7596](matrix-org/matrix-react-sdk#7596)).
* Make room ID copyable ([\element-hq#7600](matrix-org/matrix-react-sdk#7600)). Fixes element-hq#20675. Contributed by @SimonBrandner.
* Improve the look of the keyboard settings tab ([\element-hq#7562](matrix-org/matrix-react-sdk#7562)). Contributed by @SimonBrandner.
* Add tooltips to emoji in messages ([\element-hq#7592](matrix-org/matrix-react-sdk#7592)). Fixes element-hq#9911 and element-hq#20661. Contributed by @robintown.
* Improve redundant tooltip on send button in forward dialog ([\element-hq#7594](matrix-org/matrix-react-sdk#7594)). Contributed by @twigleingrid.
* Allow downloads from widgets. ([\element-hq#7502](matrix-org/matrix-react-sdk#7502)). Contributed by @Fox32.
* Parse matrix-schemed URIs ([\element-hq#7453](matrix-org/matrix-react-sdk#7453)).
* Show a tile at beginning of visible history ([\element-hq#5887](matrix-org/matrix-react-sdk#5887)). Fixes element-hq#16818 element-hq#16679 and element-hq#19888. Contributed by @robintown.
* Enable the polls feature ([\element-hq#7581](matrix-org/matrix-react-sdk#7581)).
* Display general marker on non-self location shares ([\element-hq#7574](matrix-org/matrix-react-sdk#7574)).
* Improve/add notifications for location and poll events ([\element-hq#7552](matrix-org/matrix-react-sdk#7552)). Fixes element-hq#20561. Contributed by @SimonBrandner.
* Upgrade linkify to v3.0 ([\element-hq#7282](matrix-org/matrix-react-sdk#7282)). Fixes element-hq#17133 element-hq#16825 and element-hq#5808. Contributed by @Palid.
* Update sidebar icon from Compound ([\element-hq#7572](matrix-org/matrix-react-sdk#7572)). Fixes element-hq#20615.
* Replace home icon with new one ([\element-hq#7571](matrix-org/matrix-react-sdk#7571)). Fixes element-hq#20606.
* Make the `Keyboard Shortcuts` dialog into a settings tab ([\element-hq#7198](matrix-org/matrix-react-sdk#7198)). Fixes element-hq#19866. Contributed by @SimonBrandner.
* Add setting for enabling location sharing ([\element-hq#7547](matrix-org/matrix-react-sdk#7547)).
* Add a developer mode 'view source' button to crashed event tiles ([\element-hq#7537](matrix-org/matrix-react-sdk#7537)).
* Replace `kick` terminology with `Remove from chat` ([\element-hq#7469](matrix-org/matrix-react-sdk#7469)). Fixes element-hq#9547.
* Render events as extensible events (behind labs) ([\element-hq#7462](matrix-org/matrix-react-sdk#7462)).
* Render Jitsi (and other sticky widgets) in PiP container, so it can be dragged and the "jump to room functionality" is provided ([\element-hq#7450](matrix-org/matrix-react-sdk#7450)). Fixes element-hq#15682. Contributed by @toger5.
* Allow bubble layout in Thread View ([\element-hq#7478](matrix-org/matrix-react-sdk#7478)). Fixes element-hq#20419.
* Make LocationPicker appearance cleaner ([\element-hq#7516](matrix-org/matrix-react-sdk#7516)).
* Limit max-width for bubble layout to 1200px ([\element-hq#7458](matrix-org/matrix-react-sdk#7458)). Fixes element-hq#18072.
* Improve look of call events in bubble layout ([\element-hq#7445](matrix-org/matrix-react-sdk#7445)). Fixes element-hq#20324. Contributed by @SimonBrandner.
* Make files & voice memos in bubble layout match colouring ([\element-hq#7457](matrix-org/matrix-react-sdk#7457)). Fixes element-hq#20326.
* Allow cancelling events whilst they are encrypting ([\element-hq#7483](matrix-org/matrix-react-sdk#7483)). Fixes element-hq#17726.
* [Release] Fix left panel widgets causing app-wide crash ([\element-hq#7660](matrix-org/matrix-react-sdk#7660)).
* Load light theme prior to HTML export to ensure it is present ([\element-hq#7643](matrix-org/matrix-react-sdk#7643)). Fixes element-hq#20276.
* Fix soft-crash when hanging up Jitsi via PIP ([\element-hq#7645](matrix-org/matrix-react-sdk#7645)). Fixes element-hq#20766.
* Fix RightPanelStore assuming isViewingRoom is false on load ([\element-hq#7642](matrix-org/matrix-react-sdk#7642)).
* Correctly handle Room.timeline events which have a nullable `Room` ([\element-hq#7635](matrix-org/matrix-react-sdk#7635)). Fixes matrix-org/element-web-rageshakes#9490.
* Translate keyboard shortcut alternate key names ([\element-hq#7633](matrix-org/matrix-react-sdk#7633)). Fixes element-hq#20739.
* Fix unfocused paste handling and focus return for file uploads ([\element-hq#7625](matrix-org/matrix-react-sdk#7625)).
* Changed MacOS hotkey for GoToHome view. ([\#7631](matrix-org/matrix-react-sdk#7631)). Contributed by @aj-ya.
* Fix issue with the new composer EmojiPart which caused infinite loops ([\element-hq#7629](matrix-org/matrix-react-sdk#7629)). Fixes element-hq#20746.
* Upgrade linkifyjs to fix schemes as domain prefixes ([\element-hq#7628](matrix-org/matrix-react-sdk#7628)). Fixes element-hq#20720.
* Show bubble tile timestamps for bubble layout inside the bubble ([\element-hq#7622](matrix-org/matrix-react-sdk#7622)). Fixes element-hq#20562.
*  Improve taken username warning in registration for when request fails ([\element-hq#7621](matrix-org/matrix-react-sdk#7621)).
* Avoid double dialog after clicking to remove a public room ([\element-hq#7604](matrix-org/matrix-react-sdk#7604)). Fixes element-hq#20681. Contributed by @c-cal.
* Fix space member list right panel state ([\element-hq#7617](matrix-org/matrix-react-sdk#7617)). Fixes element-hq#20716.
* Fall back to legacy analytics for guest users ([\#7616](matrix-org/matrix-react-sdk#7616)).
* Always emit a space filter update when the space is actually changed ([\element-hq#7611](matrix-org/matrix-react-sdk#7611)). Fixes element-hq#20664.
* Enlarge emoji in composer ([\element-hq#7602](matrix-org/matrix-react-sdk#7602)). Fixes element-hq#20665 element-hq#15635 and element-hq#20688. Contributed by @robintown.
* Disable location sharing button on Desktop ([\element-hq#7590](matrix-org/matrix-react-sdk#7590)).
* Make pills more natural to navigate around ([\element-hq#7607](matrix-org/matrix-react-sdk#7607)). Fixes element-hq#20678. Contributed by @robintown.
* Fix excessive padding on inline images ([\element-hq#7605](matrix-org/matrix-react-sdk#7605)). Contributed by @robintown.
* Prevent pills from being split by formatting actions ([\element-hq#7606](matrix-org/matrix-react-sdk#7606)). Contributed by @robintown.
* Fix translation of "powerText" ([\element-hq#7603](matrix-org/matrix-react-sdk#7603)). Contributed by @c-cal.
* Unhide display names when switching back to modern layout ([\element-hq#7601](matrix-org/matrix-react-sdk#7601)). Fixes element-hq#20676. Contributed by @robintown.
* Fix space member list not opening ([\element-hq#7609](matrix-org/matrix-react-sdk#7609)). Fixes element-hq#20679. Contributed by @SimonBrandner.
* Fix translation for the "Add room" tooltip ([\element-hq#7532](matrix-org/matrix-react-sdk#7532)). Contributed by @c-cal.
* Make the close button of the location share dialog visible in high-contrast theme ([\element-hq#7597](matrix-org/matrix-react-sdk#7597)).
* Cancel pending events in virtual room when call placed ([\element-hq#7583](matrix-org/matrix-react-sdk#7583)). Fixes element-hq#17594.
* Fix alignment of unread badge in thread list ([\element-hq#7582](matrix-org/matrix-react-sdk#7582)). Fixes element-hq#20643.
* Fix left positioned tooltips being wrong and offset by fixed value ([\element-hq#7551](matrix-org/matrix-react-sdk#7551)).
* Fix MAB overlapping or overflowing in bubbles layout and threads regressions ([\element-hq#7569](matrix-org/matrix-react-sdk#7569)). Fixes element-hq#20403 and element-hq#20404.
* Fix wrong icon being used for appearance tab in space preferences dialog ([\element-hq#7570](matrix-org/matrix-react-sdk#7570)). Fixes element-hq#20608.
* Fix `/jumptodate` using wrong MSC feature flag ([\element-hq#7563](matrix-org/matrix-react-sdk#7563)).
* Ensure maps show up in replies and threads, by creating unique IDs ([\element-hq#7568](matrix-org/matrix-react-sdk#7568)).
* Differentiate between hover and roving focus in spotlight dialog ([\element-hq#7564](matrix-org/matrix-react-sdk#7564)). Fixes element-hq#20597.
* Fix timeline jumping issues related to bubble layout ([\element-hq#7529](matrix-org/matrix-react-sdk#7529)). Fixes element-hq#20302.
* Start a conference in a room with 2 people + invitee rather than a 1:1 call ([\element-hq#7557](matrix-org/matrix-react-sdk#7557)). Fixes element-hq#1202. Contributed by @SimonBrandner.
* Wait for initial profile load before displaying widget ([\element-hq#7556](matrix-org/matrix-react-sdk#7556)).
* Make widgets and calls span across the whole room width when using bubble layout ([\element-hq#7553](matrix-org/matrix-react-sdk#7553)). Fixes element-hq#20560. Contributed by @SimonBrandner.
* Always show right panel after setting a card ([\element-hq#7544](matrix-org/matrix-react-sdk#7544)). Contributed by @toger5.
* Support deserialising HR tags for editing ([\element-hq#7543](matrix-org/matrix-react-sdk#7543)). Fixes element-hq#20553.
* Refresh ThreadView after React state has been updated ([\element-hq#7539](matrix-org/matrix-react-sdk#7539)). Fixes element-hq#20549.
* Set initial zoom level to 1 to make zooming to location faster ([\element-hq#7541](matrix-org/matrix-react-sdk#7541)).
* truncate room name on pip header ([\#7538](matrix-org/matrix-react-sdk#7538)).
* Prevent enter to send edit weirdness when no change has been made ([\element-hq#7522](matrix-org/matrix-react-sdk#7522)). Fixes element-hq#20507.
* Allow using room pills in slash commands ([\element-hq#7513](matrix-org/matrix-react-sdk#7513)). Fixes element-hq#20343.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Jan 31, 2022
@su-ex
Merge tag 'v3.39.0' into sc
4c5818e 
* Tweak room list header menu for when space is active ([\matrix-org#7577](matrix-org#7577)). Fixes element-hq/element-web#20601.
* Tweak light hover & active color for bubble layout ([\matrix-org#7626](matrix-org#7626)). Fixes element-hq/element-web#19475.
* De-labs Metaspaces ([\matrix-org#7613](matrix-org#7613)).
* De-labs Message Bubbles layout ([\matrix-org#7612](matrix-org#7612)).
* Add customisation point for mxid display ([\matrix-org#7595](matrix-org#7595)).
* Add labs flag for default open right panel ([\matrix-org#7618](matrix-org#7618)). Fixes element-hq/element-web#20666.
* Tweak copy for the Sidebar tab in User Settings ([\matrix-org#7578](matrix-org#7578)). Fixes element-hq/element-web#20619.
* Make widgets not reload (persistent) between center and top container  ([\matrix-org#7575](matrix-org#7575)). Fixes element-hq/element-web#20596. Contributed by @toger5.
* Don't render a bubble around emotes in bubble layout ([\matrix-org#7573](matrix-org#7573)). Fixes element-hq/element-web#20617.
* Add ability to switch between voice & video in calls ([\matrix-org#7155](matrix-org#7155)). Fixes element-hq/element-web#18619. Contributed by @SimonBrandner.
* Re-renable Share option for location messages ([\matrix-org#7596](matrix-org#7596)).
* Make room ID copyable ([\matrix-org#7600](matrix-org#7600)). Fixes element-hq/element-web#20675. Contributed by @SimonBrandner.
* Improve the look of the keyboard settings tab ([\matrix-org#7562](matrix-org#7562)). Contributed by @SimonBrandner.
* Add tooltips to emoji in messages ([\matrix-org#7592](matrix-org#7592)). Fixes element-hq/element-web#9911 and element-hq/element-web#20661. Contributed by @robintown.
* Improve redundant tooltip on send button in forward dialog ([\matrix-org#7594](matrix-org#7594)). Contributed by @twigleingrid.
* Allow downloads from widgets. ([\matrix-org#7502](matrix-org#7502)). Contributed by @Fox32.
* Parse matrix-schemed URIs ([\matrix-org#7453](matrix-org#7453)).
* Show a tile at beginning of visible history ([\matrix-org#5887](matrix-org#5887)). Fixes element-hq/element-web#16818 element-hq/element-web#16679 and element-hq/element-web#19888. Contributed by @robintown.
* Enable the polls feature ([\matrix-org#7581](matrix-org#7581)).
* Display general marker on non-self location shares ([\matrix-org#7574](matrix-org#7574)).
* Improve/add notifications for location and poll events ([\matrix-org#7552](matrix-org#7552)). Fixes element-hq/element-web#20561. Contributed by @SimonBrandner.
* Upgrade linkify to v3.0 ([\matrix-org#7282](matrix-org#7282)). Fixes element-hq/element-web#17133 element-hq/element-web#16825 and element-hq/element-web#5808. Contributed by @Palid.
* Update sidebar icon from Compound ([\matrix-org#7572](matrix-org#7572)). Fixes element-hq/element-web#20615.
* Replace home icon with new one ([\matrix-org#7571](matrix-org#7571)). Fixes element-hq/element-web#20606.
* Make the `Keyboard Shortcuts` dialog into a settings tab ([\matrix-org#7198](matrix-org#7198)). Fixes element-hq/element-web#19866. Contributed by @SimonBrandner.
* Add setting for enabling location sharing ([\matrix-org#7547](matrix-org#7547)).
* Add a developer mode 'view source' button to crashed event tiles ([\matrix-org#7537](matrix-org#7537)).
* Replace `kick` terminology with `Remove from chat` ([\matrix-org#7469](matrix-org#7469)). Fixes element-hq/element-web#9547.
* Render events as extensible events (behind labs) ([\matrix-org#7462](matrix-org#7462)).
* Render Jitsi (and other sticky widgets) in PiP container, so it can be dragged and the "jump to room functionality" is provided ([\matrix-org#7450](matrix-org#7450)). Fixes element-hq/element-web#15682. Contributed by @toger5.
* Allow bubble layout in Thread View ([\matrix-org#7478](matrix-org#7478)). Fixes element-hq/element-web#20419.
* Make LocationPicker appearance cleaner ([\matrix-org#7516](matrix-org#7516)).
* Limit max-width for bubble layout to 1200px ([\matrix-org#7458](matrix-org#7458)). Fixes element-hq/element-web#18072.
* Improve look of call events in bubble layout ([\matrix-org#7445](matrix-org#7445)). Fixes element-hq/element-web#20324. Contributed by @SimonBrandner.
* Make files & voice memos in bubble layout match colouring ([\matrix-org#7457](matrix-org#7457)). Fixes element-hq/element-web#20326.
* Allow cancelling events whilst they are encrypting ([\matrix-org#7483](matrix-org#7483)). Fixes element-hq/element-web#17726.
* [Release] Fix left panel widgets causing app-wide crash ([\matrix-org#7660](matrix-org#7660)).
* Load light theme prior to HTML export to ensure it is present ([\matrix-org#7643](matrix-org#7643)). Fixes element-hq/element-web#20276.
* Fix soft-crash when hanging up Jitsi via PIP ([\matrix-org#7645](matrix-org#7645)). Fixes element-hq/element-web#20766.
* Fix RightPanelStore assuming isViewingRoom is false on load ([\matrix-org#7642](matrix-org#7642)).
* Correctly handle Room.timeline events which have a nullable `Room` ([\matrix-org#7635](matrix-org#7635)). Fixes matrix-org/element-web-rageshakes#9490.
* Translate keyboard shortcut alternate key names ([\matrix-org#7633](matrix-org#7633)). Fixes element-hq/element-web#20739.
* Fix unfocused paste handling and focus return for file uploads ([\matrix-org#7625](matrix-org#7625)).
* Changed MacOS hotkey for GoToHome view. ([\matrix-org#7631](matrix-org#7631)). Contributed by @aj-ya.
* Fix issue with the new composer EmojiPart which caused infinite loops ([\matrix-org#7629](matrix-org#7629)). Fixes element-hq/element-web#20746.
* Upgrade linkifyjs to fix schemes as domain prefixes ([\matrix-org#7628](matrix-org#7628)). Fixes element-hq/element-web#20720.
* Show bubble tile timestamps for bubble layout inside the bubble ([\matrix-org#7622](matrix-org#7622)). Fixes element-hq/element-web#20562.
*  Improve taken username warning in registration for when request fails ([\matrix-org#7621](matrix-org#7621)).
* Avoid double dialog after clicking to remove a public room ([\matrix-org#7604](matrix-org#7604)). Fixes element-hq/element-web#20681. Contributed by @c-cal.
* Fix space member list right panel state ([\matrix-org#7617](matrix-org#7617)). Fixes element-hq/element-web#20716.
* Fall back to legacy analytics for guest users ([\matrix-org#7616](matrix-org#7616)).
* Always emit a space filter update when the space is actually changed ([\matrix-org#7611](matrix-org#7611)). Fixes element-hq/element-web#20664.
* Enlarge emoji in composer ([\matrix-org#7602](matrix-org#7602)). Fixes element-hq/element-web#20665 element-hq/element-web#15635 and element-hq/element-web#20688. Contributed by @robintown.
* Disable location sharing button on Desktop ([\matrix-org#7590](matrix-org#7590)).
* Make pills more natural to navigate around ([\matrix-org#7607](matrix-org#7607)). Fixes element-hq/element-web#20678. Contributed by @robintown.
* Fix excessive padding on inline images ([\matrix-org#7605](matrix-org#7605)). Contributed by @robintown.
* Prevent pills from being split by formatting actions ([\matrix-org#7606](matrix-org#7606)). Contributed by @robintown.
* Fix translation of "powerText" ([\matrix-org#7603](matrix-org#7603)). Contributed by @c-cal.
* Unhide display names when switching back to modern layout ([\matrix-org#7601](matrix-org#7601)). Fixes element-hq/element-web#20676. Contributed by @robintown.
* Fix space member list not opening ([\matrix-org#7609](matrix-org#7609)). Fixes element-hq/element-web#20679. Contributed by @SimonBrandner.
* Fix translation for the "Add room" tooltip ([\matrix-org#7532](matrix-org#7532)). Contributed by @c-cal.
* Make the close button of the location share dialog visible in high-contrast theme ([\matrix-org#7597](matrix-org#7597)).
* Cancel pending events in virtual room when call placed ([\matrix-org#7583](matrix-org#7583)). Fixes element-hq/element-web#17594.
* Fix alignment of unread badge in thread list ([\matrix-org#7582](matrix-org#7582)). Fixes element-hq/element-web#20643.
* Fix left positioned tooltips being wrong and offset by fixed value ([\matrix-org#7551](matrix-org#7551)).
* Fix MAB overlapping or overflowing in bubbles layout and threads regressions ([\matrix-org#7569](matrix-org#7569)). Fixes element-hq/element-web#20403 and element-hq/element-web#20404.
* Fix wrong icon being used for appearance tab in space preferences dialog ([\matrix-org#7570](matrix-org#7570)). Fixes element-hq/element-web#20608.
* Fix `/jumptodate` using wrong MSC feature flag ([\matrix-org#7563](matrix-org#7563)).
* Ensure maps show up in replies and threads, by creating unique IDs ([\matrix-org#7568](matrix-org#7568)).
* Differentiate between hover and roving focus in spotlight dialog ([\matrix-org#7564](matrix-org#7564)). Fixes element-hq/element-web#20597.
* Fix timeline jumping issues related to bubble layout ([\matrix-org#7529](matrix-org#7529)). Fixes element-hq/element-web#20302.
* Start a conference in a room with 2 people + invitee rather than a 1:1 call ([\matrix-org#7557](matrix-org#7557)). Fixes element-hq/element-web#1202. Contributed by @SimonBrandner.
* Wait for initial profile load before displaying widget ([\matrix-org#7556](matrix-org#7556)).
* Make widgets and calls span across the whole room width when using bubble layout ([\matrix-org#7553](matrix-org#7553)). Fixes element-hq/element-web#20560. Contributed by @SimonBrandner.
* Always show right panel after setting a card ([\matrix-org#7544](matrix-org#7544)). Contributed by @toger5.
* Support deserialising HR tags for editing ([\matrix-org#7543](matrix-org#7543)). Fixes element-hq/element-web#20553.
* Refresh ThreadView after React state has been updated ([\matrix-org#7539](matrix-org#7539)). Fixes element-hq/element-web#20549.
* Set initial zoom level to 1 to make zooming to location faster ([\matrix-org#7541](matrix-org#7541)).
* truncate room name on pip header ([\matrix-org#7538](matrix-org#7538)).
* Prevent enter to send edit weirdness when no change has been made ([\matrix-org#7522](matrix-org#7522)). Fixes element-hq/element-web#20507.
* Allow using room pills in slash commands ([\matrix-org#7513](matrix-org#7513)). Fixes element-hq/element-web#20343.
@SimonBrandner SimonBrandner added the A-Element-Call Group calls via Element Call label Aug 10, 2022
@SimonBrandner
Copy link
Contributor

Will be fixed by Element Call

@t3chguy
Copy link
Member

t3chguy commented Dec 4, 2024

Fixed by Jitsi/EC

@t3chguy t3chguy closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-Call Group calls via Element Call A-Jitsi A-VoIP O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
No milestone
6 participants
@kittykat @MadLittleMods @dbkr @ara4n @t3chguy @SimonBrandner