Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceBroadcast: Play a sound to notify the user when VB is pause due to an error. #7534

Merged
merged 1 commit into from
May 4, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented May 3, 2023

This PR implements the change requested in #7504

@nimau nimau requested a review from yostyle May 3, 2023 12:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (379e8e2) 12.22% compared to head (524cbcc) 12.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7534      +/-   ##
===========================================
- Coverage    12.22%   12.22%   -0.01%     
===========================================
  Files         1646     1646              
  Lines       163363   163392      +29     
  Branches     67063    67077      +14     
===========================================
  Hits         19968    19968              
- Misses      142752   142781      +29     
  Partials       643      643              
Flag Coverage Δ
uitests 55.06% <ø> (ø)
unittests 6.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle requested a review from giomfo May 3, 2023 15:48
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok

@nimau nimau merged commit b5f4e37 into develop May 4, 2023
@nimau nimau deleted the nimau/7504_VB_audio_alert_lost_connectivity branch May 4, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants