Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MSC3906 v2 #7407

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Support for MSC3906 v2 #7407

merged 2 commits into from
Apr 1, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Mar 6, 2023

This PR adds support for v2 of MSC3906 which is used for Sign in with QR.

Both v1 and v2 are supported so compatibility is maintained.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

Signed-off-by: Hugh Nimmo-Smith [email protected]

@hughns hughns changed the title Support for v2 of MSC3906 Support for MSC3906 v2 Mar 6, 2023
@hughns hughns force-pushed the hughns/msc3906-v2 branch from c0eb134 to 03f9563 Compare March 6, 2023 19:09
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 15.78% and no project coverage change.

Comparison is base (e0d6d1e) 12.13% compared to head (014f896) 12.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7407   +/-   ##
========================================
  Coverage    12.13%   12.13%           
========================================
  Files         1643     1643           
  Lines       162545   162557   +12     
  Branches     66743    66752    +9     
========================================
+ Hits         19727    19729    +2     
- Misses      142173   142183   +10     
  Partials       645      645           
Flag Coverage Δ
uitests 55.24% <100.00%> (+<0.01%) ⬆️
unittests 6.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Rendezvous/RendezvousService.swift 77.77% <ø> (ø)
...ogin/Common/Service/MatrixSDK/QRLoginService.swift 6.88% <0.00%> (-0.20%) ⬇️
...Login/Common/Service/Mock/MockQRLoginService.swift 51.11% <100.00%> (+2.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hughns hughns marked this pull request as ready for review March 9, 2023 20:18
@hughns hughns requested a review from stefanceriu March 9, 2023 20:18
@hughns hughns force-pushed the hughns/msc3906-v2 branch from a73748b to 014f896 Compare March 9, 2023 20:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@hughns hughns merged commit 54800f3 into develop Apr 1, 2023
@hughns hughns deleted the hughns/msc3906-v2 branch April 1, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants