Direct Message: manage encrypted DM in case of invite by email #7396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don’t allow to invite more than one contact by email - The DM will be created by enabling the encryption when the HS promotes the encryption - The chat composer is disabled until a matrix account is created by using the invited email
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7396 +/- ##
===========================================
- Coverage 12.15% 12.14% -0.02%
===========================================
Files 1643 1644 +1
Lines 162265 162550 +285
Branches 66630 66766 +136
===========================================
+ Hits 19729 19741 +12
- Misses 141890 142164 +274
+ Partials 646 645 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
|
@nimau I'm currently testing your PR, I observed a pb:
|
giomfo
reviewed
Feb 28, 2023
|
@giom I have updated this PR to reflect your comments. |
|
Kudos, SonarCloud Quality Gate passed!
|
giomfo
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6612
Here is a summary of the changes:
This PR is related to matrix-ios-sdk PR #1727