Improve error handling during a voice broadcast playback #7321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 12.02% // Head: 12.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #7321 +/- ##
========================================
Coverage 12.02% 12.02%
========================================
Files 1630 1630
Lines 161272 161272
Branches 66073 66073
========================================
Hits 19391 19391
Misses 141237 141237
Partials 644 644
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
giomfo
approved these changes
Feb 1, 2023
| @@ -531,11 +579,16 @@ extension VoiceBroadcastPlaybackViewModel: VoiceMessageAudioPlayerDelegate { | |||
|
|
|||
| func audioPlayer(_ audioPlayer: VoiceMessageAudioPlayer, didFailWithError error: Error) { | |||
| state.playbackState = .error | |||
| self.updateErrorState() | |||
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7311 by pausing the voice broadcast playback if an error occurs. Also, the error is only displayed when playback stops.