-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform the user about decryption errors during a voice broadcast #7302
Conversation
Codecov ReportBase: 11.99% // Head: 11.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7302 +/- ##
========================================
Coverage 11.99% 11.99%
========================================
Files 1632 1629 -3
Lines 161153 161119 -34
Branches 65958 65955 -3
========================================
+ Hits 19330 19333 +3
+ Misses 141178 141142 -36
+ Partials 645 644 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, just one remark and one question
RiotSwiftUI/Modules/Room/VoiceBroadcastPlayback/VoiceBroadcastPlaybackScreenState.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one remark
changelog.d/7189.change
Outdated
@@ -0,0 +1 @@ | |||
Voice Broadcast: Inform the user about decryption errors during a voice broadcast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could remove Voice Broadcast:
the description is explicit IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Kudos, SonarCloud Quality Gate passed! |
Fixes #7189
If a decryption error occurs during a voice broadcast: