Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the user about decryption errors during a voice broadcast #7302

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jan 26, 2023

Fixes #7189

If a decryption error occurs during a voice broadcast:

  • don't display an entry for the encrypted chunk in the room
  • pause the voice broadcast playback and show an error in the cell until there is a decryption error
    chunk_decryption_error

@nimau nimau requested a review from giomfo January 26, 2023 08:25
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 11.99% // Head: 11.99% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c0e5697) compared to base (971a9f0).
Patch coverage: 4.05% of modified lines in pull request are covered.

❗ Current head c0e5697 differs from pull request most recent head cfe166b. Consider uploading reports for the commit cfe166b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7302   +/-   ##
========================================
  Coverage    11.99%   11.99%           
========================================
  Files         1632     1629    -3     
  Lines       161153   161119   -34     
  Branches     65958    65955    -3     
========================================
+ Hits         19330    19333    +3     
+ Misses      141178   141142   -36     
+ Partials       645      644    -1     
Flag Coverage Δ
uitests 55.53% <10.34%> (+0.22%) ⬆️
unittests 5.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 17.07% <0.00%> (-0.04%) ⬇️
...t/VoiceBroadcastSDK/VoiceBroadcastAggregator.swift 0.00% <0.00%> (ø)
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)
...ew/VoiceBroadcastPlaybackDecryptionErrorView.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...stPlayback/VoiceBroadcastPlaybackScreenState.swift 100.00% <100.00%> (ø)
...m/AllChatsOnboarding/View/AllChatsOnboarding.swift
...lChatsOnboarding/AllChatsOnboardingViewModel.swift
...lChatsOnboarding/View/AllChatsOnboardingPage.swift
.../AllChatsOnboarding/AllChatsOnboardingModels.swift
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau marked this pull request as ready for review January 27, 2023 14:27
@nimau nimau added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Voice-Broadcast labels Jan 27, 2023
@nimau nimau requested a review from phloux January 27, 2023 14:42
Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, just one remark and one question

@nimau nimau requested review from yostyle and giomfo January 30, 2023 15:40
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one remark

@@ -0,0 +1 @@
Voice Broadcast: Inform the user about decryption errors during a voice broadcast.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove Voice Broadcast:the description is explicit IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nimau nimau merged commit 13698ee into develop Jan 31, 2023
@nimau nimau deleted the nimau/7189_vb_decryption_error branch January 31, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Broadcast T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let the user know when we are not able to decrypt the voice broadcast chunks
4 participants