Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs: Rich-text editor - Fix text formatting switch losing the current content of the composer #7055

Merged

Conversation

aringenbach
Copy link
Contributor

Fixes #7054

@aringenbach aringenbach requested review from a team and Anderas and removed request for a team November 9, 2022 10:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 11.72% // Head: 11.81% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (46c3dc4) compared to base (2184f1f).
Patch coverage: 76.11% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7055      +/-   ##
===========================================
+ Coverage    11.72%   11.81%   +0.08%     
===========================================
  Files         1613     1613              
  Lines       158529   158430      -99     
  Branches     64369    64341      -28     
===========================================
+ Hits         18589    18712     +123     
+ Misses      139305   139082     -223     
- Partials       635      636       +1     
Flag Coverage Δ
uitests 54.60% <76.11%> (+0.12%) ⬆️
unittests 6.08% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 84.39% <76.11%> (+3.49%) ⬆️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.51% <0.00%> (+0.38%) ⬆️
...UserSessions/Common/View/UserSessionCardView.swift 53.23% <0.00%> (+1.58%) ⬆️
...herSessions/MockUserOtherSessionsScreenState.swift 100.00% <0.00%> (+2.90%) ⬆️
...view/View/UserSessionListItemViewDataFactory.swift 92.53% <0.00%> (+5.21%) ⬆️
...SessionOverview/UserSessionOverviewViewModel.swift 61.53% <0.00%> (+8.01%) ⬆️
...odules/Room/Composer/MockComposerScreenState.swift 93.33% <0.00%> (+8.88%) ⬆️
...Sessions/Common/View/UserSessionCardViewData.swift 86.84% <0.00%> (+11.54%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aringenbach aringenbach merged commit c7824e2 into develop Nov 10, 2022
@aringenbach aringenbach deleted the aringenbach/7054_fix_lost_content_text_formatting_switch branch November 10, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labs: Rich-text editor: content is lost when switching from/to plain text mode
2 participants