Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing accessibility labels on All Chats buttons. #6760

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

pixlwave
Copy link
Member

The User Menu and Spaces buttons were just described as "Button".

Part of #6580, but doesn't close it as the spaces sheet needs more work to properly define accessibility elements and test across iOS 14-16.

@pixlwave pixlwave requested review from a team and aringenbach and removed request for a team September 23, 2022 15:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aFJ9R6

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 10.52% // Head: 10.01% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (05db031) compared to base (26665fd).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 05db031 differs from pull request most recent head aaf4d86. Consider uploading reports for the commit aaf4d86 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6760      +/-   ##
===========================================
- Coverage    10.52%   10.01%   -0.52%     
===========================================
  Files         1501     1490      -11     
  Lines       151352   150811     -541     
  Branches     61078    60859     -219     
===========================================
- Hits         15934    15104     -830     
- Misses      134849   135159     +310     
+ Partials       569      548      -21     
Impacted Files Coverage Δ
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 22.15% <100.00%> (+0.11%) ⬆️
...Modules/Home/AllChats/AllChatsViewController.swift 28.74% <100.00%> (+0.39%) ⬆️
...erSessionsOverview/View/UserSessionsOverview.swift 0.00% <0.00%> (-87.28%) ⬇️
...ervice/MatrixSDK/UserSessionsOverviewService.swift 0.00% <0.00%> (-85.44%) ⬇️
...serSessionsOverview/View/UserSessionListItem.swift 0.00% <0.00%> (-58.00%) ⬇️
...otSwiftUI/Modules/Common/Util/BorderModifier.swift 57.14% <0.00%> (-42.86%) ⬇️
...calAuthentication/LocalAuthenticationService.swift 27.27% <0.00%> (-27.28%) ⬇️
...ssionsOverview/UserSessionsOverviewViewModel.swift 46.47% <0.00%> (-25.40%) ⬇️
...mUpgrade/Service/Mock/MockRoomUpgradeService.swift 70.00% <0.00%> (-17.50%) ⬇️
...onsOverview/View/UserSessionListItemViewData.swift 84.84% <0.00%> (-15.16%) ⬇️
... and 385 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave force-pushed the doug/all-chats-voiceover branch from 05db031 to aaf4d86 Compare October 3, 2022 11:05
@pixlwave pixlwave merged commit b3e9b83 into develop Oct 3, 2022
@pixlwave pixlwave deleted the doug/all-chats-voiceover branch October 3, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants