Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Layout: Add usage measures #6619

Merged
merged 5 commits into from
Aug 24, 2022
Merged

App Layout: Add usage measures #6619

merged 5 commits into from
Aug 24, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6618

@gileluard gileluard requested a review from stefanceriu August 24, 2022 07:55
stefanceriu
stefanceriu approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments otherwise lgtm 👍

Riot/Modules/Analytics/PostHogAnalyticsClient.swift Outdated Show resolved Hide resolved
Riot/Modules/Home/AllChats/AllChatsFilterOptions.swift Show resolved Hide resolved
Riot/Modules/Home/AllChats/AllChatsLayoutSettingsManager.swift Outdated Show resolved Hide resolved
@gileluard
App Layout: Add usage measures
aa8469c 
- Update after review
@gileluard
App Layout: Add usage measures
f30fc8a 
- Updated pod file
@gileluard
App Layout: Add usage measures
6ccd832 
- Update after review
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qxWxew

@stefanceriu stefanceriu merged commit 453b689 into develop Aug 24, 2022
@stefanceriu stefanceriu deleted the gil/6618-App_Layout-Add_usage_measures branch August 24, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Layout: Add usage measures
2 participants
@gileluard @stefanceriu