Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Layout: added suppport for room invites in the all chats screen #6604

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6600

ezgif-1-aae8aba8a0

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gileluard gileluard marked this pull request as ready for review August 22, 2022 11:47
@gileluard gileluard changed the base branch from develop to gil/6514-Missing_empty_states_in_new_app_layout August 22, 2022 11:47
@gileluard gileluard requested review from a team and SBiOSoftWhare and removed request for a team August 22, 2022 11:50
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CwmPPC

@codecov-commenter
Copy link

Codecov Report

Merging #6604 (9e8fe7e) into gil/6514-Missing_empty_states_in_new_app_layout (1bd8e9a) will decrease coverage by 0.02%.
The diff coverage is 0.50%.

@@                                 Coverage Diff                                 @@
##           gil/6514-Missing_empty_states_in_new_app_layout    #6604      +/-   ##
===================================================================================
- Coverage                                             6.27%    6.25%   -0.03%     
===================================================================================
  Files                                                 1457     1459       +2     
  Lines                                               154111   154294     +183     
  Branches                                             61939    62005      +66     
===================================================================================
- Hits                                                  9670     9644      -26     
- Misses                                              144033   144245     +212     
+ Partials                                               408      405       -3     
Impacted Files Coverage Δ
...les/Common/Recents/DataSources/RecentsDataSource.m 6.76% <0.00%> (-0.10%) ⬇️
...on/Recents/Views/RecentsInvitesTableViewCell.swift 0.00% <0.00%> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 0.00% <0.00%> (ø)
...ules/Home/AllChats/RoomInvitesViewController.swift 0.00% <0.00%> (ø)
...t/Modules/People/Views/InviteRecentTableViewCell.m 0.00% <0.00%> (ø)
...t/Coordinator/SpaceSelectorBottomCoordinator.swift 0.00% <0.00%> (ø)
...Recents/Service/MatrixSDK/RecentsListService.swift 12.16% <50.00%> (+0.13%) ⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
...Modules/Common/ViewModel/StateStoreViewModel.swift 30.55% <0.00%> (-19.45%) ⬇️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 54.66% <0.00%> (-4.00%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Base automatically changed from gil/6514-Missing_empty_states_in_new_app_layout to develop August 22, 2022 14:38
@gileluard gileluard merged commit 24f1e2d into develop Aug 22, 2022
@gileluard gileluard deleted the gil/6600-Room_invites_in_the_all_chats branch August 22, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room invites in the all chats
3 participants