Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update camera, contacts and photos usage strings for App Store review. #6560

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 11, 2022

Updates some usage strings and a screen title in FTUE

Fixes #6559 🤞

Contacts Photos Camera
Simulator Screen Shot - iPhone 13 Pro - 2022-08-11 at 16 48 51 Simulator Screen Shot - iPhone 13 Pro - 2022-08-11 at 16 49 09 IMG_360742F9BE29-1
FTUE Header
Screenshot 2022-08-11 at 4 42 55 pm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave changed the base branch from develop to hotfix/1.8.26 August 11, 2022 15:47
@pixlwave pixlwave requested review from a team and aringenbach and removed request for a team August 11, 2022 15:51
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GN4aon

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/1.8.26@a5b8046). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             hotfix/1.8.26    #6560   +/-   ##
================================================
  Coverage                 ?    6.28%           
================================================
  Files                    ?     1458           
  Lines                    ?   153914           
  Branches                 ?    61866           
================================================
  Hits                     ?     9668           
  Misses                   ?   143840           
  Partials                 ?      406           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit ba50a88 into hotfix/1.8.26 Aug 12, 2022
@pixlwave pixlwave deleted the doug/6559-usage-strings branch August 12, 2022 08:27
@aringenbach aringenbach removed their request for review November 23, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Rejection: August 11, 2022
3 participants