Implement new space selector bottom sheet #6518
Conversation
- First implementation
# Conflicts: # Riot/Generated/UntranslatedStrings.swift
- Update after reviews
- Added new analytics
- Last tweaks
- fixed theme issues
- fixed build after merge - renamed AllChats classes
- new Build settings newAppLayoutEnaled
- Removed the Pinned space feature
- Removed the All chats layout editor screen - Added feature flag - Added context menus
- Removed analytics used for IA test
- Added Space selector bottom sheet - Changed placement for the context menus in the all chats screen
- Code tweaks
- Code cleanup
…Implement_new_Space_selector_bottom_sheet
- Update after design review
- Update after review
- Code cleanup
…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift
- Added space switching analytics - Implemented unit and UI test for space selector bottom sheet
- Animation for bottom action panel - UI tweaks
- Temporarily reintroduced invites
Co-authored-by: Doug <[email protected]>
- Update after code review
…vector-im/element-ios into gil/6079-Delight_Edit_layout_experiment
- Changed Recents type to Breadcrumbs
- Update after code review
- Update after code review
…Implement_new_Space_selector_bottom_sheet # Conflicts: # Riot/Modules/Home/AllChats/AllChatsActionPanelView.swift # Riot/Modules/Home/AllChats/AllChatsActionPanelView.xib # Riot/Modules/Home/AllChats/AllChatsViewController.swift # Riot/Modules/TabBar/TabBarCoordinator.swift
- Do not show coach message with the new App Layout
…tom_sheet # Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Strings.swift # Riot/Modules/Common/Recents/DataSources/RecentsDataSource.m # Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift # Riot/Modules/Common/Recents/Service/Mock/MockRecentsListService.swift # Riot/Modules/Common/Recents/Service/RecentsListServiceProtocol.swift # Riot/Modules/ContextMenu/ActionProviders/AllChatsActionProvider.swift # Riot/Modules/Home/AllChats/AllChatsViewController.swift # Riot/Modules/Home/AllChats/AllChatsViewController.xib # Riot/Modules/TabBar/TabBarCoordinator.swift
- Removed unnecessary images - Changed for SVG format
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9aNsw8 |
- Now using the default toolbar of the navigation controller
- Removed the swipe actions menu in recents
Codecov Report
@@ Coverage Diff @@
## develop #6518 +/- ##
===========================================
- Coverage 6.20% 6.17% -0.03%
===========================================
Files 1462 1473 +11
Lines 157168 157865 +697
Branches 63166 63447 +281
===========================================
- Hits 9745 9742 -3
- Misses 147014 147715 +701
+ Partials 409 408 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- Reverted some Theme tweaks to fix some UI regressions
- Added change log - Hide toolbar when leave All Chats screen
Riot/Assets/Images.xcassets/Home/home_my_spaces_action.imageset/Contents.json
Show resolved
Hide resolved
Riot/Modules/ContextMenu/ActionProviders/AllChatsEditActionProvider.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Spaces/SpaceSelectorBottomSheet/SpaceSelector/SpaceSelectorModels.swift
Outdated
Show resolved
Hide resolved
| updateToolbar(with: editActionProvider.updateMenu(with: mainSession, parentSpace: currentSpace, completion: { [weak self] menu in | ||
| self?.updateToolbar(with: menu) |
There was a problem hiding this comment.
I'm confused, this appears to update the toolbar twice with the same menu 🤔
There was a problem hiding this comment.
This looks odd, I agree, but I can explain 🧐
The menu contains 3 items "Invite people", "Add Room", and "Create subspace" that are available only if the user has the required power level. Fetching the power levels of a room is asynchronous.
My Idea was to implement AllChatsEditActionProvider.updateMenu() method so it returns a context menu with all sensible items disabled at first, fetches, in the meantime, the power levels of the space and then calls back the caller with the final menu.
There was a problem hiding this comment.
Riiight, makes sense now. 👍
Maybe add a couple of comments here and on the updateMenu method to that effect?
- update after code review
- Added some comments
|
Kudos, SonarCloud Quality Gate passed!
|
gileluard
deleted the
gil/6410-Implement_new_Space_selector_bottom_sheet
branch
resolves #6410, resolves #6411, resolves #6408