Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status bar style when using a custom theme. #6506

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 1, 2022

This PR fixes reproducible issues of #6487 where the home tab shows with an incorrect status bar colour.

Since adding the wrapper view, the system hasn't been calling preferredStatusBarStyle directly on HomeViewController so has left it as the default style.

Before After
Simulator Screen Shot - iPhone SE (2nd generation) - 2022-08-01 at 17 39 39 Simulator Screen Shot - iPhone SE (2nd generation) - 2022-08-01 at 17 38 36

@pixlwave pixlwave requested review from a team and ismailgulek and removed request for a team August 1, 2022 16:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QmmZfe

@pixlwave pixlwave merged commit 4928fac into develop Aug 2, 2022
@pixlwave pixlwave deleted the doug/6487-wrapper-status-bar-style branch August 2, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants