Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location sharing: Handle live location sharing start event reply in the timeline (PSG-4) #6447

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

SBiOSoftWhare
Copy link
Contributor

Close #6423

Simulator Screen Shot - iPhone 13 - 2022-07-18 at 15 52 22

@SBiOSoftWhare SBiOSoftWhare requested review from a team and pixlwave and removed request for a team July 18, 2022 14:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vwW5ji

@codecov-commenter
Copy link

Codecov Report

Merging #6447 (8c1e655) into develop (12b4485) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6447      +/-   ##
===========================================
+ Coverage     6.23%    6.26%   +0.03%     
===========================================
  Files         1453     1453              
  Lines       155687   155710      +23     
  Branches     62548    62560      +12     
===========================================
+ Hits          9704     9756      +52     
+ Misses      145579   145546      -33     
- Partials       404      408       +4     
Impacted Files Coverage Δ
Riot/Generated/Strings.swift 2.93% <ø> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...tyles/Plain/Cells/Location/LocationPlainCell.swift 0.00% <0.00%> (ø)
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 83.72% <0.00%> (-9.31%) ⬇️
...ation/Legacy/LegacyAuthenticationCoordinator.swift 8.33% <0.00%> (-0.44%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 19.01% <0.00%> (ø)
Riot/Modules/Application/LegacyAppDelegate.m 13.62% <0.00%> (+0.33%) ⬆️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 39.58% <0.00%> (+4.16%) ⬆️
Riot/Managers/Call/CallPresenter.swift 6.21% <0.00%> (+5.13%) ⬆️
Config/CommonConfiguration.swift 90.90% <0.00%> (+5.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4485...8c1e655. Read the comment docs.

@SBiOSoftWhare SBiOSoftWhare merged commit 1d6a61c into develop Jul 18, 2022
@SBiOSoftWhare SBiOSoftWhare deleted the steve/6423_lls_reply branch July 18, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location sharing: Handle live location sharing start event reply in the timeline
3 participants