Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directory bottom layout #6298

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Fix directory bottom layout #6298

merged 3 commits into from
Jun 15, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 14, 2022 •
edited
Loading

Fixes #5113

Used tableFooterView instead of contentInset because KeyboardAvoider overrides that value.

@ismailgulek ismailgulek requested review from a team, Anderas and gileluard and removed request for a team June 14, 2022 15:33
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RBoSxX

gileluard
gileluard approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Anderas
Anderas reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@Anderas Anderas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the constant of 50 come from? Could this be too much / too little on other devices? (iPad, iPhone SE ...)

@ismailgulek
Copy link
Contributor Author

Where does the constant of 50 come from? Could this be too much / too little on other devices? (iPad, iPhone SE ...)

You right, it was not ideal, updated.

@ismailgulek ismailgulek requested a review from Anderas June 15, 2022 15:54
@ismailgulek ismailgulek merged commit e268a2c into develop Jun 15, 2022
@ismailgulek ismailgulek deleted the ismail/5113_directory_bottom_layout branch June 15, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gileluard gileluard gileluard approved these changes

@Anderas Anderas Anderas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to join the last room in the list
3 participants
@ismailgulek @Anderas @gileluard