-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTUE: Use the Identity server specified in the well-known #6246
Conversation
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AxTJyD |
Tests crash with It seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
On the tests, I added a MockSessionCreator
as part of #6229 to help with the crypto issue as SessionCreator
creates the session in the same way as AuthenticationViewController
by adding an MXKAccount
. But that's not really of help here, and that PR is also failing tests when run on the CI. Not sure what the best route is going to be 🫤
It was due to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice 🥳
Fixes #6177