Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTUE: Use the Identity server specified in the well-known #6246

Merged
merged 7 commits into from
Jun 6, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #6177

@ismailgulek ismailgulek requested a review from pixlwave June 3, 2022 15:10
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AxTJyD

@ismailgulek
Copy link
Contributor Author

ismailgulek commented Jun 6, 2022

Tests crash with Riot (21626) encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted. (Underlying Error: Crash: Riot (21626) CommonConfiguration.setupSettingsWhenLoaded(for:). If you believe this error represents a bug, please attach the result bundle at /Users/runner/work/element-ios/element-ios/build/test/Riot.xcresult)).

It seems matrixSession.crypto is nil.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

On the tests, I added a MockSessionCreator as part of #6229 to help with the crypto issue as SessionCreator creates the session in the same way as AuthenticationViewController by adding an MXKAccount. But that's not really of help here, and that PR is also failing tests when run on the CI. Not sure what the best route is going to be 🫤

@ismailgulek
Copy link
Contributor Author

Tests crash with Riot (21626) encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted. (Underlying Error: Crash: Riot (21626) CommonConfiguration.setupSettingsWhenLoaded(for:). If you believe this error represents a bug, please attach the result bundle at /Users/runner/work/element-ios/element-ios/build/test/Riot.xcresult)).

It seems matrixSession.crypto is nil.

It was due to the credentials.deviceId was not provided in the mock credentials and MXKAccountManager instance saved this account like a real one into its file. I've added savingAccountsEnabled property and disabled it in the tests to overcome this.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice 🥳

@ismailgulek ismailgulek merged commit 4bf15d7 into develop Jun 6, 2022
@ismailgulek ismailgulek deleted the ismail/6177_wellknown_IS branch June 6, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication: Use the Identity server specified in the well-known.
2 participants