-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering fixes #6184
Filtering fixes #6184
Changes from all commits
208da5c
6b5dc8d
3661900
e016e75
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,11 +44,16 @@ class HomeViewControllerWithBannerWrapperViewController: UIViewController, MXKVi | |
view.backgroundColor = .clear | ||
|
||
stackView = UIStackView() | ||
stackView.translatesAutoresizingMaskIntoConstraints = false | ||
stackView.axis = .vertical | ||
stackView.distribution = .fill | ||
stackView.alignment = .fill | ||
|
||
view.vc_addSubViewMatchingParentSafeArea(stackView) | ||
view.addSubview(stackView) | ||
NSLayoutConstraint.activate([stackView.topAnchor.constraint(equalTo: self.view.safeAreaLayoutGuide.topAnchor), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only caring about the top safe area layout guide as that's the place we show the version banner. The bottom one will be handled by the real homeVC. |
||
stackView.leftAnchor.constraint(equalTo: self.view.leftAnchor), | ||
stackView.rightAnchor.constraint(equalTo: self.view.rightAnchor), | ||
stackView.bottomAnchor.constraint(equalTo: self.view.bottomAnchor)]) | ||
|
||
addChild(homeViewController) | ||
stackView.addArrangedSubview(homeViewController.view) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fixed filtering search bar not resetting properly when cancelling or switching tabs. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fixed home screen shrinking too much on opening the keyboard. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this differently named changelog be picked up? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, it's part of our normal naming scheme - https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#changelog -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This basically makes it the same as all the other tabs in which it worked properly.