-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locheck run script to Riot target. #6069
Conversation
Switch to a pre-build step to fail faster.
Update INSTALL.md and check in Brewfile.lock.json.
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iSYnPv |
@@ -1,640 +1,632 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I’m not exactly sure why this happens to happen when ran the script to clean the strings, but Pirate is an excluded language from the project anyway, so personally I’m not convinced there’s too much to be worried about here. Happy to tidy it up manually though if that’s a better idea 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me 👍
Just a small conversation starter on Brewfile contents.
"HOMEBREW_PREFIX": "/opt/homebrew", | ||
"Homebrew/homebrew-core": "c56787cde0b726d961c1949aca8548551133975e", | ||
"CLT": "", | ||
"Xcode": "13.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this, was wondering if it was a good or bad thing. At the moment I'm feeling that this is a good thing since this can help us notice if we're not in sync with everyone else on XCode/macOS versions.
Still pointing this out for other people thoughts on it :)
We have to be careful what changes we commit for this file though
"HOMEBREW_VERSION": "3.4.8", | ||
"HOMEBREW_PREFIX": "/opt/homebrew", | ||
"Homebrew/homebrew-core": "c56787cde0b726d961c1949aca8548551133975e", | ||
"CLT": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this field is not empty for me as well, I don't think it's a problem, but it would be better to know what it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command line tools version? I know I don't have those installed atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah that's why it's empty for you then. It's probably only informative anyway (in our case at least).
This PR makes 2 changes to the project:
en
.As locheck is only available through Mint, the installation instructions have been updated, and I've added a
Brewfile
containing this dependency along with Xcodegen.